unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: * lisp/progmodes/eglot.el (eglot--connect): Use project-name
@ 2022-11-24 14:43 João Távora
  2022-11-24 21:30 ` [SPAM UNSURE] " Stephen Leake
  2022-11-24 21:35 ` Dmitry Gutov
  0 siblings, 2 replies; 5+ messages in thread
From: João Távora @ 2022-11-24 14:43 UTC (permalink / raw)
  To: Stephen Leake, emacs-devel, Dmitry Gutov

[-- Attachment #1: Type: text/plain, Size: 1110 bytes --]

Stephen,

In this commit:

commit 1f39da3098a2a4cec9985e6db934ed14b7b522b7
Author: Stephen Leake <stephen_leake@stephe-leake.org>
Date:   Tue Nov 22 11:43:22 2022 -0800

    * lisp/progmodes/eglot.el (eglot--connect): Use project-name

    As discussed in bug#48747.

You use an fboundp check for the project-name function recently
added to project.el.

This is not necessary in eglot.el, since it already depends on the
project.el :core ELPA package.  eglot.el is itself such a package.
So you must merely bump the "Version:" of the project.el package in
that file and then make eglot.el reference the new version in its
"Package-Requires:".

Of course you should/could ask permission before bumping
project.el's version (or not, depends on Dmitry's policy)

This way we can avoid those pesky checks. I'll change the commit
to use package-name directly now.

João

PS: When about to apply a patch to eglot.el, even one where I
have already approved the underlying idea, I would appreciate
it if you could just shoot me a personal mail showing the full
contents of the patch.

[-- Attachment #2: Type: text/html, Size: 1542 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-11-25 15:14 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-24 14:43 * lisp/progmodes/eglot.el (eglot--connect): Use project-name João Távora
2022-11-24 21:30 ` [SPAM UNSURE] " Stephen Leake
2022-11-24 21:35 ` Dmitry Gutov
2022-11-25  9:28   ` João Távora
2022-11-25 15:14     ` Dmitry Gutov

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).