From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: BIKESHED: completion faces Date: Thu, 7 Nov 2019 16:00:26 +0000 Message-ID: References: <83h83ignrz.fsf@gnu.org> <83ftj2gma8.fsf@gnu.org> <87zhhaxalt.fsf@gmail.com> <83bltpgffr.fsf@gnu.org> <83tv7gg9oz.fsf@gnu.org> <83r22kg8pa.fsf@gnu.org> <20191106205133.njij3ve7qqy7yh3q@Ergus> <83ftizg4nr.fsf@gnu.org> <8336ezg2vm.fsf@gnu.org> <83wocbelu1.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="119819"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Ergus , Dmitry Gutov , Stefan Monnier , emacs-devel To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Nov 07 17:02:24 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iSkEo-000V01-Ok for ged-emacs-devel@m.gmane.org; Thu, 07 Nov 2019 17:02:22 +0100 Original-Received: from localhost ([::1]:44690 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iSkEn-0008OA-2I for ged-emacs-devel@m.gmane.org; Thu, 07 Nov 2019 11:02:21 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36497) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iSkDB-0008Kz-Ie for emacs-devel@gnu.org; Thu, 07 Nov 2019 11:00:42 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iSkDA-0003sv-Fo for emacs-devel@gnu.org; Thu, 07 Nov 2019 11:00:41 -0500 Original-Received: from mail-io1-xd33.google.com ([2607:f8b0:4864:20::d33]:45104) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iSkD8-0003s8-WF; Thu, 07 Nov 2019 11:00:39 -0500 Original-Received: by mail-io1-xd33.google.com with SMTP id v17so1758613iol.12; Thu, 07 Nov 2019 08:00:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=oxeD45xMxrHBOYdGLRPyVSx0FVws4blyjUnt8abh/OI=; b=H3KWJm70oS3hvT30NFRbW05gxOPPFaQEVL0fbIyTk1ONvkrR1aEDB0z/UoMCO5OBSH xfmHgSfMX5xYZif8iafKE6tk313lnJebOUshNyuuFTep4UkdluFVVGHKwxlCdlv62WHg w0PdE1y+e5BBUBBxxBZktJ++jKJcxOJ+qHXzGMJDqRX6r8Olxgf+ncqeB/0nn42x6XNb l2BRRodNM/TtEmrkkZfHp97hVNxkSiayrA/TKnyNcCxMj2q7GF6/U5fHBwJH2YRJ499B j42r+FMyoFdHmKHLBNyLcmY4xgzUvrIdKEplQS9Z9Ptd97PVz3r1p8O2rjos+3SesIeJ Hm3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=oxeD45xMxrHBOYdGLRPyVSx0FVws4blyjUnt8abh/OI=; b=hbSUUmXUydpKuZKZfaZ+26xRgXUgpx4SqMOa/EJ3TfvJYdYprGxHT3frytgNgI/gxQ c/oQw4pFnKgR+0hzVocBHh+U7hj3oVbPdspKe5wsE1sc8Au4HbceyxAqWecZtrpgnqme BJ2MPkNw3Nl7pO0/OXgoBM8yaAl1I45goy7bKVIAvaYicmjaU5WcbCPvbqP1KBcsAdfs g7fi1ZRhTYFUiNZy3P5PAwVHqFgRxgEm+ZfVrDrarGKWH1Ur6N3BD3IH4ylZIsoboRxA ihuQN7EJ+h1P1vmkaekvS0q35TCxjdBzbz2abPB+YeQUgY94xeeYwbDCRcCWBl8Czszx gYtA== X-Gm-Message-State: APjAAAWb8mns7sLmefRfrVc3KMMyAnDGk5wLjK+0xevtBvucT91evWne tI9R5tj5vfcRc9oIQjyi97UUAItI9tO9bWDXuBVdGw== X-Google-Smtp-Source: APXvYqxrLkCaz4Kv1rogXb+Ic+f5SJoQli/Zig9Xr4ygaOqlZxC3zlFhlOU8OYRHDSFJ22kJSjBbzlHhDEJRT7PjAdc= X-Received: by 2002:a5d:8b94:: with SMTP id p20mr3988008iol.97.1573142437739; Thu, 07 Nov 2019 08:00:37 -0800 (PST) In-Reply-To: <83wocbelu1.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::d33 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:241938 Archived-At: On Thu, Nov 7, 2019 at 3:40 PM Eli Zaretskii wrote: > > > From: Jo=C3=A3o T=C3=A1vora > > Date: Thu, 7 Nov 2019 15:00:41 +0000 > > Cc: Ergus , emacs-devel , > > Stefan Monnier , Dmitry Gutov > > > > OK! So will you accept a version of my "renames" patch that affects > > just the `flex` completion style? (or maybe the flex and the other > > esoteric completion styles (pcm, substring)? > > I admit that I don't understand the purpose of that renaming. I > thought we were discussing how to highlight parts of completion > candidates differently from what we do now, not about renaming the > related faces. Why are face names important enough to justify their > renaming? We _can_ do it without renaming, but then flex would be applying "first-difference" to mean "I, flex, want these parts of the completions I generate emphasized". Which could lead to confusion when reading the code. So, if we rename, keeping backward-compatible face aliases "first-difference" to "completion-emphasis" and "common-part" to "secondary-emphasis" then it's not so confusing, when reading the code or when inspecting a completion candidate. It still fits nicely with the traditional 'basic's view of completion (main emphasis on first difference, secondary emphasis on common part) and is generically useful for new completion styles. Thanks for giving this a second look, Jo=C3=A3o