From: "João Távora" <joaotavora@gmail.com>
To: Ted Zlatanov <tzz@lifelogs.com>
Cc: 14380@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
Subject: Re: bug#14380: 24.3; `network-stream-open-tls' fails in some imap servers on w32
Date: Mon, 20 May 2013 23:07:30 +0100 [thread overview]
Message-ID: <CALDnm51-4aTee3NGoRp+=T6MuTV3xD9P4Ed1yZLU_E5k_r5hGw@mail.gmail.com> (raw)
In-Reply-To: <87txly4ll9.fsf@lifelogs.com>
On Mon, May 20, 2013 at 12:05 AM, Ted Zlatanov <tzz@lifelogs.com> wrote:
>
> Using an external binary to transport SSL or TLS is a hack IMO.
I see, and reading a bit of tls.el it makes sense. It does all this
crazy regexp searching... This is a hack in my book too, albeit one
that's been working fine,
> Did you propose a patch? I would commit a patch but can't write it
> despite your great description of the problem.
>
Here is a patch that should be equivalent to the defadvice I'm using.
As I said, it works for me. Also I didn't have a VC copy of emacs so I
used `diff-buffer-with-file'
diff -u -L /usr/local/share/emacs/24.3/lisp/net/tls.el.gz -L
\#\<buffer\ tls.el.gz\> /tmp/jka-com1909LVh
/tmp/buffer-content-1909lpt
--- /usr/local/share/emacs/24.3/lisp/net/tls.el.gz
+++ #<buffer tls.el.gz>
@@ -286,7 +286,11 @@
(format "Host name in certificate doesn't \
match `%s'. Connect anyway? " host))))))
(setq done nil)
- (delete-process process)))
+ (delete-process process))
+ ;; delete all the informational messages that could
+ ;; confuse futures users of `buffer'
+ ;;
+ (delete-region (point-min) (point)))
(message "Opening TLS connection to `%s'...%s"
host (if done "done" "failed"))
(when use-temp-buffer
João
--
João Távora
next prev parent reply other threads:[~2013-05-20 22:07 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87k3mw79iv.fsf@lifelogs.com>
[not found] ` <CALDnm51ZBQn_T0w43TfNiui+nfBcJL5z_4egAXmtwdHOW3qCXQ@mail.gmail.com>
2013-05-19 3:17 ` bug#14380: 24.3; `network-stream-open-tls' fails in some imap servers on w32 Ted Zlatanov
2013-05-19 11:45 ` João Távora
2013-05-19 23:05 ` Ted Zlatanov
2013-05-20 2:08 ` Juanma Barranquero
2013-05-20 9:58 ` Ted Zlatanov
2013-05-20 15:21 ` Juanma Barranquero
2013-05-24 19:32 ` Ted Zlatanov
2013-05-24 19:50 ` Eli Zaretskii
2013-05-24 21:55 ` Ted Zlatanov
2013-05-25 6:42 ` Eli Zaretskii
2013-05-25 22:18 ` Ted Zlatanov
2013-05-26 2:52 ` Eli Zaretskii
2013-05-26 21:32 ` Ted Zlatanov
2013-05-26 19:59 ` Eli Zaretskii
2013-05-26 21:31 ` Ted Zlatanov
2013-05-24 19:51 ` Stefan Monnier
2013-05-24 21:53 ` GnuTLS updates proposal (was: bug#14380: 24.3; `network-stream-open-tls' fails in some imap servers on w32) Ted Zlatanov
2013-05-25 1:52 ` GnuTLS updates proposal Stefan Monnier
2013-05-25 2:54 ` Ted Zlatanov
2013-05-25 4:47 ` Stefan Monnier
2013-05-25 6:25 ` Stephen J. Turnbull
2013-05-25 22:28 ` Ted Zlatanov
2013-05-26 4:51 ` Richard Stallman
2013-05-26 21:28 ` Ted Zlatanov
2013-05-25 6:39 ` GnuTLS updates proposal (was: bug#14380: 24.3; `network-stream-open-tls' fails in some imap servers on w32) Eli Zaretskii
2013-05-25 7:10 ` GnuTLS updates proposal Stefan Monnier
2013-05-26 21:34 ` Ted Zlatanov
2013-06-05 14:57 ` Ted Zlatanov
2013-05-26 1:53 ` GnuTLS updates proposal (was: bug#14380: 24.3; `network-stream-open-tls' fails in some imap servers on w32) Juanma Barranquero
2013-05-20 16:17 ` bug#14380: 24.3; `network-stream-open-tls' fails in some imap servers on w32 Eli Zaretskii
2013-05-24 19:27 ` Ted Zlatanov
2013-05-20 22:07 ` João Távora [this message]
2013-06-05 15:06 ` Ted Zlatanov
2013-06-06 8:15 ` João Távora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALDnm51-4aTee3NGoRp+=T6MuTV3xD9P4Ed1yZLU_E5k_r5hGw@mail.gmail.com' \
--to=joaotavora@gmail.com \
--cc=14380@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=tzz@lifelogs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).