From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: eglot--spinner Date: Fri, 18 Nov 2022 08:48:54 +0000 Message-ID: References: <86r0y07jlw.fsf@stephe-leake.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000d532e405edbac2ea" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1060"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel To: Stephen Leake , Danny Freeman Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Nov 18 09:48:58 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ovx3S-000055-3O for ged-emacs-devel@m.gmane-mx.org; Fri, 18 Nov 2022 09:48:58 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ovx2m-000064-4Q; Fri, 18 Nov 2022 03:48:16 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ovx2V-0008UD-K7 for emacs-devel@gnu.org; Fri, 18 Nov 2022 03:48:14 -0500 Original-Received: from mail-oa1-x36.google.com ([2001:4860:4864:20::36]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ovx2R-00018H-PD for emacs-devel@gnu.org; Fri, 18 Nov 2022 03:47:58 -0500 Original-Received: by mail-oa1-x36.google.com with SMTP id 586e51a60fabf-13c2cfd1126so5184263fac.10 for ; Fri, 18 Nov 2022 00:47:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=UXVgLMYQdoHvaI/qKWJbeO4tTqV4S6U1Jd/yX20PuCM=; b=I+Tr2EDHr7P5N4/uSlSzMTnLG4lZmlPshyT14NRagOFLAfSfvUHvuMaoq4u3dg5yWe CrRV9kH3iweol2h9xLYpTw/FnGpGUZS+zmpiR7a0OwsMOcNkqZwu6wQQ+S0kH6XFndox BsvlFG7aIKHBsWKy3Gfn2lE+79DzvdXmnu4g4faOdBRx7BlDnAOh4TDz4nFRrRnwFVvJ 2ajqBNjaRZubJ01k6TIaPJu+iM2dvBn1hWaWUmFmRiUwySx+Dv9XOpm0/a1yNSYwIZoT 88UQ/9JnBxL6eJXz1Y5oXT9S3tyeMGXU/yE9q/GKl9h50V2RRiqCjCaEOJrMjVFIt8TT IgUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UXVgLMYQdoHvaI/qKWJbeO4tTqV4S6U1Jd/yX20PuCM=; b=52PHybP/ZiehUaqCDhz5JrDikMVTEUA+UwDdgspl5nMy/T93i714wrowqLcH+MVI4K p2PD2DqKurzc1uYCwk1CojYAtoe2DdPt8v9FTIlUTZwAvOHeGskLtP/Dq0etVE0qvl2i Bm9m8fAAutJl26OhW55kvBDQinKNRrCh32FmA+nXtJjsQt8XA0KFYRcAw6mENLV5pQoS hP+XEth9QTJ6Sj1kwmmAAhHuU/oTwNdrwEChLh+i8YOQMn0nbG2sxbYbYq3qu2wGFvdG pTtjqqGJyYr0ylTQqdrWVDBuPxWdTygx4JFV7es06ZxDZCffOSvdvKxA8I7cVl635CpA U05A== X-Gm-Message-State: ANoB5plgOTmQ16Ssy/qTZk94Hfz9P90SEWXh7cXcfHQbK0FUMZ0cr1ON 2P74zk+OhuF24+RjVAxQKcfhFJoIlXOYErg2lbWGY8vgMFWnUA== X-Google-Smtp-Source: AA0mqf4XYDUPybOX/0vxR4T8OdJHInD7kK8P4siXxx8uK+Dmfz3/RrTYRa7nTzZBMs/rcwK7wWnn0+7ESBGf8SPBaKU= X-Received: by 2002:a05:6871:4590:b0:132:a103:ae22 with SMTP id nl16-20020a056871459000b00132a103ae22mr3448521oab.215.1668761272003; Fri, 18 Nov 2022 00:47:52 -0800 (PST) In-Reply-To: <86r0y07jlw.fsf@stephe-leake.org> Received-SPF: pass client-ip=2001:4860:4864:20::36; envelope-from=joaotavora@gmail.com; helo=mail-oa1-x36.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:300100 Archived-At: --000000000000d532e405edbac2ea Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Stephen, Look in the bug tracker: there's someone implementing a better progress indicator with an implementation that looks very good from what I've seen so far and uses LSP interfaces. Here it is: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D59149 We can/should try to coalesce the "eglot--spinner" with that. Thanks, Jo=C3=A3o On Fri, Nov 18, 2022 at 8:27 AM Stephen Leake < stephen_leake@stephe-leake.org> wrote: > The only uses of eglot--spinner in eglot.el are: > > eglot--mode-line-format, where it is added to the mode line. > > eglot--signal-textDocument/didChange, where it is set to (list nil > :textDocument/didChange t), meaning didChange is done. Because this is > set to done, it is not actually displayed in the modeline. > > For ada-mode, I'd like to use eglot--spinner to show "indexing" > progress; the server is parsing all the files in the project, collecting > cross reference information, which takes a while. The user needs to know > when it is done; then they can use cross reference commands. > > So I'd like to delete setting eglot--spinner in > eglot--signal-textDocument/didChange; otherwise that will overwrite the > indexing progress when a buffer is edited. > > This would also imply making eglot--spinner public. > > That then raises the issue of future conflicting uses of eglot-spinner. > So perhaps it would be better for ada-mode to add another item to the > mode line? To do that requires a hook in eglot--mode-line-format, so it > is grouped with the other eglot-derived mode line items. > > -- > -- Stephe > --=20 Jo=C3=A3o T=C3=A1vora --000000000000d532e405edbac2ea Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Stephen,

Look in the= bug tracker: there's someone implementing a better
prog= ress indicator with an implementation that looks very good
f= rom what I've seen so far and uses LSP interfaces.

=

We can/should try to coalesce the "eglot--spinner&= quot; with that.

Thanks,
Jo=C3=A3o


On Fri, Nov 18, 2022 at 8:27 AM Stephen Leake <stephen_leake= @stephe-leake.org> wrote:
The only uses of eglot--spinner in eglot.el are:

eglot--mode-line-format, where it is added to the mode line.

eglot--signal-textDocument/didChange, where it is set to (list nil
:textDocument/didChange t), meaning didChange is done. Because this is
set to done, it is not actually displayed in the modeline.

For ada-mode, I'd like to use eglot--spinner to show "indexing&quo= t;
progress; the server is parsing all the files in the project, collecting cross reference information, which takes a while. The user needs to know when it is done; then they can use cross reference commands.

So I'd like to delete setting eglot--spinner in
eglot--signal-textDocument/didChange; otherwise that will overwrite the
indexing progress when a buffer is edited.

This would also imply making eglot--spinner public.

That then raises the issue of future conflicting uses of eglot-spinner.
So perhaps it would be better for ada-mode to add another item to the
mode line? To do that requires a hook in eglot--mode-line-format, so it
is grouped with the other eglot-derived mode line items.

--
-- Stephe


--
Jo=C3=A3o = T=C3=A1vora
--000000000000d532e405edbac2ea--