From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] scratch/fix-33794-extend-electric-layout-mode 41a9132: Extend electric-layout-mode to handle more complex layouts Date: Fri, 28 Dec 2018 16:33:52 +0000 Message-ID: References: <20181221180327.7142.84494@vcs0.savannah.gnu.org> <20181221180328.D755D20538@vcs0.savannah.gnu.org> <87sgyp6ysy.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1546014978 7310 195.159.176.226 (28 Dec 2018 16:36:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 28 Dec 2018 16:36:18 +0000 (UTC) Cc: emacs-devel To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Dec 28 17:36:14 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gcv7N-0001mL-KY for ged-emacs-devel@m.gmane.org; Fri, 28 Dec 2018 17:36:13 +0100 Original-Received: from localhost ([127.0.0.1]:60005 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gcv9U-0004mY-Cd for ged-emacs-devel@m.gmane.org; Fri, 28 Dec 2018 11:38:24 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:48740) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gcv7v-0004e5-2Y for emacs-devel@gnu.org; Fri, 28 Dec 2018 11:36:48 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gcv5K-0001jr-Vt for emacs-devel@gnu.org; Fri, 28 Dec 2018 11:34:08 -0500 Original-Received: from mail-qk1-x72e.google.com ([2607:f8b0:4864:20::72e]:34154) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gcv5J-0001hm-40 for emacs-devel@gnu.org; Fri, 28 Dec 2018 11:34:05 -0500 Original-Received: by mail-qk1-x72e.google.com with SMTP id q8so12826260qke.1 for ; Fri, 28 Dec 2018 08:34:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=ZbcTTg5CQM6Z2gVpwRbdmmxluUjLQXNC3XuaIfJ2WJo=; b=RuUDfTqmXqWSak8DmHyEhwzZ7Vk4d3+J/jh4V7k0TK2G445AkA0aDYpn3AXVexB/fh GOI+EXcj8Hne66EjqaelMhGGu9kC0obtsesLW1Q2lQDrXnMjPNUfFxReerRecc/xOCzV KflkLR+B1CtNPSwc6NwOAWHLFVQ/MSe83TjUx+cQnb+meNEmqUh90qXZbO3mpkLxo01X hQWpI+P9LRZ43o1u5hEjZxG6sM6VFxsu1fd/HcWBm6kQOuvcJceJhuIr6DK4gU+BKRFE BiFUqk07KcAvwz+G8SoUHgX0wh+DHF9MfMshIdThgOlF8Dh8cBjUjOAu0eoqxI1Q7yO8 4s7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=ZbcTTg5CQM6Z2gVpwRbdmmxluUjLQXNC3XuaIfJ2WJo=; b=GfNsKl5qiE/rj18/F1ksFpekfCgnZ8PZFy45NhGk9Kexlr2sWjkEGhSxS+MKML1p41 SuuUbu4jpP/HqJORG01QCVnTv6sPXvnHZGN0LxwHPNL5F2sJXD2brdFhHebc1oOYb5dw fpU82m3xG/Wh2xZLeQhzPsZWwG5SsVXHjf3jVju2HaKJIuMnlXCG9qKSg5MUrVIAjLlv qISQ+Alneme0oyASm6Mnd4Og0GxCAIKdBH5aVo7HDt2hD2IdBmfi5hb9jYeXkBcf0/G9 d5p8JDbpNJfNBvX4ZTSdOUxnhSGcVao7bw2tRUiLXOvwLdFcEup055UCx+OHqusmdVRH whFg== X-Gm-Message-State: AJcUukeAWgqSpBdA2n0+4DeGG/g+gLYscgDDwwJK7IjfS+wwVjNVlN6M OqTCM+m/KucA/nksl1L1j4rYvqcfZbcN1o8FOco= X-Google-Smtp-Source: ALg8bN6VF5dcfsuuOcDcJQjnUgkF/2llvegpzpeIFoZZ96n9O43ecYfetKt9vR5FVF58Y1aNYHdjApNV7+Mm56XaVdY= X-Received: by 2002:ae9:d804:: with SMTP id u4mr26016349qkf.322.1546014844076; Fri, 28 Dec 2018 08:34:04 -0800 (PST) In-Reply-To: <87sgyp6ysy.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::72e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:232018 Archived-At: On Sat, Dec 22, 2018 at 9:23 PM Jo=C3=A3o T=C3=A1vora wrote: > Stefan Monnier writes: > > >> + ('after-stay (save-excursion > >> + (let ((electric-layout-rules nil) > >> + (electric-pair-open-newline-between-= pairs nil)) > >> + (newline 1 t)))) > > > > I think the above let-binding of > > electric-pair-open-newline-between-pairs deserves a FIXME as well, > > because electric-layout-mode should ideally not need to know such > > details of about electric-pair-mode. > > Done. Indeed, as I described in the fixme > electric-pair-open-newline-between-pairs is really a question of layout > (not pairing) and thus a responsibility of e-l-m, but its API is not > powerful enough yet to detect the exact situation yet. So it seems > reasonable for now to do this, especially since > electric-pair-open-newline-between-pairs is a part of e-p-m's external > interface. Stefan, did you have a look at the most recent version of this branch? (I rebased it meanwhile) I'd like to land it in master. e-l-m's API is should now be good enough to make electric-pair-open-newline-between-pairs its responsibility. Jo=C3=A3o