From: "João Távora" <joaotavora@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: [Emacs-diffs] scratch/fix-33794-extend-electric-layout-mode 41a9132: Extend electric-layout-mode to handle more complex layouts
Date: Fri, 28 Dec 2018 16:33:52 +0000 [thread overview]
Message-ID: <CALDnm50xP8h6rTNr-RrHWZ_VG2Cd5cvFdoydvaLi6qGgdNHoRw@mail.gmail.com> (raw)
In-Reply-To: <87sgyp6ysy.fsf@gmail.com>
On Sat, Dec 22, 2018 at 9:23 PM João Távora <joaotavora@gmail.com> wrote:
> Stefan Monnier <monnier@IRO.UMontreal.CA> writes:
>
> >> + ('after-stay (save-excursion
> >> + (let ((electric-layout-rules nil)
> >> + (electric-pair-open-newline-between-pairs nil))
> >> + (newline 1 t))))
> >
> > I think the above let-binding of
> > electric-pair-open-newline-between-pairs deserves a FIXME as well,
> > because electric-layout-mode should ideally not need to know such
> > details of about electric-pair-mode.
>
> Done. Indeed, as I described in the fixme
> electric-pair-open-newline-between-pairs is really a question of layout
> (not pairing) and thus a responsibility of e-l-m, but its API is not
> powerful enough yet to detect the exact situation yet. So it seems
> reasonable for now to do this, especially since
> electric-pair-open-newline-between-pairs is a part of e-p-m's external
> interface.
Stefan, did you have a look at the most recent version
of this branch? (I rebased it meanwhile) I'd like to
land it in master. e-l-m's API is should now be good
enough to make electric-pair-open-newline-between-pairs
its responsibility.
João
next prev parent reply other threads:[~2018-12-28 16:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20181221180327.7142.84494@vcs0.savannah.gnu.org>
[not found] ` <20181221180328.D755D20538@vcs0.savannah.gnu.org>
2018-12-22 16:26 ` [Emacs-diffs] scratch/fix-33794-extend-electric-layout-mode 41a9132: Extend electric-layout-mode to handle more complex layouts Stefan Monnier
2018-12-22 21:23 ` João Távora
2018-12-28 16:33 ` João Távora [this message]
2018-12-28 17:51 ` Stefan Monnier
2018-12-28 22:00 ` João Távora
2018-12-29 15:59 ` Stefan Monnier
2018-12-29 18:36 ` João Távora
2019-01-02 1:53 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALDnm50xP8h6rTNr-RrHWZ_VG2Cd5cvFdoydvaLi6qGgdNHoRw@mail.gmail.com \
--to=joaotavora@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).