From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New package: dape Date: Sat, 4 Nov 2023 23:21:35 +0000 Message-ID: References: <46ea1ab1-e447-4c83-9c81-2f9bd149fe91@alphapapa.net> <6964ff20-921e-beff-43a0-9570ea79aa7d@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5420"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Dmitry Gutov , John Yates , Krister Schuchardt , Adam Porter , emacs-devel@gnu.org, philipk@posteo.net To: Daniel Pettersson Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Nov 05 00:19:23 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qzPvH-0001Bd-Gf for ged-emacs-devel@m.gmane-mx.org; Sun, 05 Nov 2023 00:19:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qzPuj-0003PB-Em; Sat, 04 Nov 2023 19:18:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qzPui-0003Ox-GB for emacs-devel@gnu.org; Sat, 04 Nov 2023 19:18:48 -0400 Original-Received: from mail-lf1-x12a.google.com ([2a00:1450:4864:20::12a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qzPug-0006I6-Ra for emacs-devel@gnu.org; Sat, 04 Nov 2023 19:18:48 -0400 Original-Received: by mail-lf1-x12a.google.com with SMTP id 2adb3069b0e04-507a3b8b113so4171235e87.0 for ; Sat, 04 Nov 2023 16:18:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699139924; x=1699744724; darn=gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Q2Q8SMdFmoHWghxTz4GH9gX6BLfcqpPA0kcj/nlsu2w=; b=Tzc65WYlo4uIRpXpN59ZBhDgLIIhhfaPl0d8KRidI/ABYzC5LxD/bWRiAX096z2QXT 1Nxv6GgvZflcUliALskLwYafRmBmnl4Pl0HF/vXp0uHB16+5yxj1SLBn80NnjqVHpDrJ bU/cd2//BmCPIB1dzU5o+ns74xIFQizyg53Mo8RxnuDWoHbLGBU3RmsGvN72LEOk8Fzc /f9CGEjY0CIqO4/hgTj/0rDi+DZqyra/vkABaglAp1xhy9vG5n3LOmZkPgvKb8lmc7lB U95gIRHJ/lw25uMJRWB2MS9RNMRh3wjVjBq7KkovBebuhS+iWS9rpZ1Jwl9JdMm5iOKt OmRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699139924; x=1699744724; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Q2Q8SMdFmoHWghxTz4GH9gX6BLfcqpPA0kcj/nlsu2w=; b=Pvn+xsvXGmilNolfZ+YKBdL8XOffXYlin+Ap9h/KuVDcq7BSpcnQ/ZO3Rcx2ncRV6s s3qOmV7zwOLwExzHxR/aJuQx8VHTrHaCXsuSyATHEdzcpmoGqLyd41LsuZ/QLa7YZf6S FQZ4xi/xHBsIehxi4mLV+duFgzDcD4pQQzMX8c+mEk6Bv47g/mOX/G3kuHXlcPutIyKM x112klz2BmmniWyGIRztJ9pWMqMIi1M3AwIxbysZ9D3t6+S61EjjbtC6HlbccD4Fa3Qv zSOUm1dWuu63nKb2yfC+VYuxQ3M2/jh6UI3jHDPQSteM94cFtWhlHITMhdsCJZ3kUUNo RXNg== X-Gm-Message-State: AOJu0YxvHAU/Q4olw33P7ZGYXc/uE8D6JaVQ+70UVL5uZVKE0ULTJ/UE S6wDfdPXcJTR1ie9TBoDvdzq0aUMMbA8rCib7q8= X-Google-Smtp-Source: AGHT+IF+rNkxgUgz+daK+PtHoGrK5E13z3kDxRBvUPVbEBaUD6NywHGU8CtcwhrKKBW6xxEBXEmxsqV+iE/6lqqu/VE= X-Received: by 2002:ac2:46f4:0:b0:509:44d5:18e5 with SMTP id q20-20020ac246f4000000b0050944d518e5mr6850941lfo.63.1699139924394; Sat, 04 Nov 2023 16:18:44 -0700 (PDT) In-Reply-To: Received-SPF: pass client-ip=2a00:1450:4864:20::12a; envelope-from=joaotavora@gmail.com; helo=mail-lf1-x12a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:312231 Archived-At: On Sat, Nov 4, 2023 at 9:51=E2=80=AFAM Daniel Pettersson wrote: > > On Wed, Nov 1, 2023 at 7:35=E2=80=AFPM Philip Kaludercic wrote: > > Did we ever come to a conclusion on this point? > > Sorry I have been putting the naming thing off as this thread sparked > a bit of interest in the package which lead to a lot of great input and > bugfixing. There have been a lot of good suggestions and no consensus > which has made the even task harder. I, like others, am of the opinion that you should spend little to no time in this naming bikeshedding discussion. Reserve that energy for things that actually matter. Dape or Daisy or Alberto are fine names for this package. > On Thu, Nov 2, 2023 at 5:24=E2=80=AFPM Jo=C3=A3o T=C3=A1vora wrote: > It's close but not close enough, it's able to reuse jsonrpc process > filter but it falls to pieces in `jsonrpc-connection-receive', due to > slight differences in the protocol. The protocol request/response id is > replaced by seq or request_seq and method is command in DAP to name a > few differences. Ah, I see. Indeed it's very strange that it's not JSONRPC. So I see the main difference, and it's the one you mention. It seems that if I were to change jsonrpc.el sufficiently to accomodate that particu= lar difference, then it _could_ be used. Do you know of any other significant/fundamental differences (say, such as = a message type which is neither a request, nor a response, nor a notification= )? If I were to try to do these jsonrpc.el changes to accomodate DAP protocols= , would you accept a PR to dape.el adding jsonrpc.el as a dependency to dape.el? Jo=C3=A3o