From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] (icomplete-vertical-mode): Add support for affixations and, annotations Date: Tue, 1 Jun 2021 23:39:51 +0100 Message-ID: References: <43d1599e-2ba9-2efb-45c3-76c67d29a69d@daniel-mendler.de> <87tumrgqrb.fsf@gmail.com> <87tumq92pe.fsf@mail.linkov.net> <87lf82g10g.fsf@gmail.com> <87y2c24lww.fsf@mail.linkov.net> <871r9t2lsy.fsf@mail.linkov.net> <22880197-6d05-c821-2c58-328ed3cfc02e@daniel-mendler.de> <87eedruui3.fsf@gmail.com> <8dd915fe-fe67-2a45-67ff-8aaa3e9b9aca@daniel-mendler.de> <878s3zuq47.fsf@gmail.com> <09f2a253-84ba-5cfd-552e-0b89109864a5@daniel-mendler.de> <875yyxaoxp.fsf@gmail.com> <871r9laj6a.fsf@gmail.com> <1b73a130-204c-76fb-2b60-02b814aee0f0@daniel-mendler.de> <87r1hl8xom.fsf@gmail.com> <878s3t8tzw.fsf@gmail.com> <3c68bd00-70ca-fa18-f9b8-cd03029f9294@daniel-mendler.de> <8735u18lsd.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31870"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Daniel Mendler , Juri Linkov , "emacs-devel@gnu.org" , Dmitry Gutov To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jun 02 00:41:13 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1loD4S-00088K-QG for ged-emacs-devel@m.gmane-mx.org; Wed, 02 Jun 2021 00:41:12 +0200 Original-Received: from localhost ([::1]:44586 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1loD4R-0007pC-Rb for ged-emacs-devel@m.gmane-mx.org; Tue, 01 Jun 2021 18:41:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43416) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1loD3O-00077w-6S for emacs-devel@gnu.org; Tue, 01 Jun 2021 18:40:06 -0400 Original-Received: from mail-pg1-x529.google.com ([2607:f8b0:4864:20::529]:39852) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1loD3M-0004IP-H6 for emacs-devel@gnu.org; Tue, 01 Jun 2021 18:40:05 -0400 Original-Received: by mail-pg1-x529.google.com with SMTP id v14so586905pgi.6 for ; Tue, 01 Jun 2021 15:40:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=wbjAH1//26JpHzHRNGM4uLVgVL6LUqtGLAeGGvse93E=; b=qnxgUyXkcOEU03/AonsjU1IkhA1g2wi4voCDIrr4tfomGxuftlR0waZvbrmj5iKcH2 8dO3g+Jy6tJlaGQUjgRmM5kLXnzlscEVJqPdMPCHXozw1rUS0Ms9hykqCeoitfqvVWak 4Mp+X9FpVuLnl3Q7epDaIehNq7XgZSJ2lMRQepP8ZPQG0BeoLKl7uZM07h21eXBVpGzp NncAmssZRQ3bBKuFBBH1jUfRTDenVdkbBGrDzBlABdEJ0Acg02SLzkmqE8++9ypiEhwu sCjpD7apdHIbSuJLZIHutQbhJi2JzAnGoB6+BozfLEvPwjzuBGpRiOC/w1R3QYAlAqyB D+Sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=wbjAH1//26JpHzHRNGM4uLVgVL6LUqtGLAeGGvse93E=; b=oiYcMu7aZRvq4f9Z7Xqj1Zw+hqrZ+F4dmrONL6V+t12Bv5KoGWrm+Z1LBYwoT2FQHZ MbiR8L7fi8smVLY1DI5mbCdJhHVxch0N7Irb39Gl5sE9bmRBsmIDZ62C349Z/Ebi7D/t B0xEriWZEBOZWDVVYpcCpTMS/0877MeCFpNMHYW8qlmrUkUg6nvg5k0lPuAjPqSl1Fk8 ts70a63WIhBJCGiWP4mu5Kv4dzkwlATpO/6avMe2ekxT08LW0XXfnyKnWfFRqjaQwcEY rCN1ka5bGE4HcysQfU2JzhhkqfCEd4pvvA2MiTya7W52na8uH9QwKWaqb8Cl3+bc5Drl Lcyw== X-Gm-Message-State: AOAM532ZsckMu3yi/x3yj0ocERjQVdfIcoaeJajuPzFeI4TMlxCBI4gm FMOGUR1SI6lNC/PKRMsvEHRweyZ1ab96VvGTMRc= X-Google-Smtp-Source: ABdhPJzl5qwkDvirazN3ltKmuOgLN6vD5tGb+QjoWA59Id54Yhr0nyf2PSY1NAv76iE5msuEVWjZYCfhHC8ORscQcaY= X-Received: by 2002:a63:5c01:: with SMTP id q1mr30483496pgb.447.1622587203050; Tue, 01 Jun 2021 15:40:03 -0700 (PDT) In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::529; envelope-from=joaotavora@gmail.com; helo=mail-pg1-x529.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:270256 Archived-At: On Tue, Jun 1, 2021 at 9:22 PM Stefan Monnier wr= ote: > > > ;; current > > (20.18251486 3 0.3386851209999975) > > (19.646946365 3 0.3477981569999997) > > (20.10486081 3 0.34829881900000004) > > > > ;; allocate extra cons and non-capturing function > > (21.353061817 3 0.3557993659999994) > > (21.124979874999998 3 0.361779398000003) > > (21.009165698 3 0.36675408300000356) > > So, the current design is better? It's neglibily faster IMO (and only in this particular stage). Could be slower later on, where the group function is called again on the same completion twice more. > I see no need to re-hash the whole discussion around it, unless you find > an actual concrete problem with it (rather than an aesthetic dislike). A confusing API and a complicated minibuffer.el are concrete problems IMHO. > Let's move on. If we can't agree on this design which has no clear > flaw, I can't imagine we'll ever come to an agreement for the > replacement of `affixation-function` You may not think it worth it, but the complicated minibuffer.el hampers my efforts to experiment with replacements for affixation-function. Nothing insurmountable but I for one like tighter API's and code. Jo=C3=A3o T=C3=A1vora