From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: eglot-test-diagnostic-tags-unnecessary-code fails with certain clangd versions Date: Tue, 21 Mar 2023 14:07:19 +0000 Message-ID: References: <87edq7ztks.fsf.ref@yahoo.com> <875yb3vftq.fsf@gmail.com> <87zg8f7h2d.fsf@yahoo.com> <871qlrvcc7.fsf@gmail.com> <87wn3jtwxg.fsf@gmail.com> <87v8j37ehz.fsf@yahoo.com> <87sfe7tr57.fsf@gmail.com> <87y1nzv18a.fsf@gmail.com> <87ilf27tt1.fsf@yahoo.com> <87jzziuzba.fsf@gmail.com> <87pm9a5n14.fsf@yahoo.com> <87bkkuulp5.fsf@gmail.com> <87wn3h4gld.fsf@yahoo.com> <87o7oru7i1.fsf@gmail.com> <87ttyj3i3u.fsf@yahoo.com> <87a6071xxt.fsf@yahoo.com> <87bkknr7io.fsf@gmail.com> <87355zqzbh.fsf@gmail.com> <87pm92pmtn.fsf@gmail.com> <87lejqp7zc.fsf_-_@gmail.com> <87h6uep63a.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22740"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Po Lu , emacs-devel To: Robert Pluim , Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Mar 21 15:07:56 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pecea-0005ju-7y for ged-emacs-devel@m.gmane-mx.org; Tue, 21 Mar 2023 15:07:56 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1peceG-0006ZP-9V; Tue, 21 Mar 2023 10:07:36 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1peceE-0006W6-Mm for emacs-devel@gnu.org; Tue, 21 Mar 2023 10:07:34 -0400 Original-Received: from mail-oo1-xc2c.google.com ([2607:f8b0:4864:20::c2c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1peceC-0004Bx-NV for emacs-devel@gnu.org; Tue, 21 Mar 2023 10:07:34 -0400 Original-Received: by mail-oo1-xc2c.google.com with SMTP id n7-20020a4ae1c7000000b0053b61145406so177716oot.11 for ; Tue, 21 Mar 2023 07:07:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679407651; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=wVh4g5dHebgGRDVYE4qvu21A709IWnmcpvTlcXRALnM=; b=XRR49f9moZIxbSowxsVvZfDrao1AnusPi4S5AYaTa/vEAc7ZCdxIVvSGtKJiFxtML4 jlootoViSaIivHVHypY760xO6i/EQym/cb+0P5UiWepQke2AVWM5hGlW3UT3HA0QUUc4 eJ0dArGtsyy5XQAc2+oZeoatOmPdXQqgxBYsxlm3l5b+1Dd8cCuJ+lNaiLPcuOAaeLHr QNP/T6B7uXbwkem+73PgebxEtVGnH1C7v+McvbE+WvwVX+TJ7uPONk3pF+QJfPHCyyq7 zog5R7T3moJggIl39pE08mrMFb4S9mq1uUjPiq1eeqiHeTlVs/lEOU7E1C6oBiyAF0t4 DzAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679407651; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wVh4g5dHebgGRDVYE4qvu21A709IWnmcpvTlcXRALnM=; b=x9quPuqDpBxICA/F/gn8Y2YQCnWJ/wgriB0fL4FL8u8cVL5zonuL9B4Aknj2ESIe+W 7IV/D2CPSfeeChCrvaDT4XmLShHGw8zdYfY+iKIrKCN7YkgmovR720ikMuCk/kqCxvtH 4b8F2cCZy1fLPC7ov9j0R3SJkQQjKf4KMot6bg9oKR37jB5KiJZsWW0VRi3Ug/4Fgs/a rk96Lm8fEJwYlpQrLFGGq1gyeWlDVihYYg+3RotlcRgk/wGaCQTueuQWYha4zRs00CTS 5l2s9AnhH3plkQGztatYwDrq5P39sV8oRZA8LBY2W8w4al4+dCfVE16QF9BDrgifMyns fVTQ== X-Gm-Message-State: AO0yUKWNmvD9kI81KphkvpuJQYqcxffcg0gXuZJ1Uxx+oTpYBReZBE76 jajgQ+5yA2bAa+VByY3J80qw71JysfCMwPaBYGo= X-Google-Smtp-Source: AK7set+gJ8B034FtuVfCTRrg0gxSDe19D3hFBzPZF+fDD1HMVmJBBR93yRgs06JzseIVH3QrfsdE+HOymLNbiXa1dD8= X-Received: by 2002:a4a:a40b:0:b0:525:5f43:215a with SMTP id v11-20020a4aa40b000000b005255f43215amr901749ool.1.1679407651074; Tue, 21 Mar 2023 07:07:31 -0700 (PDT) In-Reply-To: <87h6uep63a.fsf@gmail.com> Received-SPF: pass client-ip=2607:f8b0:4864:20::c2c; envelope-from=joaotavora@gmail.com; helo=mail-oo1-xc2c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:304654 Archived-At: On Tue, Mar 21, 2023 at 1:49=E2=80=AFPM Robert Pluim wro= te: > > >>>>> On Tue, 21 Mar 2023 14:08:39 +0100, Robert Pluim = said: > > >>>>> On Tue, 21 Mar 2023 08:48:04 +0100, Robert Pluim = said: > >>>>> On Mon, 20 Mar 2023 17:34:22 +0000, Jo=C3=A3o T=C3=A1vora said: > > Jo=C3=A3o> _If_ I understand correctly, Robert, your run of > Jo=C3=A3o> eglot-test-diagnostic-tags-unnecessary-code is failing > Jo=C3=A3o> because of a face mismatch, presumably because only > Jo=C3=A3o> clangd-11 is installed in your system, but if you install > Jo=C3=A3o> a more recent clangd it goes away? If so, yes, I think a > Jo=C3=A3o> version check is appropriate, yes. > > Robert> Yes. Version 11 fails, version 17 works, I don=CA=BCt know wh= ere the cutoff > Robert> point is. Which version do you use? > > Robert> So version 11 fails, version 13 fails, version 14 works, so I= guess >=3D > Robert> 14 should do the trick. > > Jo=C3=A3o, would this be ok for you for master? (this test is currently > failing on EMBA =F0=9F=98=80) > > diff --git a/test/lisp/progmodes/eglot-tests.el b/test/lisp/progmodes/egl= ot-tests.el > index 7ac26732737..dfe969cf9f6 100644 > --- a/test/lisp/progmodes/eglot-tests.el > +++ b/test/lisp/progmodes/eglot-tests.el > @@ -452,6 +452,14 @@ eglot-test-basic-diagnostics > (ert-deftest eglot-test-diagnostic-tags-unnecessary-code () > "Test rendering of diagnostics tagged \"unnecessary\"." > (skip-unless (executable-find "clangd")) > + (skip-unless (>=3D > + (string-to-number > + (string-trim > + (replace-regexp-in-string > + "\\`.*version \\([0-9]+\\).*" > + "\\1" > + (shell-command-to-string "clangd --version")))) > + 14)) > (eglot--with-fixture > `(("diag-project" . > (("main.cpp" . "int main(){float a =3D 42.2; return 0;}")))) Looks very verbose: why can't we use 'version<=3D'? And I think I'd rather make some eglot--clangd-version helper. Another option is to skip this on EMBA completely. I presume there's an 'EMBA' environment variable there. Don't use 'CI', though, as GitHub actions also sets it and the test passes fine in that CI server. Another option is to install a newer clangd on EMBA, as 11 is really quite old when compared to the newer versions. Michael, you installed clangd on EMBA. What are the options to upgrade an external program there? Jo=C3=A3o