From: "João Távora" <joaotavora@gmail.com>
To: Stefan Kangas <stefankangas@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: emacs-29 9c0d7bb73b 2/2: Add automated tests for Eglot
Date: Mon, 12 Dec 2022 11:56:47 +0000 [thread overview]
Message-ID: <CALDnm50VKS6=57r_6Z3TGPh6WkMH6d_3zY75FZcXNFZO=+jChw@mail.gmail.com> (raw)
In-Reply-To: <CADwFkmmqBig8ZKs2_+02HUyLn27=KGZkAJ6AdyOdRAj_gy64=Q@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 716 bytes --]
Hi Stefan,
I think the extra predicates you suggest are fine,
feel free to push the changes. I haven't actually
pushed the (skip-unless ... "cargo") commit because
of the ongoing repo issues. If you can push, I invite
you to push that, too.
Maybe also adjust the autopep8 test expectation
to match your result. Or maybe write the reformat
test using something stabler, like "clangd" if you have it.
As for the :expensive, what do you think makes a test
expensive. The longest-running tests in my machine
take less than 3 seconds. But I'm not running the
jtdls one (and I seem to remember that takes a bit
more time). So here, too, fell free to add :expensive
tags to those tests.
João
[-- Attachment #2: Type: text/html, Size: 985 bytes --]
next prev parent reply other threads:[~2022-12-12 11:56 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <167080394233.4339.5863353994038854528@vcs2.savannah.gnu.org>
[not found] ` <20221212001223.E9A9DC004BE@vcs2.savannah.gnu.org>
2022-12-12 8:34 ` emacs-29 9c0d7bb73b 2/2: Add automated tests for Eglot Stefan Kangas
2022-12-12 9:52 ` João Távora
2022-12-12 11:26 ` Stefan Kangas
2022-12-12 11:56 ` João Távora [this message]
2022-12-12 21:52 ` Stefan Kangas
2022-12-13 8:49 ` Michael Albinus
2022-12-13 19:23 ` Stefan Kangas
2022-12-14 9:55 ` Michael Albinus
2022-12-12 10:32 ` Michael Albinus
2022-12-12 10:37 ` João Távora
2022-12-13 19:10 ` Michael Albinus
2022-12-13 20:18 ` João Távora
2022-12-14 9:57 ` Michael Albinus
2022-12-14 12:58 ` João Távora
2022-12-14 14:11 ` Michael Albinus
2022-12-14 15:46 ` João Távora
2022-12-14 17:41 ` Stefan Monnier
2022-12-14 21:42 ` Stefan Kangas
2022-12-15 9:12 ` Michael Albinus
2022-12-15 12:08 ` João Távora
2022-12-12 10:59 ` Michael Albinus
2022-12-12 11:03 ` João Távora
2022-12-12 11:08 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALDnm50VKS6=57r_6Z3TGPh6WkMH6d_3zY75FZcXNFZO=+jChw@mail.gmail.com' \
--to=joaotavora@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).