From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: Explain a bit more on how to configure language server in Eglot's manual Date: Wed, 8 Mar 2023 13:54:55 +0000 Message-ID: References: <86sfeisu49.fsf@stephe-leake.org> <87356gvkkb.fsf@gmail.com> <87r0tz8jag.fsf_-_@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4421"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Yuan Fu , Stephen Leake , Emacs developers To: Augusto Stoffel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Mar 08 14:55:47 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pZuGh-0000yG-BQ for ged-emacs-devel@m.gmane-mx.org; Wed, 08 Mar 2023 14:55:47 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pZuG8-0008Ov-45; Wed, 08 Mar 2023 08:55:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZuG6-0008Om-EX for emacs-devel@gnu.org; Wed, 08 Mar 2023 08:55:10 -0500 Original-Received: from mail-oa1-x2e.google.com ([2001:4860:4864:20::2e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pZuG4-0003hi-8Z for emacs-devel@gnu.org; Wed, 08 Mar 2023 08:55:10 -0500 Original-Received: by mail-oa1-x2e.google.com with SMTP id 586e51a60fabf-176d1a112bfso9914579fac.5 for ; Wed, 08 Mar 2023 05:55:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678283706; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=JQgC1p3sO8D9ot5K8NOxdUAi/j8jdOQbhSz1YZxfz1s=; b=cy0UFiNhSw7vLxQ1UcnjTCv+b2/wB60kNdKWiRm6Bd2cFe1QNxD0xuYBzHmqtt27v4 AgHaemJYfIgvShNpioLuYtPOHfXqzVsZ7FiE+Y5n6qWMny9H2KC02q+K2odhWqA6syJ5 n2dbee0bXrxi7HXvdzy9g4zZun3mU0Kp6+s88oaHD6KW2/8IBGa3CQpHrrcZuVjUpFUB YgPDOQxuNnv0s2PvX9cwgJiVwQitIih1O7rVSKitvkJbPE7e8/ZRR8aBOhOBMwhKw9ud koTpvcDh33dwCyFz4uzx/JLgBmceoJUJqWARLHLJhzJcM8ZVxRtLpFPO77npl7WARDNS 6HQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678283706; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JQgC1p3sO8D9ot5K8NOxdUAi/j8jdOQbhSz1YZxfz1s=; b=4fMBwfQfkYCFhGwMH5HfnHiUcToU5I0q52nQtGyRXgXT7UQlFVEnbg8savqHCisnMi X4QXTMl7UVyGXlMnyfybiEULdO9KzFZZXcM5zuQfdGIO6HaBVzxfKV7EhSfvreY28Ssy 8UknseZtftpBtemrNKGZ6aewJdEHWxJoJMo7i8QHm8CgztxkZLrAFwX+TkAvFe4mjudy 1ZDV2zI7nzeBw3EW42eEodVu0yoQ6/SztIngWKHANCyzzXVwEbQcN4VqgtBjXEcjys4p k0tlDyd93Oq+dQEJPm/NeGSaq5HRxl0R9DFsrHrOIo9fRgM3qGIaDjuDy007LPdtztUo ldIw== X-Gm-Message-State: AO0yUKWVpchkShfEWiUs81lmttAP/eh6IEEWJHoNhJ+yKffAOyasKt3G HS6BhRZOyZw6nM0JURA9Wy4QzkBIM/vP8UiHKdU= X-Google-Smtp-Source: AK7set/NCEHdax5d1PXJO8dHGiBNZmS3J59I7PDTYrNleqJY0Np7znY9m/85gk1XtXaP30L9sVuYmH/CpAf7WEhU6J0= X-Received: by 2002:a05:6870:954b:b0:176:207d:59c with SMTP id v11-20020a056870954b00b00176207d059cmr6364516oal.5.1678283706419; Wed, 08 Mar 2023 05:55:06 -0800 (PST) In-Reply-To: <87r0tz8jag.fsf_-_@gmail.com> Received-SPF: pass client-ip=2001:4860:4864:20::2e; envelope-from=joaotavora@gmail.com; helo=mail-oa1-x2e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:304130 Archived-At: On Wed, Mar 8, 2023 at 1:27=E2=80=AFPM Augusto Stoffel wrote: > So if the difficulty of gathering these data is overcome, Eglot could do > something actually helpful and show a listing with the types and > documentation of the options (whatever the specifics look like). If and when the LSP protocol stops specifying options as an "LSPAny" object and builds some protocol on top of it to communicate schema Eglot will evaluate if there's some tangible benefit of getting that from the server. Until then, anything you do with this information is language-server specific. It should go into a major-mode or a different extension... > > The dotted-to-plist translator proposed is optional. Some people > > requested use of dotted notation and that will surely need a > > translator. I wouldn't use it. > > Given how selective you are with the features you want to add, I don't > understand why you think this particular one should make it in. It > would sure help a little, maybe, sometimes. I don't understand: didn't you state you _like_ dotted notation? Well, this translator is needed for it, because the e-w-configuration variable is a plist. I reject features which I consider bloat, i.e. they have no bearing to LSP in particular or they solve too specific a problem that should really be solved somewhere else (normally this isn't done simply because that takes more effort and discussion). A special plist editing mode for a single Eglot variable falls into that category, IMNSHO. Dotted option notation does not. It seems to be an LSP practice, and I don't see any other good place to put a single utility function that facilitates it but in Eglot. If it helps people "a little" and has close to 0 maintenance cost, then I don't see why it shouldn't be included. And yes, there are already examples of bloat in eglot.el. But two wrongs don't make a right. There was some bloat that I've already extracted and put in its rightful place, like the "external" completion style. And there was jsonrpc.el in the beginning. Another example is Eglot's "glob compiler" needed for LSP but probably more generally useful and which also belongs elsewhere. Currently I'm also looking to move the markdown rendering to eldoc.el: Eglot shouldn't be doing that. If you're looking to contribute, I'm much more open to patches that reduce_ Eglot's bloat than ones which potentially increase it. Jo=C3=A3o