From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: Why are so many great packages not trying to get included in GNU Emacs? Date: Thu, 7 May 2020 18:42:01 +0100 Message-ID: References: <9mmFgzvrBwjt_n_VJyaJdXINraNi5HsGpwq-0MLeKiJA7kG2BQA4uywrzjyz7lpRS0OZDpjEi8lspOKYUA7P_QsODsDew_8nbH960G55fmY=@protonmail.com> <97DA7804-F647-4A1D-B8E0-AFFE7A324C64@gmail.com> <15bc138f-1c12-d8d2-7174-12a243030634@yandex.ru> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000099ecda05a51266a2" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="129878"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Yuan Fu , Emacs developers , ndame To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu May 07 19:49:29 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jWkeG-000Xfg-Lq for ged-emacs-devel@m.gmane-mx.org; Thu, 07 May 2020 19:49:28 +0200 Original-Received: from localhost ([::1]:38184 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jWkeF-00019J-MA for ged-emacs-devel@m.gmane-mx.org; Thu, 07 May 2020 13:49:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59182) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jWkXj-0000Fh-S9 for emacs-devel@gnu.org; Thu, 07 May 2020 13:42:43 -0400 Original-Received: from mail-io1-xd44.google.com ([2607:f8b0:4864:20::d44]:33699) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jWkXi-0002r5-K7 for emacs-devel@gnu.org; Thu, 07 May 2020 13:42:43 -0400 Original-Received: by mail-io1-xd44.google.com with SMTP id k18so2787015ion.0 for ; Thu, 07 May 2020 10:42:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=S4QCe61BxiIf/qpqKR2zcDxpNKFKxGdtC0G9lG0yln8=; b=Ad27xQZwEtir4vJmI9QACYT8VRMo7Fg7fTzKWXKbOzuSi8EI0iltMRovH0pwVD67Wh ieQLjrgNdVrkVzNDYF1E3CZ/HQfrpLopU92/n2mK+1vOStnKUcJNfemG2T7o3HKGa2AT HDceYAa7tVS+ygt0ZatJuuKy+JirTgz9Uc/PbaybhQ4cUQqzVxALVHvltrIkD76btpxv /bnh7wtKV58Y/yH3C2xkRNhcmScUs17IWltH/7oKYyaEjLQopsBVbY6XvOSo6q2NUevC QX0lDlcwnrldsNJgA6w9hpzj9nTE85v7KIdkP/c1hLE4sB4rpKH3yYWmYYKZrIuniOS1 FlCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=S4QCe61BxiIf/qpqKR2zcDxpNKFKxGdtC0G9lG0yln8=; b=L0WczNM/cx+SMG3TZtkpZF6rhxNB2rwkGHhOhWPn2OyeHK23aZStLOgKacQdInSp3L ooL1iXUmIZ+SmXGeJdMxRIWtbRQfJwXaqfg7NPD/Hf3Uy0EgRmvldlamZdDSDF1y52zo kHUWULcl7pv0Xg/dRPB0OrRfje+9JdIJSTQTWkjpuzjwxP6OXesMquVE4oemV32wd7vH vpaYydB/LzM0EdbKwvm2am19T4b7XvOBqvhzbiIlCENiUyqgKapjI+sQ0iKMkdEdXZGK r48we87mvPQwXiDkdjNFz7zi95ItSwcosyB1IDcofVASnNx0W0ALPCTMpYXHzyVPiNA9 NwtA== X-Gm-Message-State: AGi0PuaEHPyHO2Q83UPO55sIwwRAoTUGz5usHh7yjRo8LbK7UrnFIYqh qPUJ3Y7UIgm+XTNkS34OjsdrZ5sngfa+ew41eZs= X-Google-Smtp-Source: APiQypIURSHTfZ1nP2jOzGD2DYU/NKT8VUIZhmUiVU0XpLjZcCVP9eXGqq2FDRUfb+BLQt10mAl73bMOpaUFBP6tHbY= X-Received: by 2002:a6b:6a13:: with SMTP id x19mr14906073iog.175.1588873332910; Thu, 07 May 2020 10:42:12 -0700 (PDT) In-Reply-To: <15bc138f-1c12-d8d2-7174-12a243030634@yandex.ru> Received-SPF: pass client-ip=2607:f8b0:4864:20::d44; envelope-from=joaotavora@gmail.com; helo=mail-io1-xd44.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, FROM_EXCESS_BASE64=0.979, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:249192 Archived-At: --00000000000099ecda05a51266a2 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Apr 23, 2020 at 8:03 PM Dmitry Gutov wrote: > On 23.04.2020 21:50, Yuan Fu wrote: > > but if it=E2=80=99s in ELPA, you need to take care of commit message fo= rmats, > submit a patch and wait for someone to review & commit the patch > > This part is not really true. > > You don't really need to worry about commit message format in ELPA, nor > wait for code review (if you're the author of the package). > However, in projects like Eglot, I do review stuff and do ask people to follow the GNU Commit message format. Not always, I will do it for "newbie" committers often, not to burden them with the red tape, then add a "Co-authored-by:" cookie to the commit message. (In fact I just did that for another GNU Elpa package also hosted on Github, darkroom.el) If someone is serious about contributing, I ask them to learn the format and I don't see any resistance. Anyway, just as a data point, I don't think Eglot has shortage of committers because of the copyright issue (everyone I've asked has eventually assigned to Emacs), the commit message format, or the review process. I've turned down a few contributions before, because I didn't like them technically, but they eventually mutate into valid alternatives that do make it in. Jo=C3=A3o --00000000000099ecda05a51266a2 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Thu, Apr 23, 2020 at 8:03 PM Dmitry Gutov <dgutov@yandex.ru> wrote:
On 23.04= .2020 21:50, Yuan Fu wrote:
> but if it=E2=80=99s in ELPA, you need to take care of commit message f= ormats, submit a patch and wait for someone to review & commit the patc= h

This part is not really true.

You don't really need to worry about commit message format in ELPA, nor=
wait for code review (if you're the author of the package).

However, in projects like Eglot, I do review stuff= and do ask people
to follow the GNU Commit message format.=C2=A0= Not always, I will
do it for "newbie" committers = often, not to burden them with the
red tape, then add a "Co-= authored-by:" cookie to the commit
message.=C2=A0 (In f= act I just did that for another GNU Elpa package
also hosted= on Github, darkroom.el) If someone is serious about
contributing= , I ask them to learn the format and I don't see
any resistan= ce.

Anyway, just as a data point, I don't = think Eglot has shortage of
committers because of the copyright i= ssue (everyone I've asked
has eventually assigned to Emacs), = the commit message
format, or the review process. I've turned= down a few contributions
before, because I didn't like them= technically, but they eventually
mutate into valid alternatives= that do make it in.

Jo=C3=A3o
--00000000000099ecda05a51266a2--