Re: master d9b5f618baa 2/4: Eglot: introduce eglot-events-buffer-config

["João Távora" <joaotavora@gmail.com>]

On Wed, Dec 27, 2023 at 4:47 PM Eli Zaretskii <eliz@gnu.org> wrote:
>
> > +(defcustom eglot-events-buffer-config
> > +  (list :size (or (bound-and-true-p eglot-events-buffer-size) 2000000)
> > +        :format 'full)
> > +  "Configure the Eglot events buffer.
> > +
> > +Value is a plist accepting the keys `:size', which controls the
> > +size in characters of the buffer (0 disables, nil means
> > +infinite), and `:format', which controls the shape of each log
> > +entry (`full' includes the original JSON, `lisp' uses
> > +pretty-printed Lisp).
> > +
> > +For changes on this variable to take effect, you need to restart
> > +the LSP connection.  That can be done by `eglot-reconnect'."
>
> Since changing this defcustom needs some code to be run in order to
> make the changes effective, I wonder whether this defcustom could use
> :set to run that code automatically?

Read above in the same diff:

 @c FIXME: Shouldn't the defcustom do this by itself using the :set
-@c attribute?
+@c attribute?  Maybe not because reconnecting is a complex task.
 @xref{Troubleshooting Eglot}, for when this could be useful.

IOW Reconnecting to a server may trash useful caches, fail due
to numerous reasons, etc...  We don't want to initiate it just
because a user changed a preference.  We could ask for confirmation
though, patches welcome.

João