From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: BIKESHED: completion faces Date: Thu, 7 Nov 2019 18:37:53 +0000 Message-ID: References: <83h83ignrz.fsf@gnu.org> <83ftj2gma8.fsf@gnu.org> <87zhhaxalt.fsf@gmail.com> <83bltpgffr.fsf@gnu.org> <83tv7gg9oz.fsf@gnu.org> <83r22kg8pa.fsf@gnu.org> <20191106205133.njij3ve7qqy7yh3q@Ergus> <83ftizg4nr.fsf@gnu.org> <8336ezg2vm.fsf@gnu.org> <83wocbelu1.fsf@gnu.org> <83imnvegcp.fsf@gnu.org> <83ftizeelw.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="263363"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Ergus , Dmitry Gutov , Stefan Monnier , emacs-devel To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Nov 07 19:38:16 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iSmfg-0016Pt-Gx for ged-emacs-devel@m.gmane.org; Thu, 07 Nov 2019 19:38:16 +0100 Original-Received: from localhost ([::1]:47178 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iSmff-0003bY-D9 for ged-emacs-devel@m.gmane.org; Thu, 07 Nov 2019 13:38:15 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36493) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iSmfY-0003bO-Vb for emacs-devel@gnu.org; Thu, 07 Nov 2019 13:38:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iSmfX-0004vZ-Ud for emacs-devel@gnu.org; Thu, 07 Nov 2019 13:38:08 -0500 Original-Received: from mail-io1-xd35.google.com ([2607:f8b0:4864:20::d35]:40280) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iSmfW-0004up-7v; Thu, 07 Nov 2019 13:38:06 -0500 Original-Received: by mail-io1-xd35.google.com with SMTP id p6so3411597iod.7; Thu, 07 Nov 2019 10:38:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=3a0B5VqnhKVmqVeS7OHRnlkc8bLq/K5RqpvpfmDO898=; b=GMEapV8h3FycyKJxgV80vJj1WxHUWIfHUSVe0zpuS+FYxMYdN+mtAkIP0+45HVY/bN tZE6iAk31pjPj2XeZQc/46yzmSQY7FBclwNyezL79QSmHrss4gnTw1KBBPRethX8dqNN 8DLMABysc9CcPc0w77fr+23Qrau4rO5FqNugAYeGAOe8hglHS92++OYT7hn27d6z8Hi3 w00SAB5OUJ513AS+1qVf6TLJKbyLmBAl1aTUciJW8BFgKAy5gTHB3XOA8lhzIsp6XF2G euiZiAebHLByYiBvKTRjPzqpdf1EAfGZSNIlVM36rxe8ABn8uHQicBVPXbWHzsTve4Ku KZNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=3a0B5VqnhKVmqVeS7OHRnlkc8bLq/K5RqpvpfmDO898=; b=D0okvUx6KGkEk4y55wPzGETs5pWY8Mxq1NpWvJxmCMfY5S30iQN4Be/nRZKAEpa9td N3Hl/XxRsLNx+jTgHPy9RoqrEn19KCAlqvIm32Nl4J1nTkd/f6/TYLz0nC4qD9VzZUvK l+kMhafwwp7DE5q86jsXY3sa1+zP+rDDiCDrIs0yhUFKZZfW+KLDTlnqgnKYunKDwE/w 5b38mzWX9zXZ7I9okz74A3/+V7wbqlOtgEOOargYmPObhxo/ysLD/o0rTLT6CODG3MKP sdsP5fDwPuHwoLLXTKQXNLOUoPnsQeJJYg3h6iYGQqiMxGNL+0d4EDlcXGZH3PghzN4O wiGQ== X-Gm-Message-State: APjAAAWMfusovktRLzqotH9MR/LqahEE5kWakBXF7O3MLDP72vsiBkkI d6mU9OfxKAXeFN8W+WQHBs35JGKdWlL7I6tB2I8TFA== X-Google-Smtp-Source: APXvYqyFoIJai8ipCkXWkUYK81rLy0IGdLgLUpyTZUiwbN9JaP0pFVz6Iazc5CJFvoTelt3dSScOgPSaFXUnFqWeN/Y= X-Received: by 2002:a6b:6f05:: with SMTP id k5mr4905346ioc.125.1573151884858; Thu, 07 Nov 2019 10:38:04 -0800 (PST) In-Reply-To: <83ftizeelw.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::d35 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:241950 Archived-At: On Thu, Nov 7, 2019 at 6:16 PM Eli Zaretskii wrote: > > > From: Jo=C3=A3o T=C3=A1vora > > Date: Thu, 7 Nov 2019 17:53:02 +0000 > > Cc: Ergus , emacs-devel , > > Stefan Monnier , Dmitry Gutov > > > > > > "first-difference" to "completion-emphasis" and > > > > "common-part" to "secondary-emphasis" > > > > > > I think secondary-emphasis is not a good name, it says nothing about > > > its use. We should find a better name. > > > > "alternate-emphasis"? > > Same problem. How about "match-emphasis"? First, I hope we don't confuse ourselves, there is a prefix implicit here right? It's "completions" (or actually it should be "completion" singular). Apologies if I've been sloppy in using and not using the full name. So I'm proposing "completion-emphasis", which we seem to agree on, for _primary_ emphasis, the thing that the matching style wants to highlight most prominently. Regarding the second (but not necessarily secondary) face, for other things the completion style you are proposing "completion-match-emphasis", right? This is the one aliased to existing "completions-common-part". It works but it is slightly akward of flex _not_ to use it. Because if it uses it, the only reasonable place to put it is in exactly the same places that it is already applying "completion-emphasis". But I don't think there can be two different faces for the same character in a string, can there? Nothing a comment in the code can't fix, but users might be surprised that they customize something with that name and nothing happens in flex. I personally don't see it problematic to choose a name that says less about the use, because we can't predict exactly what the use is: just that it will be used to highlight parts of completions where prominence is less important than the one offered by "completion-emphasis", which defaults to "foreground: bold". So "alternate", "supporting", "secondary" or anything that expresses that would be my choices. Jo=C3=A3o