From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: master 67c3a3a 2/2: Avoid occasional confusion of Flymake C/C++ backend Date: Wed, 27 Mar 2019 17:43:43 +0000 Message-ID: References: <20190325145632.633.72531@vcs0.savannah.gnu.org> <20190325145634.E71A520535@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000004325e7058516fbb4" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="229935"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel To: Robert Pluim Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Mar 27 18:44:38 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h9CbN-000xi3-LK for ged-emacs-devel@m.gmane.org; Wed, 27 Mar 2019 18:44:37 +0100 Original-Received: from localhost ([127.0.0.1]:51436 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h9CbM-0005yz-N1 for ged-emacs-devel@m.gmane.org; Wed, 27 Mar 2019 13:44:36 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:49518) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h9Caj-0005yq-2W for emacs-devel@gnu.org; Wed, 27 Mar 2019 13:43:58 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h9Cah-0005cm-Tj for emacs-devel@gnu.org; Wed, 27 Mar 2019 13:43:56 -0400 Original-Received: from mail-qk1-x72e.google.com ([2607:f8b0:4864:20::72e]:36699) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h9Cah-0005cK-Iy for emacs-devel@gnu.org; Wed, 27 Mar 2019 13:43:55 -0400 Original-Received: by mail-qk1-x72e.google.com with SMTP id k130so10434018qke.3 for ; Wed, 27 Mar 2019 10:43:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hdhGcZvi7AZNN9Zj1arBHs54J5AZ9b+6/9HIC5lxFN4=; b=nTCzY57eKz1Sf0EDyh5VXtKDbVdHLdcI6atBuAqQJDwH9hv3zp1J3rlGIK12x0dQ/u 3aDMfLEY6xMFRGZcN08qX2iD4EeS7GWePYn6mrJQkRQhy7uNnNf0W/RrtAJ7HO+cMYXl hEAzM3Ryey3jSthLpcafdmkewzy9GZboXxmkFT9boh5ckOGIeoeKgGoq0ZGheRfczvdT 4F8gKXSAXglnAeUSbXdNHBIv9DjKpq7F1fEShKoZ7ONqKIWVpHoRsI0rE3Y02c28/roT n9W3zgc0ChrOb4pgNABWejVBtgMKNOEAYLETfL7EYuxerNa2nrHZ7MQynsF9g9hRUXn9 e1Hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hdhGcZvi7AZNN9Zj1arBHs54J5AZ9b+6/9HIC5lxFN4=; b=T/0fngyB9kDrC1r96fTNbj2UOqCb2Tz3EzuQ9LwzlW4WjU5aPuC7/q/lytaolgV23f UStFrE/ziXCqflj5NY2bYuC4fcD9anG4TYlyAAEk6vwKguiWtcktqMZ2ZL0otNLvqLXi K7Hb5GtUQ/Hjm5+Jd8MlzGWpssZp2OW2+lS9qU9P14PuQzew6nv3ROX7FbTHO7yMlXeK GHXAVFNTjran+mOxgPDLAvGcflXiygFQmXrnuHI8kGMWM5a8z8jQefXWESqf0cu8M439 9JYFHrDxB3zq25oewvBTqsNPdWUiqxp+KRd1em3suBHwSRWN3OB3AgwR05k73Lqkwuq/ tSnQ== X-Gm-Message-State: APjAAAUlh5UnvNAS02eEOceLTkDKiNHTrMYmY2SxH3AGVlWWeV8xlczU hllp8GeQGzAg9QGo1TgaNcug5jcIBwG9QOexBmw= X-Google-Smtp-Source: APXvYqz2rnuOb/CGBa6ukejuYsvEJtDS6aNGjGDtHKUihdNHDhcTtnJN3hAHnuAXSlO1lW878NWxeCfxGjyFNL2a9eA= X-Received: by 2002:a37:a4d6:: with SMTP id n205mr23534112qke.234.1553708634808; Wed, 27 Mar 2019 10:43:54 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::72e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:234782 Archived-At: --0000000000004325e7058516fbb4 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable What is the GCC version that you are using? Jo=C3=A3o On Tue, Mar 26, 2019 at 2:01 PM Robert Pluim wrote: > >>>>> On Mon, 25 Mar 2019 10:56:34 -0400 (EDT), Unknown > said: > > Jo=C3=A3o> branch: master commit > Jo=C3=A3o> 67c3a3af1d9e2582193d5ea33b6c190e79ad56e6 Author: Jo=C3=A3o= T=C3=A1vora > Jo=C3=A3o> Commit: Jo=C3=A3o T=C3=A1vora > Jo=C3=A3o> > > Jo=C3=A3o> Avoid occasional confusion of Flymake C/C++ backend > > Jo=C3=A3o> The regexp would sometimes match non-errors and create= a > Jo=C3=A3o> diagnostic with nil severity, which would have consequence= s > Jo=C3=A3o> for the Flymake engine (these should eventually be > Jo=C3=A3o> addressed, too). > > This is making flymake-tests fail: > > Test different-diagnostic-types condition: > (ert-test-failed > ((should > (eq 'flymake-error > (face-at-point))) > :form > (eq flymake-error flymake-note) > :value nil)) > FAILED 1/9 different-diagnostic-types (1.093461 sec) > > (face-at-point) is flymake-note there. > > Robert > --=20 Jo=C3=A3o T=C3=A1vora --0000000000004325e7058516fbb4 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
What is the GCC version that you are using?

Jo=C3=A3o

On Tue, Mar 26, 2019 at 2:01 PM Robert P= luim <rpluim@gmail= .com> wrote:
>>>>> On Mon, 25 Mar 2019 10:56:34 -0400 (EDT), Unknown = <unknown@unknown.invalid> said:

=C2=A0 =C2=A0 Jo=C3=A3o> branch: master commit
=C2=A0 =C2=A0 Jo=C3=A3o> 67c3a3af1d9e2582193d5ea33b6c190e79ad56e6 Author= : Jo=C3=A3o T=C3=A1vora
=C2=A0 =C2=A0 Jo=C3=A3o> <joaotavora@gmail.com> Commit: Jo=C3=A3o T=C3=A1vora =C2=A0 =C2=A0 Jo=C3=A3o> <joaotavora@gmail.com>

=C2=A0 =C2=A0 Jo=C3=A3o>=C2=A0 =C2=A0 =C2=A0Avoid occasional confusion o= f Flymake C/C++ backend

=C2=A0 =C2=A0 Jo=C3=A3o>=C2=A0 =C2=A0 =C2=A0The regexp would sometimes m= atch non-errors and create a
=C2=A0 =C2=A0 Jo=C3=A3o> diagnostic with nil severity, which would have = consequences
=C2=A0 =C2=A0 Jo=C3=A3o> for the Flymake engine (these should eventually= be
=C2=A0 =C2=A0 Jo=C3=A3o> addressed, too).

This is making flymake-tests fail:

=C2=A0 =C2=A0 Test different-diagnostic-types condition:
=C2=A0 =C2=A0 =C2=A0 =C2=A0 (ert-test-failed
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0((should
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(eq 'flymake-error
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (face-at-point))) =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 :form
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (eq flymake-error flymake-note)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 :value nil))
=C2=A0 =C2=A0 =C2=A0 =C2=A0FAILED=C2=A0 1/9=C2=A0 different-diagnostic-type= s (1.093461 sec)

(face-at-point) is flymake-note there.

Robert


--
Jo=C3=A3o T=C3=A1vora
--0000000000004325e7058516fbb4--