From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: cus-test fails from completion-category-overrides eglot adds Date: Tue, 25 Oct 2022 22:19:44 +0100 Message-ID: References: <3760C30F-C55E-4CB6-BA3B-E30D9BEC93BE@gmail.com> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000001b6ca05ebe27484" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9312"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel To: =?UTF-8?Q?Mattias_Engdeg=C3=A5rd?= , Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Oct 25 23:25:13 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1onRQ9-0002Cy-O6 for ged-emacs-devel@m.gmane-mx.org; Tue, 25 Oct 2022 23:25:13 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1onRJy-0000Br-0o; Tue, 25 Oct 2022 17:18:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1onRJw-0008W5-4c for emacs-devel@gnu.org; Tue, 25 Oct 2022 17:18:48 -0400 Original-Received: from mail-oa1-x2b.google.com ([2001:4860:4864:20::2b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1onRJu-0006Iw-Ee for emacs-devel@gnu.org; Tue, 25 Oct 2022 17:18:47 -0400 Original-Received: by mail-oa1-x2b.google.com with SMTP id 586e51a60fabf-13be3ef361dso5006625fac.12 for ; Tue, 25 Oct 2022 14:18:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=0fpyEboA6d2kRaPs3+3LmRo+zHUQc6NUuQeam6XNRb8=; b=e+QBrsXWVNHJ/HGRYkpGb0ZiQwK56NcvcxcIaikrpLiosYThnSnBlgU9Gn4BvPWBIt T6xMkYWVhJ90VAHKRfrMxftPW4EXskqgyBdwBICDCoMVuJixYNP/yub91IbONRHTs3eX 9nNdeo0K7ypjeM072wOIzkJAV5Qw49tUWBULauC2qB1LrhrBOIbdfb2OVt4PFBw+Dv5a VSqC19q00ae6Z+gmD5kcWyBuiZyaPbRSO1zgmXuVgKHa3DbDdpZVQ2ISKWHLccIiAcfb Uols5d12oJBwMurRhDJsmQkUXk7AuOyN5JXgfVu/sydfM61RDNOqBi/sx4Dx0uLM98Mu misA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0fpyEboA6d2kRaPs3+3LmRo+zHUQc6NUuQeam6XNRb8=; b=VbdsyvaS6UFcSRtlL3R14TrRwrQDylvjrD7tot6PcndAkGaWE56OWMfbS4WeD70oj5 CKLiCXcZ2kmPrwRit2Fxzqip4UjdRBz/nMlGXNYueuqI5QUdoNTXnFNB3ha4iuXGRt3s TF/nggMkotB3/s9VvqtLUCyogz0TxDTOVnsY7boPF/G1sC1kkawxrfcNJL1kta9z/LUw 329/CT6sz2r/QVvEF+zSSHjCOt9UkzoCcoEwIrOSz45PKZlimYtqb1tY/IZD+vKryoSg WPXlSnM9xf7oIYBLktOY7gZym5uD0pzN848fbfctAoXZ1qKX70ZojwAXgZHBBG8BlgHZ b3pw== X-Gm-Message-State: ACrzQf2T8WOunaqkgkzsoHo6RJEypa+S6FucY0TQfeNo3zyi2YxLaqNy 01yZBLyxqNUFFA1jbFkyV4iAbCGXessmc2BfqDI= X-Google-Smtp-Source: AMsMyM798WVqOHawt5uHWuz/4+N0gaCUlVttfpYyg2llCXtuTZPZhQzPClTVpDTE4O7S8hXn0lQtAihorP0twCTVCsM= X-Received: by 2002:a05:6870:e242:b0:13b:d561:ad02 with SMTP id d2-20020a056870e24200b0013bd561ad02mr168065oac.215.1666732724957; Tue, 25 Oct 2022 14:18:44 -0700 (PDT) In-Reply-To: <3760C30F-C55E-4CB6-BA3B-E30D9BEC93BE@gmail.com> Received-SPF: pass client-ip=2001:4860:4864:20::2b; envelope-from=joaotavora@gmail.com; helo=mail-oa1-x2b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "Emacs-devel" Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:298500 Archived-At: --00000000000001b6ca05ebe27484 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Oct 25, 2022 at 8:47 PM Mattias Engdeg=C3=A5rd < mattias.engdegard@gmail.com> wrote: > > The test-custom-opts test currently fails because eglot adds elements to `completion-category-overrides` that doesn't match its declared type. Is this test in the normal test suite executed by `make check`? I ran that after the merge and the only failure I got was the usual tramp-something that I ignore. > While eglot also adds to `completion-styles-alist`, from which the type of `completion-category-overrides` is derived, this happens too late; the defcustom type is already set. I think Stefan in the expert in this area. Eglot contains a bit of code authored by him that enables the "backend" completion style, a kind of "all-styles-controlled-elsewhere" style (needs a better name btw, imo). That code isn't Eglot-specific at all and should be moved to some other library that Eglot can depend on. Anyway, it seems the problem is the activation of said style in a custom-coherent way. This is not always easy or possible, but it might be here. I seem to recall having tried doing the setting in eglot--managed-mode (where most other settings by Eglot happen) and coming to the conclusion that it didn't work. But if it's just a type declaration thing, shouldn't the type declaration be broadened (presuming Eglot isn't adding some nonsense to the var?) Jo=C3=A3o --00000000000001b6ca05ebe27484 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Tue, Oct 25, 2022 at 8:47 PM Mattias Engdeg=C3=A5rd <= ;mattias.engdegard@gmail.com= > wrote:
>
> The test-custom-opts test currently fa= ils because eglot adds elements to `completion-category-overrides` that doe= sn't match its declared type.

Is this test in = the normal test suite executed by `make check`?=C2=A0 I ran that after
the merge and the only failure I got was the usual tramp-something th= at I ignore.

> While eglot also adds to `comple= tion-styles-alist`, from which the type of `completion-category-overrides` = is derived, this happens too late; the defcustom type is already set.
=

I think Stefan in the expert in this area.=C2=A0 Eglot = contains a bit of code authored by
him that enables the &quo= t;backend" completion style, a kind of
"all-styles= -controlled-elsewhere" style (needs a better name btw, imo).

That code isn't Eglot-specific at all and should be mov= ed to some other
library that Eglot can depend on.

=
Anyway, it seems the problem is the activation of said style in = a
custom-coherent way.=C2=A0 This is not always easy or poss= ible, but it might
be here.=C2=A0 I seem to recall having tried d= oing the setting in
eglot--managed-mode (where most other se= ttings by Eglot happen)
and coming to the conclusion that it didn= 't work.

But if it's just a type declarati= on thing, shouldn't the type declaration
be broadened (presum= ing Eglot isn't adding some nonsense to the var?)

J= o=C3=A3o
--00000000000001b6ca05ebe27484--