Re: cus-test fails from completion-category-overrides eglot adds

["João Távora" <joaotavora@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1404 bytes --]

On Tue, Oct 25, 2022 at 8:47 PM Mattias Engdegård <
mattias.engdegard@gmail.com> wrote:
>
> The test-custom-opts test currently fails because eglot adds elements to
`completion-category-overrides` that doesn't match its declared type.

Is this test in the normal test suite executed by `make check`?  I ran that
after
the merge and the only failure I got was the usual tramp-something that I
ignore.

> While eglot also adds to `completion-styles-alist`, from which the type
of `completion-category-overrides` is derived, this happens too late; the
defcustom type is already set.

I think Stefan in the expert in this area.  Eglot contains a bit of code
authored by
him that enables the "backend" completion style, a kind of
"all-styles-controlled-elsewhere" style (needs a better name btw, imo).

That code isn't Eglot-specific at all and should be moved to some other
library that Eglot can depend on.

Anyway, it seems the problem is the activation of said style in a
custom-coherent way.  This is not always easy or possible, but it might
be here.  I seem to recall having tried doing the setting in
eglot--managed-mode (where most other settings by Eglot happen)
and coming to the conclusion that it didn't work.

But if it's just a type declaration thing, shouldn't the type declaration
be broadened (presuming Eglot isn't adding some nonsense to the var?)

João

[-- Attachment #2: Type: text/html, Size: 1792 bytes --]