From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: Why are so many great packages not trying to get included in GNU Emacs? Date: Thu, 7 May 2020 21:28:23 +0100 Message-ID: References: <9mmFgzvrBwjt_n_VJyaJdXINraNi5HsGpwq-0MLeKiJA7kG2BQA4uywrzjyz7lpRS0OZDpjEi8lspOKYUA7P_QsODsDew_8nbH960G55fmY=@protonmail.com> <97DA7804-F647-4A1D-B8E0-AFFE7A324C64@gmail.com> <15bc138f-1c12-d8d2-7174-12a243030634@yandex.ru> <609f9461-8c02-dcf4-773d-562b8d1f717c@gmail.com> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000094a80505a514b94a" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="49130"; mail-complaints-to="usenet@ciao.gmane.io" Cc: ndame , Yuan Fu , Emacs developers , Dmitry Gutov To: =?UTF-8?Q?Cl=C3=A9ment_Pit=2DClaudel?= , ilya.ostapyshyn@gmail.com Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu May 07 22:29:24 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jWn92-000CgE-AP for ged-emacs-devel@m.gmane-mx.org; Thu, 07 May 2020 22:29:24 +0200 Original-Received: from localhost ([::1]:42036 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jWn91-0002Fp-BY for ged-emacs-devel@m.gmane-mx.org; Thu, 07 May 2020 16:29:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44660) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jWn8G-0001BJ-TT for emacs-devel@gnu.org; Thu, 07 May 2020 16:28:36 -0400 Original-Received: from mail-il1-x130.google.com ([2607:f8b0:4864:20::130]:36306) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jWn8G-0002KZ-2M for emacs-devel@gnu.org; Thu, 07 May 2020 16:28:36 -0400 Original-Received: by mail-il1-x130.google.com with SMTP id c16so2506235ilr.3 for ; Thu, 07 May 2020 13:28:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Bc8j3su14X3Yo7m3XABP/T6wF41uNfhg4b2tgWQLzuM=; b=XGMqgfcNEV2Wq4v/lj5/nh36/tt4w76WBAfR3FUTQwciu7h0HRgma6xGCnUoDwSfxe g3WQdhajN2qkNvXFz4D3KCwjcoJACH2V6PPf2x4DRQWhJAd/ZSRoropMRSWO/7horus6 6KerQqa+yLWlxFNGM+AwXe4Uwt13BZIJ7xJkAhqZ5YgPSgGPfQTp29V8ZRpXcplRanky YEvBMvUJUxL4Nkjmcl5BCrEFX2kQrbmfjPN/wgBlPvEqyw9TpfAPtK713DmWi6IlisxU n6QYa1qZUS46yUdOYbcC4WiJWh2hzSp/2HlMn+gbBmMuiz08jc0+7nhxKLv+il+TXn1F 8YSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Bc8j3su14X3Yo7m3XABP/T6wF41uNfhg4b2tgWQLzuM=; b=jp2zCw+5G4skokX5LaR32tJoBgBtqDNllcZ2q69ds82VIObaQF6NKsqGVdfNFQMoIY 2Fx0hSJ4bKP/F246KB1/wuxtxj6XD4SGsYPgNDN0xvGuErpi/WV2gNp4lzqh5t32wMFW Vnxmkr7htwBRQm8tPlU+ksSbCfb4mMZ921/VFliWCBE4ZWtuZiWL0cK/mpYIZnm2uAFv yYqHU47e4UusbZIzFiY/F8oylG4ZzFI3JBXaYF9zezf4ucooTvUdAAPrar7fiD9pjUbl vTIIRNatLhKW2dftneN305Zc7SMqwl3UhNxlglqsIe7IBVGkvnPUOWwGg7/rA7TidN1u 0Ekw== X-Gm-Message-State: AGi0PuaTu3/nEy4wOE0h7vP6N/x9Mlj0fsJ5NV3/u6TRUG1hNwvnMPav SI5NlmmXqQzDjS5EqnC9r5z3FGl5bgjfVaUc3DQ= X-Google-Smtp-Source: APiQypLG5nfRG6Jd/etGYMDPYR47RzYP8hYwmLQueKN1K0+yt4LFj7Ynv9NGa3emEbZDOrQir7nHPxWxaNoXDcY9m50= X-Received: by 2002:a05:6e02:f45:: with SMTP id y5mr16474640ilj.199.1588883315008; Thu, 07 May 2020 13:28:35 -0700 (PDT) In-Reply-To: <609f9461-8c02-dcf4-773d-562b8d1f717c@gmail.com> Received-SPF: pass client-ip=2607:f8b0:4864:20::130; envelope-from=joaotavora@gmail.com; helo=mail-il1-x130.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, FROM_EXCESS_BASE64=0.979, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:249215 Archived-At: --00000000000094a80505a514b94a Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, May 7, 2020 at 8:54 PM Cl=C3=A9ment Pit-Claudel wrote: > On 07/05/2020 13.42, Jo=C3=A3o T=C3=A1vora wrote: > > Not always, I will do it for "newbie" committers often, not to burden > > them with the red tape, then add a "Co-authored-by:" cookie to the > > commit message. > > I got confused by this part: why do you need the cookie? > Because I changed the commit message: here's the commit I was talking about earlier (from git.sv.gnu.org:/srv/git/emacs/elpa.git) commit 4953ee6f7de4ead0fced02e0da823eafaf5797e0 Author: Ilya Ostapyshyn Date: Thu May 7 20:34:14 2020 +0300 Fix #13: correctly calculate search bound for narrowed buffers The search-forward function does not take narrowing into account, so we must do that ourselves. Co-authored-by: Jo=C3=A3o T=C3=A1vora Copyright-paperwork-exempt: yes * darkroom.el (darkroom-guess-margins): Add (point-min) to the 20000 I added all the commit message, but Ilya did the actual patch. Though reading Luke's email, it seems I could have use "Signed-off-by:" or something like that. Jo=C3=A3o --00000000000094a80505a514b94a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Thu, May 7, 2020 at 8:54 PM Cl=C3= =A9ment Pit-Claudel <cpitclaude= l@gmail.com> wrote:
On 07/05/2020 13.42, Jo=C3=A3o T=C3=A1vora wrote:
> Not always, I will do it for "newbie" committers often, not = to burden
> them with the red tape, then add a "Co-authored-by:" cookie = to the
> commit message.

I got confused by this part: why do you need the cookie?

Because I changed the commit message: here's the comm= it I was
talking about earlier (from git.sv.gnu.org:/srv/git= /emacs/elpa.git)

commit 4953ee6f7de4ead0fced02e0da= 823eafaf5797e0
Author: Ilya Ostapyshyn <ilya.ostapyshyn@gmail.com>
Date: =C2=A0 Thu May 7= 20:34:14 2020 +0300

=C2=A0 =C2=A0 Fix #13: correctly calculate sear= ch bound for narrowed buffers
=C2=A0 =C2=A0
=C2=A0 =C2=A0 The search= -forward function does not take narrowing into account, so we must
=C2= =A0 =C2=A0 do that =C2=A0ourselves.
=C2=A0 =C2=A0
=C2=A0 =C2=A0 Co-a= uthored-by: Jo=C3=A3o T=C3=A1vora <joaotavora@gmail.com>
=C2=A0 =C2=A0 Copyright-paperwork-exempt= : yes
=C2=A0 =C2=A0
=C2=A0 =C2=A0 * darkroom.el (darkroom-guess-marg= ins): Add (point-min) to the 20000

I added all the= commit message, but Ilya did the actual patch.

Th= ough reading Luke's email, it seems I could have use
"S= igned-off-by:" or something like that.

Jo=C3=A3o --00000000000094a80505a514b94a--