From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: Accidental change of behaviour for electric-layout-mode? Date: Tue, 24 Sep 2024 13:12:24 +0100 Message-ID: References: <87wmj2dr4q.fsf@ice9.digital> <86v7yle1ma.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29782"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Morgan Willcock , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Sep 24 14:13:34 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1st4QA-0007Yx-C1 for ged-emacs-devel@m.gmane-mx.org; Tue, 24 Sep 2024 14:13:34 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1st4PM-00066N-E3; Tue, 24 Sep 2024 08:12:44 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1st4PH-00065e-T7 for emacs-devel@gnu.org; Tue, 24 Sep 2024 08:12:39 -0400 Original-Received: from mail-oi1-x229.google.com ([2607:f8b0:4864:20::229]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1st4PG-00026H-3K; Tue, 24 Sep 2024 08:12:39 -0400 Original-Received: by mail-oi1-x229.google.com with SMTP id 5614622812f47-3e04552579cso1979906b6e.2; Tue, 24 Sep 2024 05:12:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727179956; x=1727784756; darn=gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=vrUMrvQlRwYTU7HUarf5N7/dGX3KAnU4Qja9SocWUzY=; b=eCsiF5LqKSK7dTaDJiEnNIbW0xUlYMN/9MpEVD4fK2o5wH5nZSorvOy5t5fL4McLt+ S64OQrHOb16zcYd6uQJLTWweuLlfUTNvsosZ49amy3c0Q3TMXbJixmh9KWZ4pJvfj/Bx PhRjlfy3xrRgyNOpvPJKcU1ONMC12fxLRaPPq2/OXnr6hyx7vLPFvucVJMdiB/F2F9R+ xuINLZNZJjAF+ZOrsyetCu0e+n/sGuVKN6n5IgvGLn7slG6ut8wMNYlzhtzY48Iifbjj AhCd6eOxQC5d/3bEp3cjjoFY3UDYFOMDD+rJt22RL56LED3+EX4OBXlflWodguNqK88T I/dA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727179956; x=1727784756; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vrUMrvQlRwYTU7HUarf5N7/dGX3KAnU4Qja9SocWUzY=; b=WGtTKWJ0S/QoUtt/a75SxT7IYFb/izmG6sUw7aozkVvz18g703I0sAVG9WYh6N7S4Q iAjCfEGTEbVn0QP3vHy9/l3P1of7TM2PdJgFBkbe56caRRcHgegmc4CKaT0Pc2mwEIEs yZUy1GI6SgIjHUGsEq5JKiZnxiOdf1IIfvAZmmJAlVT8scm4xSUcgQD+yae/P/eKbisk UJzwrDFY0AKiiD+1n83biTQIlSwtFLTozJgH9f+rUfLT0V/Sxsm6XwjAcIt3wJ9UrX5A RJP4RqDZg5TIsBOvluzLqwx8zlljIvhg39Bde3WRZXrSej1+McPZU1QQx9Ia83XSL0XE 6oiA== X-Forwarded-Encrypted: i=1; AJvYcCVDIK9xujhi802DX8EvmxlOIRehoZOVtJ6fqT8ITLe/xzl659SjacTUCVbxQ9hmC/x79Nacv3lxNoZVAQ==@gnu.org X-Gm-Message-State: AOJu0Yw83J4DHDG2+Hqx/QoARZ2T/Q7cSlHMG0aPUzTmczjcFmhBLokI 3WW/JIYRJSOeDz5DSOuYRGUwcQL4IM2xL2C6y7jQh33/m5NY6PW9t9UXsCiFuRnsNCQ4A5ct50V OseudGWAOsMp+9dpjSa3824xdBDth3A== X-Google-Smtp-Source: AGHT+IHokHgGllc19YVsT2EZdqJCyhVJVjGWgM9Wzu/qej7vShCaxxw+gi9MdEZnGDwJ2xPKpplYYd/v+YR+qssJYFw= X-Received: by 2002:a05:6808:1983:b0:3dd:cc7:957c with SMTP id 5614622812f47-3e271b61bf3mr9340203b6e.8.1727179956173; Tue, 24 Sep 2024 05:12:36 -0700 (PDT) In-Reply-To: <86v7yle1ma.fsf@gnu.org> Received-SPF: pass client-ip=2607:f8b0:4864:20::229; envelope-from=joaotavora@gmail.com; helo=mail-oi1-x229.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:324023 Archived-At: No, it wasn't. I was probably experimenting with something. You can revert it (or make it optional), etc. Jo=C3=A3o On Tue, Sep 24, 2024 at 12:24=E2=80=AFPM Eli Zaretskii wrote= : > > > From: Morgan Willcock > > Date: Mon, 23 Sep 2024 21:58:13 +0100 > > > > It looks like Emacs 30 is now allowing electric-layout-mode to insert > > newlines inside comments and strings, whereas previous versions seem to > > explicitly stop this from happening. > > > > The commit that does it is b1f8d98a119ab8845d25d80c480cde6e385d8749 > > (Eglot: rework eglot-imenu) which doesn't mention electric-layout-mode > > in the commit message or the associated bug report (58431). > > > > I think it may have been done accidentally and is likely not a backward= s > > compatible change. > > > > (I actually wanted the new behaviour and only found this because my > > tests for newline insertion failed on Emacs 27, 28, and 29. Making the > > new behaviour opt-in would be nice, so I could send a patch to do that > > if the previous change does look to have been accidental.) > > Jo=C3=A3o, was that change intentional, and if so, what was its reasons? > > Thanks. --=20 Jo=C3=A3o T=C3=A1vora