From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: scratch/backend-completion 9a62da21c2 1/2: Integrate Stefan suggestions but rename it to "external-completion.el" Date: Wed, 7 Dec 2022 11:09:02 +0000 Message-ID: References: <167007345844.23701.8454474119701440468@vcs2.savannah.gnu.org> <20221203131739.2A601C004BA@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000005c4bc205ef3af325" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32349"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel To: Eli Zaretskii , Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Dec 07 12:10:07 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p2sJT-0008Dx-Pq for ged-emacs-devel@m.gmane-mx.org; Wed, 07 Dec 2022 12:10:07 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p2sIf-0005Gr-Rc; Wed, 07 Dec 2022 06:09:17 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p2sIf-0005Gi-45 for emacs-devel@gnu.org; Wed, 07 Dec 2022 06:09:17 -0500 Original-Received: from mail-oi1-x236.google.com ([2607:f8b0:4864:20::236]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p2sId-00086H-Dw; Wed, 07 Dec 2022 06:09:16 -0500 Original-Received: by mail-oi1-x236.google.com with SMTP id k189so1251267oif.7; Wed, 07 Dec 2022 03:09:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=LB4zV/79i3B1/xC6JvqaOcPiij4zPdCiWhTGIktlrao=; b=LqHkOpIW3S+cTUAtiD1TwdJBHSI/+5zbs3x8HNAKRZuqFuEWN+nHFHSmpH628l9XJ/ HL5njOif5lP43mmjRQPbj462vPSxhBWLreE3EHGtNYFsyvrlDI7PiTZRjaNpRndxegLG ybS5rwNEv84Knv4ioL3zshso86TabsVeBcLwEPptSJmCHvDLLazonGMXV9sIGiAihj+4 cbmP/+mk/wphkx4t2U3WOpQjAx6Yfzv8HQd+rI7dEqPOLhlgMfzB8TFkwlxFfd5aFdjR jstasbgPVIuEcK6Xhlq23FW7bLJwbZvViO2FonhCQQSJzpg4xxExfodJjWvuFKGyZT6K fE1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LB4zV/79i3B1/xC6JvqaOcPiij4zPdCiWhTGIktlrao=; b=kowzQAMdGZL82yAnFHRptuwIBO0gWEz8i+g/Pkrjojx/FM7ISDO9+nufjGiWSxtKr6 aTW5kj+hymyHD/w3uaEpcAn7lRBIxoXfSgmASyBriD4TrbE18SCrYnnzJxl1CjIcVPzT Avpf3vudP9kx0cqtCyX0AaZmpqigEAuLryLdbnMViNG52oSJYmmSJQzQ4KkUCtjzcv4K 8VBIhH7Q75eBE5Kjwqf0n1ghQnp8UQtklGAFWbbfb0dK33NfEPcu84CbGv4la2JY01Db 710m/ShLF4SCe1UT53L0CfihKTX0yxecb/ju9iCCKgE/Cq1iG5nQZev6jjrX5mkILT8R uyrw== X-Gm-Message-State: ANoB5pl33lHhoTVfvy+Kiy3WXyWcmLI7Tc5lsbJQcsE0KQ56bYihizvA pCxKwma40Nd2mekmKiqtmgaOQtYkYosEdVdhWScjcD9k X-Google-Smtp-Source: AA0mqf4+Z7SSP77NaEmw3REWII7r/Dvzkz5aJEarbTiDEjKuieZgJpiDCePC8xGSObyrYZS/U5/Gc4Sjaeyjyrj1OEY= X-Received: by 2002:aca:ac44:0:b0:35c:2ddf:59d5 with SMTP id v65-20020acaac44000000b0035c2ddf59d5mr6842031oie.215.1670411353605; Wed, 07 Dec 2022 03:09:13 -0800 (PST) In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::236; envelope-from=joaotavora@gmail.com; helo=mail-oi1-x236.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:301006 Archived-At: --0000000000005c4bc205ef3af325 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Dec 6, 2022 at 12:14 AM Stefan Monnier wrote: > > > Yup, this rhymes exactly with what I wrote in the docstring in the latest > > version. I understand how it could be used now. > > Looks great to me, thanks, Great! I've now tidied up the branch and pushed it to feature/external-completion Eli, if you haven't been following this discussion closely, this is a refactor of functionality already present in Eglot that consolidates the support for offering completions coming from external tools (like LSP servers, but not only) and makes it available to more third party packages. I think there shouldn't be any adverse effects of pushing this to the emacs-29 branch, but if you think it's better, I'll push it to master instead. It shouldn't make much of a difference since the new external-completion.el file is going to be a GNU ELPA :core package and as such it will be available in Emacs 28 anyway via package-install. Let me know what you think. The commentary of the new file, the docstring of external-completion-table and the commit messages should give details. I'll be happy to fix them further if you have comments. Jo=C3=A3o --0000000000005c4bc205ef3af325 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Tue, Dec 6, 2022 at 12:14 AM Stefan Monnier <monnier@iro.umontreal.ca> wrote= :
>
> > Yup, this rhymes exactly with what I wrote in the do= cstring in the latest
> > version.=C2=A0 I understand how it could= be used now.
>
> Looks great to me, thanks,

Great!=C2= =A0 I've now tidied up the branch and pushed it to feature/external-com= pletion

Eli, if you haven't been following this disc= ussion closely, this is a refactor of=C2=A0
functionality already= present in Eglot that consolidates the support for
offering comp= letions coming from external tools (like LSP servers, but not only)
and makes it available to more third party packages.

I think there shouldn't be any adverse effects of pushing this to= the emacs-29
branch, but if you think it's better, I'll = push it to master instead.

It shouldn't make m= uch of a difference since the new external-completion.el
file is = going to be a GNU ELPA :core package and as such it will be available
=
in Emacs 28 anyway via package-install.

Let m= e know what you think.=C2=A0 The commentary of the new file, the docstring<= /div>
of external-completion-table and the commit messages should give = details.
I'll be happy to fix them further if you have commen= ts.

Jo=C3=A3o
=C2=A0
--0000000000005c4bc205ef3af325--