From: Mark Oteiza <mvoteiza@udel.edu>
To: Eli Zaretskii <eliz@gnu.org>
Cc: John Wiegley <jwiegley@gmail.com>,
Stefan Monnier <monnier@iro.umontreal.ca>,
Emacs-devel <emacs-devel@gnu.org>
Subject: Re: On controlling rectangle-preview
Date: Thu, 21 Jul 2016 10:54:22 -0400 [thread overview]
Message-ID: <CAKyxw13nEJzRDJRGL46i8do0VPsMcVvY4Cp0hA-CASrRMO14Kw@mail.gmail.com> (raw)
In-Reply-To: <CAKyxw12WcYDBdEkOc3qMf6MOeC+npxVpVdzVz=hByNUObxw6tw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1556 bytes --]
On Jul 21, 2016 10:28 AM, "Eli Zaretskii" <eliz@gnu.org> wrote:
>
> > From: John Wiegley <jwiegley@gmail.com>
> > Cc: Stefan Monnier <monnier@iro.umontreal.ca>, emacs-devel@gnu.org,
Eli Zaretskii <eliz@gnu.org>
> > Date: Thu, 21 Jul 2016 00:03:25 -0700
> >
> > > This ends up bring very simple--permission to push to emacs-25?
> >
> > If Eli agrees, it looks safe enough to me for the release.
>
> Sorry, I'm confused by the last message in the discussion of the
> patch. This started by introducing a new defcustom that controls the
> preview, but ended with a patch adding no defcustom and instead
> deleting 3 lines? What did I miss (specifically between
> http://lists.gnu.org/archive/html/emacs-devel/2016-07/msg00845.html,
> which approves the original patch, and
The new defcustom in the original patch would only prevent the preview if
its value was nil and the minibuffer was empty. If we agree on nil by
default instead, and if the new variable is not worth adding, then...
> http://lists.gnu.org/archive/html/emacs-devel/2016-07/msg00911.html,
> which presents a totally different one)?
... this is the patch that achieves that. Of course, I could have
misinterpreted Stefan's comments here
http://lists.gnu.org/archive/html/emacs-devel/2016-07/msg00835.html
Sorry if that is the case.
> And why is it needed in emacs-25? Is there some urgent or
> particularly nasty problem involved that we'd like to fix ASAP?
It affects a feature that will be new in the release, as opposed to
affecting a feature that existed in previous releases.
[-- Attachment #2: Type: text/html, Size: 2331 bytes --]
next prev parent reply other threads:[~2016-07-21 14:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-19 23:32 On controlling rectangle-preview Mark Oteiza
2016-07-20 1:32 ` Stefan Monnier
2016-07-20 2:25 ` Mark Oteiza
2016-07-20 12:37 ` Stefan Monnier
2016-07-20 23:00 ` Mark Oteiza
2016-07-21 7:03 ` John Wiegley
2016-07-21 14:28 ` Eli Zaretskii
[not found] ` <CAKyxw136-9VCuSJMJ4qW4tunhUqvgpTDtjGjXf7vFxh52=9vdQ@mail.gmail.com>
[not found] ` <CAKyxw12WcYDBdEkOc3qMf6MOeC+npxVpVdzVz=hByNUObxw6tw@mail.gmail.com>
2016-07-21 14:54 ` Mark Oteiza [this message]
2016-07-21 15:20 ` Stefan Monnier
2016-07-21 16:06 ` Eli Zaretskii
2016-07-21 20:57 ` Mark Oteiza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKyxw13nEJzRDJRGL46i8do0VPsMcVvY4Cp0hA-CASrRMO14Kw@mail.gmail.com \
--to=mvoteiza@udel.edu \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=jwiegley@gmail.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).