From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Alexander Shukaev Newsgroups: gmane.emacs.devel Subject: Re: Whitespace in `${srcdir}' during `configure' Date: Mon, 10 Nov 2014 19:04:51 +0100 Message-ID: References: <5460673E.8000002@cs.ucla.edu> <83389rnl75.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=047d7b343638c97607050784ff71 X-Trace: ger.gmane.org 1415642718 8134 80.91.229.3 (10 Nov 2014 18:05:18 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 10 Nov 2014 18:05:18 +0000 (UTC) Cc: Eli Zaretskii , eggert@cs.ucla.edu, emacs-devel , Yuri Khan To: Glenn Morris Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 10 19:05:10 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XntKs-0008GS-Lp for ged-emacs-devel@m.gmane.org; Mon, 10 Nov 2014 19:05:06 +0100 Original-Received: from localhost ([::1]:44516 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XntKs-0002LT-1u for ged-emacs-devel@m.gmane.org; Mon, 10 Nov 2014 13:05:06 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59499) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XntKo-0002Jt-0X for emacs-devel@gnu.org; Mon, 10 Nov 2014 13:05:02 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XntKm-0008DB-T2 for emacs-devel@gnu.org; Mon, 10 Nov 2014 13:05:01 -0500 Original-Received: from mail-la0-x22e.google.com ([2a00:1450:4010:c03::22e]:59616) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XntKf-0008Aj-7F; Mon, 10 Nov 2014 13:04:53 -0500 Original-Received: by mail-la0-f46.google.com with SMTP id gm9so8231932lab.33 for ; Mon, 10 Nov 2014 10:04:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=1axwsI5ijZtuni16y/BTVIG2qeidAPLmC5Lqt+k6KBU=; b=XopZPsou5DrOkN1nMB2h/ta936Se+SGY3upyxR7jAUAljlRH5h4gphqtBcL+whWQ2K fylP2OyimBpeVwjEp6xaUHSTyx/Nod3aTYctXMAAtOcMOAmwrPATWzqfu0/duBR7ETVd 0aFcXkIXbiCEwb/50kWlyL2GprDhiHUWnxmkSIwSs34coOOJ2BtUilW1UgKbxTOO9CFl 3kbEE11/xvrBx4y3fR64JDGYx8v5ALSK/Gm3a+HtV3pNBfL/0FwNYqC2OySCAZvVCvD9 DBHjVSlgkTTL0eDOC8G/CjgF8g2bLrAGuyVWPP1DmhXhe5JaY3A1eqcfWEhXebcnNKeX kOEQ== X-Received: by 10.112.150.71 with SMTP id ug7mr5835423lbb.73.1415642692008; Mon, 10 Nov 2014 10:04:52 -0800 (PST) Original-Received: by 10.112.202.106 with HTTP; Mon, 10 Nov 2014 10:04:51 -0800 (PST) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c03::22e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:176701 Archived-At: --047d7b343638c97607050784ff71 Content-Type: text/plain; charset=UTF-8 > > But line 3557, which in Emacs 24.4 is > > . $srcdir/nt/mingw-cfg.site > > comes _after_ the check for an unsafe srcdir, so how is this sequence > possible? > Well, that's what happened to me. (I see that most of your patch is entirely stylistic, changing $var for > ${var}.) > My patch adds double quotes around `${srcdir}' in at least 6 places. I think we should wait till that day arrives in autotools and make, > before worrying about it in Emacs. > Orders are orders. --047d7b343638c97607050784ff71 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
But line 3557, which in Emacs 24.4 is

=C2=A0 . $srcdir/nt/mingw-cfg.site

comes _after_ the check for an unsafe srcdir, so how is this sequence possi= ble?
=C2=A0
Well, that's what happened t= o me.

(I see that most of your patch is entirely stylistic, changing $var for
${var}.)
=C2=A0
My patch adds double quotes = around `${srcdir}' in at least 6 places.

I think we should wait till that day arrives in autotools and make,<= br> before worrying about it in Emacs.

Orders are orders.<= br>
--047d7b343638c97607050784ff71--