From: Alexander Shukaev <haroogan@gmail.com>
To: Glenn Morris <rgm@gnu.org>
Cc: Eli Zaretskii <eliz@gnu.org>,
eggert@cs.ucla.edu, emacs-devel <emacs-devel@gnu.org>,
Yuri Khan <yuri.v.khan@gmail.com>
Subject: Re: Whitespace in `${srcdir}' during `configure'
Date: Mon, 10 Nov 2014 19:04:51 +0100 [thread overview]
Message-ID: <CAKu-7Wy91POgXNe23SnwqyQsU9TwgqoKwb8Him5XKZLdiQO-QQ@mail.gmail.com> (raw)
In-Reply-To: <g8wq73q8ko.fsf@fencepost.gnu.org>
[-- Attachment #1: Type: text/plain, Size: 483 bytes --]
>
> But line 3557, which in Emacs 24.4 is
>
> . $srcdir/nt/mingw-cfg.site
>
> comes _after_ the check for an unsafe srcdir, so how is this sequence
> possible?
>
Well, that's what happened to me.
(I see that most of your patch is entirely stylistic, changing $var for
> ${var}.)
>
My patch adds double quotes around `${srcdir}' in at least 6 places.
I think we should wait till that day arrives in autotools and make,
> before worrying about it in Emacs.
>
Orders are orders.
[-- Attachment #2: Type: text/html, Size: 1235 bytes --]
next prev parent reply other threads:[~2014-11-10 18:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-10 2:28 Whitespace in `${srcdir}' during `configure' Alexander Shukaev
2014-11-10 7:14 ` Glenn Morris
2014-11-10 7:20 ` Paul Eggert
2014-11-10 8:26 ` Glenn Morris
2014-11-10 14:28 ` Yuri Khan
2014-11-10 15:12 ` Eli Zaretskii
2014-11-10 16:03 ` Alexander Shukaev
2014-11-10 16:27 ` Eli Zaretskii
2014-11-10 17:17 ` Glenn Morris
2014-11-10 18:04 ` Alexander Shukaev [this message]
2014-11-10 19:25 ` Glenn Morris
2014-11-10 19:39 ` Glenn Morris
2014-11-17 2:24 ` Glenn Morris
2014-11-10 10:47 ` Eli Zaretskii
2014-11-10 7:17 ` Paul Eggert
2014-11-10 7:24 ` Glenn Morris
2014-11-10 9:04 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKu-7Wy91POgXNe23SnwqyQsU9TwgqoKwb8Him5XKZLdiQO-QQ@mail.gmail.com \
--to=haroogan@gmail.com \
--cc=eggert@cs.ucla.edu \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=rgm@gnu.org \
--cc=yuri.v.khan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).