From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Alexander Shukaev Newsgroups: gmane.emacs.devel Subject: Whitespace in `${srcdir}' during `configure' Date: Mon, 10 Nov 2014 03:28:21 +0100 Message-ID: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=089e0158c1589cdbe9050777ead8 X-Trace: ger.gmane.org 1415586516 3912 80.91.229.3 (10 Nov 2014 02:28:36 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 10 Nov 2014 02:28:36 +0000 (UTC) To: emacs-devel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 10 03:28:32 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XneiV-0005MK-9V for ged-emacs-devel@m.gmane.org; Mon, 10 Nov 2014 03:28:31 +0100 Original-Received: from localhost ([::1]:40655 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XneiU-0004WG-9Y for ged-emacs-devel@m.gmane.org; Sun, 09 Nov 2014 21:28:30 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50504) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XneiP-0004WA-P0 for emacs-devel@gnu.org; Sun, 09 Nov 2014 21:28:26 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XneiO-0005Xr-26 for emacs-devel@gnu.org; Sun, 09 Nov 2014 21:28:25 -0500 Original-Received: from mail-la0-x229.google.com ([2a00:1450:4010:c03::229]:37316) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XneiN-0005Xm-Ea for emacs-devel@gnu.org; Sun, 09 Nov 2014 21:28:23 -0500 Original-Received: by mail-la0-f41.google.com with SMTP id s18so7015727lam.0 for ; Sun, 09 Nov 2014 18:28:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=hgtc3jgkyMtlzVi65IWgwyFAk/iLtdteSEGh/uBLw3s=; b=TF/zbkt5lcpLg1n/iHlOTT9qDB8w2kOtDZ02Tf5WMusUCTgt0nWyho+1P7GhPRvDpb a+3W1TRQ/IBMFC4qV28lopqSzF4145/Vxv2SWk1UzEv5lUtKHEydDfGKFJWNEi6nCd0g Sl7JY3A66+6NhbsJ1ml1qXmNFeBBSNC6KOMVoy41u1tEE/1yC1SSNn7UQFNLev2bqWCD +yfMkEFyakQRxnm8vPNd+ZZz4d/EHxtuD+wvnaiO4jMfxNn5sSCaTEW4fpRKfNyNF9F5 rehlRG5nbYyS8pRYLYl6brhr6wFofHvniRaAe92LZsIlyYFI+W7T9LUuZfXmIWusKLAq jtNQ== X-Received: by 10.152.29.8 with SMTP id f8mr26613599lah.56.1415586502184; Sun, 09 Nov 2014 18:28:22 -0800 (PST) Original-Received: by 10.112.202.106 with HTTP; Sun, 9 Nov 2014 18:28:21 -0800 (PST) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c03::229 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:176657 Archived-At: --089e0158c1589cdbe9050777ead8 Content-Type: multipart/alternative; boundary=089e0158c1589cdbe3050777ead6 --089e0158c1589cdbe3050777ead6 Content-Type: text/plain; charset=UTF-8 Currently in some places of `configure.ac' `${srcdir}' is used without surrounding double quotes what results in `configure' failure. The attached patch makes usage of `${srcdir}' more consistent and fixes it. Yes, I know that when one enter `configure' phase with `${srcdir}' which contains whitespace, one would see checking whether build environment is sane... configure: error: unsafe > srcdir value: ... anyway. But that's another story. Maybe on some bright day, it would be finally safe according to Autotools. Call this pedantic, but I think it is better to receive this official prohibition error, rather than confusing configure: line 3557: ...: No such file or directory for `${srcdir}' with whitespace. --089e0158c1589cdbe3050777ead6 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Currently in some places of `configure.ac' `${srcdir}' is used without surrounding double= quotes what results in `configure' failure. The attached patch makes u= sage of=C2=A0`${srcdir}' more consistent and=C2=A0fixes it. Yes, I know= that when one enter `configure' phase with `${srcdir}' which conta= ins whitespace, one would see

checking wheth= er build environment is sane... configure: error: unsafe srcdir value: ...<= /blockquote>

anyway. But that's another story. Maybe= on some bright day, it would be finally safe according to Autotools. Call = this pedantic, but I think it is better to receive this official prohibitio= n error, rather than confusing

configu= re: line 3557: ...: No such file or directory

for `${srcdir}' with whitespace.
--089e0158c1589cdbe3050777ead6-- --089e0158c1589cdbe9050777ead8 Content-Type: text/plain; charset=US-ASCII; name="configure.ac.diff" Content-Disposition: attachment; filename="configure.ac.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_i2b7lnc10 LS0tIGNvbmZpZ3VyZS5hYy5vcmlnCTIwMTQtMTEtMTAgMDM6MDY6MjkuNjAyNDA2NjAwICswMTAw CisrKyBjb25maWd1cmUuYWMJMjAxNC0xMS0xMCAwMzowNTo0MS4xMDM5MTU4MDAgKzAxMDAKQEAg LTI3LDkgKzI3LDkgQEAKIGRubCBXZSBnZXQgTUlOR1c2NCB3aXRoIE1TWVMyCiBpZiB0ZXN0ICJ4 JE1TWVNURU0iID0gInhNSU5HVzMyIiAtbyAieCRNU1lTVEVNIiA9ICJ4TUlOR1c2NCIKIHRoZW4K LSAgLiAkc3JjZGlyL250L21pbmd3LWNmZy5zaXRlCisgIC4gIiR7c3JjZGlyfSIvbnQvbWluZ3ct Y2ZnLnNpdGUKIAotICBjYXNlICRzcmNkaXIgaW4KKyAgY2FzZSAiJHtzcmNkaXJ9IiBpbgogICAg IC8qIHwgPzoqKQogICAgICAgIyBzcmNkaXIgaXMgYW4gYWJzb2x1dGUgcGF0aC4gIEluIHRoaXMg Y2FzZSwgZm9yY2UgdGhlIGZvcm1hdAogICAgICAgIyAiL2MvZm9vL2JhciIsIHRvIHNpbXBsaWZ5 IGxhdGVyIGNvbnZlcnNpb25zIHRvIG5hdGl2ZSBXaW5kb3dzCkBAIC02MTAsNyArNjEwLDcgQEAK ICAgICAgICotbWluZ3czMiApCiAJCW9wc3lzPW1pbmd3MzIKIAkJIyBNaW5HVyBvdmVycmlkZXMg YW5kIGFkZHMgc29tZSBzeXN0ZW0gaGVhZGVycyBpbiBudC9pbmMuCi0JCUdDQ19URVNUX09QVElP TlM9Ii1JICRzcmNkaXIvbnQvaW5jIgorCQlHQ0NfVEVTVF9PUFRJT05TPSItSSAke3NyY2Rpcn0v bnQvaW5jIgogCQk7OwogICAgICAgKi1zeXN2NC4ydXcqICkJICAJb3BzeXM9dW5peHdhcmUgOzsK ICAgICAgICotc3lzdjV1dyogKQkgIAlvcHN5cz11bml4d2FyZSA7OwpAQCAtNjI1LDcgKzYyNSw3 IEBACiAgICAgICAqLW1pbmd3MzIgKQogCQlvcHN5cz1taW5ndzMyCiAJCSMgTWluR1cgb3ZlcnJp ZGVzIGFuZCBhZGRzIHNvbWUgc3lzdGVtIGhlYWRlcnMgaW4gbnQvaW5jLgotCQlHQ0NfVEVTVF9P UFRJT05TPSItSSAkc3JjZGlyL250L2luYyIKKwkJR0NDX1RFU1RfT1BUSU9OUz0iLUkgJHtzcmNk aXJ9L250L2luYyIKIAkJOzsKICAgICAgICMjIE90aGVyd2lzZSwgd2UnbGwgZmFsbCB0aHJvdWdo IHRvIHRoZSBnZW5lcmljIG9wc3lzIGNvZGUgYXQgdGhlIGJvdHRvbS4KICAgICBlc2FjCkBAIC0x MDQyLDcgKzEwNDIsNyBAQAogIyMgSW4gYSByZXBvc2l0b3J5IGNoZWNrb3V0IG9uIHRoZSBvdGhl ciBoYW5kLCB0aGUgbWFudWFscyBhcmUgbm90IGluY2x1ZGVkLgogIyMgU28gbWFrZWluZm8gaXMg YSByZXF1aXJlbWVudCB0byBidWlsZCBmcm9tIHRoZSByZXBvc2l0b3J5LCBhbmQgY29uZmlndXJl CiAjIyBzaG91bGQgdGVzdCBmb3IgaXQgYXMgaXQgZG9lcyBmb3IgYW55IG90aGVyIGJ1aWxkIHJl cXVpcmVtZW50LgotIyMgV2UgdXNlIHRoZSBwcmVzZW5jZSBvZiAkc3JjZGlyL2luZm8vZW1hY3Mg dG8gZGlzdGluZ3Vpc2ggYSByZWxlYXNlLAorIyMgV2UgdXNlIHRoZSBwcmVzZW5jZSBvZiAke3Ny Y2Rpcn0vaW5mby9lbWFjcyB0byBkaXN0aW5ndWlzaCBhIHJlbGVhc2UsCiAjIyB3aXRoIHByZS1i dWlsdCBtYW51YWxzLCBmcm9tIGEgcmVwb3NpdG9yeSBjaGVja291dC4KIEhBVkVfTUFLRUlORk89 eWVzCiAKQEAgLTEwNTAsNyArMTA1MCw3IEBACiAgIE1BS0VJTkZPPW1ha2VpbmZvCiAgIGlmIHRl c3QgIngke3dpdGhfbWFrZWluZm99IiA9ICJ4bm8iOyB0aGVuCiAgICAgSEFWRV9NQUtFSU5GTz1u bwotICBlbGlmIHRlc3QgISAtZSAiJHNyY2Rpci9pbmZvL2VtYWNzIiAmJiB0ZXN0ICEgLWUgIiRz cmNkaXIvaW5mby9lbWFjcy5pbmZvIjsgdGhlbgorICBlbGlmIHRlc3QgISAtZSAiJHtzcmNkaXJ9 L2luZm8vZW1hY3MiICYmIHRlc3QgISAtZSAiJHtzcmNkaXJ9L2luZm8vZW1hY3MuaW5mbyI7IHRo ZW4KICAgICBBQ19NU0dfRVJST1IoIFtZb3UgZG8gbm90IHNlZW0gdG8gaGF2ZSBtYWtlaW5mbyA+ PSA0LjcsIGFuZCB5b3VyCiBzb3VyY2UgdHJlZSBkb2VzIG5vdCBzZWVtIHRvIGhhdmUgcHJlLWJ1 aWx0IG1hbnVhbHMgaW4gdGhlIGBpbmZvJyBkaXJlY3RvcnkuCiBFaXRoZXIgaW5zdGFsbCBhIHN1 aXRhYmxlIHZlcnNpb24gb2YgbWFrZWluZm8sIG9yIHJlLXJ1biBjb25maWd1cmUKQEAgLTE1NjYs MTMgKzE1NjYsMTMgQEAKICAgICAgIGRlcHNfZnJhZz1hdXRvZGVwcy5tawogICAgZmkKIGZpCi1k ZXBzX2ZyYWc9JHNyY2Rpci9zcmMvJGRlcHNfZnJhZworZGVwc19mcmFnPSIke3NyY2Rpcn0vc3Jj LyRkZXBzX2ZyYWciCiBBQ19TVUJTVChNS0RFUERJUikKIEFDX1NVQlNUKERFUEZMQUdTKQogQUNf U1VCU1RfRklMRShkZXBzX2ZyYWcpCiAKIAotbGlzcF9mcmFnPSRzcmNkaXIvc3JjL2xpc3AubWsK K2xpc3BfZnJhZz0iJHtzcmNkaXJ9L3NyYy9saXNwLm1rIgogQUNfU1VCU1RfRklMRShsaXNwX2Zy YWcpCiAKIApAQCAtNTEyMCw3ICs1MTIwLDcgQEAKIGRubCB0ZXN0LyBpcyBub3QgcHJlc2VudCBp biByZWxlYXNlIHRhcmZpbGVzLgogb3B0X21ha2VmaWxlPXRlc3QvYXV0b21hdGVkL01ha2VmaWxl CiAKLWlmIHRlc3QgLWYgIiRzcmNkaXIvJG9wdF9tYWtlZmlsZS5pbiI7IHRoZW4KK2lmIHRlc3Qg LWYgIiR7c3JjZGlyfS8kb3B0X21ha2VmaWxlLmluIjsgdGhlbgogICBTVUJESVJfTUFLRUZJTEVT PSIkU1VCRElSX01BS0VGSUxFUyAkb3B0X21ha2VmaWxlIgogICBkbmwgQWdhaW4sIGl0J3MgYmVz dCBub3QgdG8gdXNlIGEgdmFyaWFibGUuICBUaG91Z2ggeW91IGNhbiBhZGQKICAgZG5sICIsIFtd LCBbb3B0X21ha2VmaWxlPSckb3B0X21ha2VmaWxlJ10iIGFuZCBpdCBzaG91bGQgd29yay4KQEAg LTUxMjksNyArNTEyOSw3IEBACiAKIAogZG5sIFRoZSBhZG1pbi8gZGlyZWN0b3J5IHVzZWQgdG8g YmUgZXhjbHVkZWQgZnJvbSB0YXJmaWxlcy4KLWlmIHRlc3QgLWQgJHNyY2Rpci9hZG1pbjsgdGhl bgoraWYgdGVzdCAtZCAiJHtzcmNkaXJ9L2FkbWluIjsgdGhlbgogICBTVUJESVJfTUFLRUZJTEVT PSIkU1VCRElSX01BS0VGSUxFUyBhZG1pbi91bmlkYXRhL01ha2VmaWxlIGFkbWluL2dyYW1tYXJz L01ha2VmaWxlIgogICBBQ19DT05GSUdfRklMRVMoW2FkbWluL3VuaWRhdGEvTWFrZWZpbGVdKQog ICBBQ19DT05GSUdfRklMRVMoW2FkbWluL2dyYW1tYXJzL01ha2VmaWxlXSkKQEAgLTUxNTcsMTAg KzUxNTcsMTAgQEAKIF0sIFtHQ0M9IiRHQ0MiIENQUEZMQUdTPSIkQ1BQRkxBR1MiIG9wc3lzPSIk b3BzeXMiXSkKIAogZG5sIE5CIHdlIGhhdmUgdG8gY2hlYXQgYW5kIHVzZSB0aGUgYWNfLi4uIHZl cnNpb24gYmVjYXVzZSBhYnNfdG9wX3NyY2RpcgotZG5sIGlzIG5vdCB5ZXQgc2V0LCBzaWdoLiAg T3Igd2UgY291bGQgdXNlIC4uLyRzcmNkaXIvc3JjLy5nZGJpbml0LAorZG5sIGlzIG5vdCB5ZXQg c2V0LCBzaWdoLiAgT3Igd2UgY291bGQgdXNlIC4uLyR7c3JjZGlyfS9zcmMvLmdkYmluaXQsCiBk bmwgb3IgYSBzeW1saW5rPwogQUNfQ09ORklHX0NPTU1BTkRTKFtzcmMvLmdkYmluaXRdLCBbCi1p ZiB0ZXN0ICEgLWYgc3JjLy5nZGJpbml0ICYmIHRlc3QgLWYgIiRzcmNkaXIvc3JjLy5nZGJpbml0 IjsgdGhlbgoraWYgdGVzdCAhIC1mIHNyYy8uZ2RiaW5pdCAmJiB0ZXN0IC1mICIke3NyY2Rpcn0v c3JjLy5nZGJpbml0IjsgdGhlbgogICBlY2hvICJzb3VyY2UgJGFjX2Fic190b3Bfc3JjZGlyL3Ny Yy8uZ2RiaW5pdCIgPiBzcmMvLmdkYmluaXQKIGZpCiBdKQo= --089e0158c1589cdbe9050777ead8--