From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Dhruva Krishnamurthy Newsgroups: gmane.emacs.devel Subject: Re: Build segfaults when loading image.el Date: Mon, 23 Dec 2019 18:09:04 -0800 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000fdf54d059a69a22f" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="195229"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Dec 24 03:10:14 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ijZeI-000oeX-G9 for ged-emacs-devel@m.gmane.org; Tue, 24 Dec 2019 03:10:14 +0100 Original-Received: from localhost ([::1]:35222 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ijZeG-0006GM-Jc for ged-emacs-devel@m.gmane.org; Mon, 23 Dec 2019 21:10:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48607) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ijZdm-0005oy-Kr for emacs-devel@gnu.org; Mon, 23 Dec 2019 21:09:43 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ijZdl-0003Gm-Io for emacs-devel@gnu.org; Mon, 23 Dec 2019 21:09:42 -0500 Original-Received: from mail-ot1-x329.google.com ([2607:f8b0:4864:20::329]:38347) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ijZdl-0003Fh-Bo for emacs-devel@gnu.org; Mon, 23 Dec 2019 21:09:41 -0500 Original-Received: by mail-ot1-x329.google.com with SMTP id d7so20044112otf.5 for ; Mon, 23 Dec 2019 18:09:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=stDAXiu86yDk1ghbs7KqmN06je3lWZahlY8nHKfwggE=; b=F92LrA77cMa57uhhk/R1C+kUWT3oivKNQCRpU7fFFlrKSOb0Aq2XFO+zya6f0f6iww qtroOvEalnK/uzzCCAYYJJrN2kUH2fZG+/ommpMMM/DWCcFFLlquHfaB6aY/ZbPZEubp UrzPApB1C17H+ZlzMaCtCmNWnGfU4nQyHmOArotJSp8Mso/UoAUbeoncOBNs2mwbkJ0k FOKPpPjlqUvp2shzQ/pT1Mr0MkiAgPd/ReR6fFYoNmTcizBodZOwu/f6cK5FEC+6q4rG q+qXMgEpN2Kfv1i/szDIaBBgGQU8CNqE63k0h++jIG8q3SLsG/+hwO27cTeA1032z82F GM5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=stDAXiu86yDk1ghbs7KqmN06je3lWZahlY8nHKfwggE=; b=CojDRdRviAE1Yp3OIP79LzgSzJt0DMYKfBeMuek/gyeuurYRaiG3hC79X2sje6IO48 DtusoFgAOF1AP1EAbiqMwH00Iskpm07YdTvXvMXUZtPfyRH9mJihe4D4P8vGLzBds4Nw iwVP+iEj3HHLcT0DuKC0noiLAs/4zZbMHtrnw8hmvN252CHw2uAV2Wugt86Ye1dZ4uzR Y7ES9V4zReAls6wMX74cjhxcPjTvplynmDBuZ/0gzjai1cWfn+IH1+caWkTLuufXx55G 24s2JXV895o59RMpO+o9J/0Scjfd3/jLUns+mcVFqKz1sQSTkonyRccLKx3ZW0JN65Y+ Ebew== X-Gm-Message-State: APjAAAU07lhnHo5mzk8y0QMn+tdMFM0wd+pc7Y1c6zB9ykhYg2c/EMz+ OYaDVfpREBYD0dUdPFsRXsjNnsen/4lTj/GLT0U= X-Google-Smtp-Source: APXvYqzHHDDeP6Csq1ns0cPLr6HNSipBr45GRShrV5dTIzl28/s9BeHElDvkj6djxlqt5kp0MwmL2y9A0zemXtZhgjM= X-Received: by 2002:a9d:630d:: with SMTP id q13mr33874938otk.31.1577153380347; Mon, 23 Dec 2019 18:09:40 -0800 (PST) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::329 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:243599 Archived-At: --000000000000fdf54d059a69a22f Content-Type: text/plain; charset="UTF-8" I still feel the original patch calling into IsMagickWandInstantiated() was more correct since we were fetching it from ImageMagick library and not setting it to true without checking if it is really initialized. -dhruva On Mon, Dec 23, 2019 at 5:24 PM Paul Eggert wrote: > Thanks, I installed that onto the emacs-27 branch on Savannah. > --000000000000fdf54d059a69a22f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I still feel the o= riginal patch calling into IsMagickWandInstantiated() was more correct sinc= e we were=C2=A0fetching it from ImageMagick library and not setting it to t= rue without checking if it is really initialized.

-dhruva

On Mon, Dec 23, 2019 at 5:24 PM Paul Eggert <eggert@cs.ucla.edu> wrote:
<= blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-l= eft-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);pa= dding-left:1ex">Thanks, I installed that onto the emacs-27 branch on Savann= ah.
--000000000000fdf54d059a69a22f--