From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: John Yates Newsgroups: gmane.emacs.devel Subject: Re: New Git hooks for checking file names in commit messages Date: Fri, 21 Apr 2023 08:05:43 -0400 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37042"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Jim Porter Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Apr 21 14:07:08 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pppXg-0009Sk-JD for ged-emacs-devel@m.gmane-mx.org; Fri, 21 Apr 2023 14:07:08 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pppWe-00005C-07; Fri, 21 Apr 2023 08:06:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pppWZ-00004u-92 for emacs-devel@gnu.org; Fri, 21 Apr 2023 08:05:59 -0400 Original-Received: from mail-ej1-f46.google.com ([209.85.218.46]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pppWX-0006PZ-NV for emacs-devel@gnu.org; Fri, 21 Apr 2023 08:05:58 -0400 Original-Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-94f1d0d2e03so204786866b.0 for ; Fri, 21 Apr 2023 05:05:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682078755; x=1684670755; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=h6VfzNUrF9Uo30088a6J67CwX/mZtO+LZ0DWG2h5uN0=; b=NkKcvbcuUIo6MRAIbZh/Pnr+o23zbG9q+fRyYmuQHjBPdt/k+P8MZyMEGyKtQkxSbm PB4CHKQX9yThEjzNWrUNnt6k+iCm232AIXhe0PNiDxPcaEz2ZRnXtp+bKsMtRSWKnajs qNmSBFJw+RLfTSoOKewOr8T/7LbI+fF03yxWe18kIJIv18G0X8z1WjgbIYdOnM4VuEIn tiUAY0hVCOVGu2HA4yJwyfNhLgqHya5Vb01TfnVL42rsewMLeiYzKHLKXWuFmfjlEIFI qlCM8p+QqSCvOvdMBVETQKndIwzvQ+44shGJU5ot8Xumq/rjyw+H5yqzOhBZ4vQ4TPTJ BB3Q== X-Gm-Message-State: AAQBX9dj+b980ZEwYGCykUimREF3Ws89fqRQIYZq7qnbDS5ify/OwfwC +XyrNknTvv1+sIWRyj6wh5lT/+n3A+3kA6EfIqK3bY5Y X-Google-Smtp-Source: AKy350YQT0HgqvvVEqV3FO1KimPBTUd/J1nB0kTiH5IVvgf7Bf3t92/om0hb5fd8LTcxytNuWCVMsFOqx1niNA9T9d8= X-Received: by 2002:a17:907:7e94:b0:94e:d75b:5998 with SMTP id qb20-20020a1709077e9400b0094ed75b5998mr2330162ejc.5.1682078755344; Fri, 21 Apr 2023 05:05:55 -0700 (PDT) In-Reply-To: Received-SPF: pass client-ip=209.85.218.46; envelope-from=john.yates.sheets@gmail.com; helo=mail-ej1-f46.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:305543 Archived-At: On Fri, Apr 21, 2023 at 12:55=E2=80=AFAM Jim Porter = wrote: > > This also means that if you want to use a "*" for a bulleted list of > sentences, you should do something to make it not look like a file > entry. For example, " *" is ok. I am not wild about this change in commit message syntax. It clashes with all my other uses of git. Do you allow more than one file on a bulleted line? If not then could you use a whitespace check to identify most bulleted lines which do not actually contain a file name? Another heuristic might be to accumulate whether among all of the files in the diffs there are any without file extensions. If all file name= s do indeed include extensions then a bulleted line without a "." foolowed immediately by a non-whitespace character could be skipped.