From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: John Yates Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] About the :distant-foreground face attribute Date: Wed, 15 Jan 2014 16:31:36 -0500 Message-ID: References: <87bnzo9cja.fsf@gnu.org> <52D3E689.6050902@dancol.org> <8E16225F-53EF-498A-AB35-66EB9B33B859@swipnet.se> <52D43360.6050605@dancol.org> <9BD01B88-AF13-44DD-8DBE-4598BAC136DD@swipnet.se> <52D45C73.6090906@dancol.org> <52D4EBA9.8050802@swipnet.se> <52D4F2C2.8080800@dancol.org> <52D504A7.80104@swipnet.se> <52D514FF.7010404@dancol.org> <52D52312.6070106@swipnet.se> <52D58632.3010106@dancol.org> <381DEBDC-71D8-4FAC-BA55-897FEC73A2FC@swipnet.se> <52D5A072.5010508@dancol.org> <064CFFB5-6E50-40D5-B2CB-2BECC656D93F@swipnet.se> <83txd545n7.fsf@gnu.org> <83fvop4265.fsf@gnu.org> <837ga13zh2.fsf@gnu.org> <8338kp3w0g.fsf@gnu.org> <83wqi12d3s.fsf@gnu.org> <52D6F7A1.80707@dancol.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a11c136ce9f750b04f0090829 X-Trace: ger.gmane.org 1389821502 11988 80.91.229.3 (15 Jan 2014 21:31:42 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 15 Jan 2014 21:31:42 +0000 (UTC) Cc: Chong Yidong , Emacs developers , Stefan Monnier , Josh , Eli Zaretskii , =?ISO-8859-1?Q?Jan_Dj=E4rv?= To: Daniel Colascione Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jan 15 22:31:49 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1W3Y3u-0001sQ-OA for ged-emacs-devel@m.gmane.org; Wed, 15 Jan 2014 22:31:46 +0100 Original-Received: from localhost ([::1]:57310 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3Y3u-0001kt-7k for ged-emacs-devel@m.gmane.org; Wed, 15 Jan 2014 16:31:46 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35625) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3Y3r-0001ki-1S for emacs-devel@gnu.org; Wed, 15 Jan 2014 16:31:44 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W3Y3p-00050m-Th for emacs-devel@gnu.org; Wed, 15 Jan 2014 16:31:42 -0500 Original-Received: from mail-qa0-x22d.google.com ([2607:f8b0:400d:c00::22d]:46427) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3Y3m-000506-L5; Wed, 15 Jan 2014 16:31:38 -0500 Original-Received: by mail-qa0-f45.google.com with SMTP id ii20so1402895qab.4 for ; Wed, 15 Jan 2014 13:31:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=eoPwcDeBNRxRANRcDO1Gjis+6gFKgGIk6RpcWx2RzwI=; b=DY9RlHfBKfyANJvS0/Gdg+vU6WmfHQyKg6kKdgTJGIRs9hRMZckmlRG2DmWhzmzs2D de6OVLfMnhSvL30M5cDb0li0oBKgk4IcTrTmxka0/iMfHd3DKkqA8Kw9PFiI0LR9yEPo lxIR3vJ9QCfOnYhv8ypbKUwFfYmtxgkn3R8uoqxnBW6XSd9tMas5yKGP6zwBeZC92zjX irmKnXrs969QDEwYV6HYON+zM6CI4j22C7CY+70upDCGnPyjq3uI/ssuXNkD7W+o+bTz GmWyMVK3BxaBEtjuHC8kbwte5ll0pVhB25dbwdeV8EVPVDo9Q9QaT4SXzB2pG/LMXwO6 owBA== X-Received: by 10.140.38.168 with SMTP id t37mr1688487qgt.33.1389821496880; Wed, 15 Jan 2014 13:31:36 -0800 (PST) Original-Received: by 10.224.9.13 with HTTP; Wed, 15 Jan 2014 13:31:36 -0800 (PST) In-Reply-To: <52D6F7A1.80707@dancol.org> X-Google-Sender-Auth: YlFIzdOPpWgOddTPE3XUZpc6aMs X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:400d:c00::22d X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:168500 Archived-At: --001a11c136ce9f750b04f0090829 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable :post-merge-adjust ? :final-adjust ? /john On Wed, Jan 15, 2014 at 4:03 PM, Daniel Colascione wrote= : > On 01/15/2014 12:40 PM, Eli Zaretskii wrote: > >> From: Josh >>> Date: Wed, 15 Jan 2014 12:05:05 -0800 >>> Cc: Stefan Monnier , Jan Dj=E4rv < >>> jan.h.d@swipnet.se>, >>> Daniel Colascione , Chong Yidong , >>> emacs-devel >>> >>> Though this does seem likely, it might be wise to adopt a less >>> specific name for this attribute now in case other appropriate uses >>> of this adjustment mechanism later come to light. If we were to >>> use a name like :attribute-filters or :attribute-adjusters we'd retain >>> flexibility for the future even though we might only support >>> adjusting foreground color initially (or indeed ever). >>> >> >> It has been a long tradition of Emacs not to generalize before there's >> a clear and present need to. >> > > Sure. The problem with :adjust-colors or some other specific name, though= , > is what happens to ordering if we introduce other kinds of filters. If we > have :adjust-colors and some hypothetical :adjust-foo, the order in which > the adjustments are made becomes unclear. If we have a single list of > filters, ordering is natural. > > Also, can we please include "post-" in the name of the attribute? I want > to emphasize that the filtering happens *after* face merging. > > --001a11c136ce9f750b04f0090829 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
:post-merge-adjust ?
:final-adjust ?

/john


On Wed, Jan 15, 2014 at 4:03 PM, Daniel Colascione <dancol@dan= col.org> wrote:
On 01/15/2014 12:40 PM, Eli Zaretskii wrote:=
From: Josh <josh@f= oxtail.org>
Date: Wed, 15 Jan 2014 12:05:05 -0800
Cc: Stefan Monnier <monnier@iro.umontreal.ca>, Jan Dj=E4rv <jan.h.d@swipnet.se>,
=A0 =A0 =A0 =A0 Daniel Colascione <dancol@dancol.org>, Chong Yidong <cyd@gnu.org>, emacs-devel <emacs-devel@gnu.org<= /a>>

Though this does seem likely, it might be wise to adopt a less
specific name for this attribute now in case other appropriate uses
of this adjustment mechanism later come to light. =A0If we were to
use a name like :attribute-filters or :attribute-adjusters we'd retain<= br> flexibility for the future even though we might only support
adjusting foreground color initially (or indeed ever).

It has been a long tradition of Emacs not to generalize before there's<= br> a clear and present need to.

Sure. The problem with :adjust-colors or some other specific name, though, = is what happens to ordering if we introduce other kinds of filters. If we h= ave :adjust-colors and some hypothetical :adjust-foo, the order in which th= e adjustments are made becomes unclear. If we have a single list of filters= , ordering is natural.

Also, can we please include "post-" in the name of the attribute?= I want to emphasize that the filtering happens *after* face merging.


--001a11c136ce9f750b04f0090829--