Re: [PATCH] About the :distant-foreground face attribute

[John Yates <john@yates-sheets.org>]

[-- Attachment #1: Type: text/plain, Size: 1499 bytes --]

:post-merge-adjust ?
:final-adjust ?

/john


On Wed, Jan 15, 2014 at 4:03 PM, Daniel Colascione <dancol@dancol.org>wrote:

> On 01/15/2014 12:40 PM, Eli Zaretskii wrote:
>
>> From: Josh <josh@foxtail.org>
>>> Date: Wed, 15 Jan 2014 12:05:05 -0800
>>> Cc: Stefan Monnier <monnier@iro.umontreal.ca>, Jan Djärv <
>>> jan.h.d@swipnet.se>,
>>>         Daniel Colascione <dancol@dancol.org>, Chong Yidong <cyd@gnu.org>,
>>> emacs-devel <emacs-devel@gnu.org>
>>>
>>> Though this does seem likely, it might be wise to adopt a less
>>> specific name for this attribute now in case other appropriate uses
>>> of this adjustment mechanism later come to light.  If we were to
>>> use a name like :attribute-filters or :attribute-adjusters we'd retain
>>> flexibility for the future even though we might only support
>>> adjusting foreground color initially (or indeed ever).
>>>
>>
>> It has been a long tradition of Emacs not to generalize before there's
>> a clear and present need to.
>>
>
> Sure. The problem with :adjust-colors or some other specific name, though,
> is what happens to ordering if we introduce other kinds of filters. If we
> have :adjust-colors and some hypothetical :adjust-foo, the order in which
> the adjustments are made becomes unclear. If we have a single list of
> filters, ordering is natural.
>
> Also, can we please include "post-" in the name of the attribute? I want
> to emphasize that the filtering happens *after* face merging.
>
>

[-- Attachment #2: Type: text/html, Size: 2430 bytes --]