From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dominique Quatravaux Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] vc-git-revert: Execute commands from FILE's `vc-git-root'. Date: Tue, 11 Dec 2012 11:08:18 +0100 Message-ID: References: <1354872033-4313-1-git-send-email-domq@google.com> <1354872033-4313-2-git-send-email-domq@google.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 X-Trace: ger.gmane.org 1355220542 30277 80.91.229.3 (11 Dec 2012 10:09:02 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 11 Dec 2012 10:09:02 +0000 (UTC) Cc: fischman@google.com To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Dec 11 11:09:15 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TiMlx-0000ek-Ta for ged-emacs-devel@m.gmane.org; Tue, 11 Dec 2012 11:09:10 +0100 Original-Received: from localhost ([::1]:58990 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TiMll-0007uw-8I for ged-emacs-devel@m.gmane.org; Tue, 11 Dec 2012 05:08:57 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:49043) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TiMlb-0007tM-B6 for emacs-devel@gnu.org; Tue, 11 Dec 2012 05:08:55 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TiMlT-0001qp-Ia for emacs-devel@gnu.org; Tue, 11 Dec 2012 05:08:47 -0500 Original-Received: from mail-ee0-f41.google.com ([74.125.83.41]:44893) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TiMlT-0001qa-C7 for emacs-devel@gnu.org; Tue, 11 Dec 2012 05:08:39 -0500 Original-Received: by mail-ee0-f41.google.com with SMTP id d41so2359026eek.0 for ; Tue, 11 Dec 2012 02:08:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=KEXwnzbXnKgAd7iJKEyDLJYEsnoJxYaOWiDQPKGCBHE=; b=S/AKrCBotV55vMYteLcrLGwL+TckmMrLGo2oWRniUCmJVnOepJrw2qIOCTte0baSbl Sl+WSn/9MjIMgT56vNAfLLEFqp1E7c98tPOrFsGAwZWZREvRCKfScF5rMvnc3nw2miPb T2+EPq4qXYTh7OkuZdkjjf81MXNTiZVECVR6higTkYbVl9NZ/VXGYJN2OEBQVR9LmxhU UzMzgUiLMoKvumx9p9viN+/ltID795JCHe7rvGkzX2jstAsyRpXg2eex/JxGSi6I4A/B Z5xPnQQnkpMF+6MJhpixxX/BSZkX2Vd4X+/Btsy9SRsgvFKGTvmf8hbG7hvHfuZUdPoN XrwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:x-gm-message-state; bh=KEXwnzbXnKgAd7iJKEyDLJYEsnoJxYaOWiDQPKGCBHE=; b=lZk6fYlJL7fV+kxKR20EsFR6HlwYvlzKCaoj2/jjCfE1MzyNOAQMJPM3W9b+WG+Hmo I2pohzKm8r0sMm1//+CmX7ePiJP72lksUhfCcUoWegjpyXjcDFz5YH2soLV7fbyrjrrC rY3emrNMYHKuB80llz+k+ukyNuQ/T2f5UKlLTfINbpplpUUgMYF+tg+d46MfLVN8/yVQ PEn6uuWvBLxxJdjz+d9oIxkO1gk6enmz76MOG9nc8KsyqtDsD++6Q9Rz25juzMtBHbl1 wp8eSetK7Lt8A6CQzUc5LBLKX0NK8d5Xv24qyly3q/O+tWeVVCe8p36AGj0Jax9JT/Fe XDug== Original-Received: by 10.14.215.197 with SMTP id e45mr59750421eep.0.1355220518301; Tue, 11 Dec 2012 02:08:38 -0800 (PST) Original-Received: by 10.223.195.7 with HTTP; Tue, 11 Dec 2012 02:08:18 -0800 (PST) In-Reply-To: <1354872033-4313-2-git-send-email-domq@google.com> X-Gm-Message-State: ALoCoQnTBFOV9Gin2KlY4JDaEsoClzdswltDZ5ZBXKomtsiLwaqwzdr6sUcY01G7uJq68ZKHzm+MKWENylw5Bl1nCbGpBA8WGlkSaPVNahKJwHLn8trqGgHfJC1gxS0G+sYHugbt0h+rkH5NlYxpCSotW3xtivqoerDaq25PsPsVJIJq3ruLTV45/rypNmMnhQAUsddIjkd2 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 74.125.83.41 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:155461 Archived-At: As per Ami's suggestion, here is how to reproduce the breakage that this patch fixes: * Create two different Git repositories, repo1 and repo2; add and commit a test file in each (say repo1/test.txt and repo2/test.txt). * Open repo1/test.txt in a pristine Emacs instance; add a line to it and save. * Open repo2/test.txt from the same instance; add a line to it and save. * Try to revert repo2/test.txt using C-x v u. Tested with Emacs 24.2.50.1 from Ubuntu Precise (2:20121025-1~ppa1~precise1) -- Dominique Quatravaux +41 79 609 40 72