From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Corwin Brust Newsgroups: gmane.emacs.devel Subject: Re: [External] : emacs-28 windows binaries available from alpha Date: Sat, 5 Feb 2022 21:11:52 -0600 Message-ID: References: <834k5d3hbv.fsf@gnu.org> <83o83l1v51.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26414"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "H. Dieter Wilhelm" , Emacs developers , Drew Adams , Andrea Corallo To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Feb 06 04:12:49 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nGXyr-0006hN-O6 for ged-emacs-devel@m.gmane-mx.org; Sun, 06 Feb 2022 04:12:49 +0100 Original-Received: from localhost ([::1]:47268 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nGXyq-00040K-GG for ged-emacs-devel@m.gmane-mx.org; Sat, 05 Feb 2022 22:12:48 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:34848) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nGXyB-0003Le-ME for emacs-devel@gnu.org; Sat, 05 Feb 2022 22:12:07 -0500 Original-Received: from mail-ed1-f51.google.com ([209.85.208.51]:41908) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nGXy9-0006DK-Cu; Sat, 05 Feb 2022 22:12:07 -0500 Original-Received: by mail-ed1-f51.google.com with SMTP id cz16so3994128edb.8; Sat, 05 Feb 2022 19:12:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=J6SC9v6LPZSUR2CGKFyTe7qvJqSRU3xzZ/ANvxwtJms=; b=3feS6+Nihv6l+G2O9kaG3CpxDXiVwBaEYZma7NdRXiowdhau0H6nQTQCsH45NNRJzM GbE3y6S/HTXUIgztwRqdoYSZ6vT3/dpSkWUk9j6uuWHA78Fc1PblC/YtLjGkxRayF6xt CYHblTPJfWSu56RriwS/KgiS65qyp4tqopE8OewTtm467UCppR+0uU222aboJnKW62KP QJnRNvYBI+KELrKdnMQqCFWCFuJHA75FM/bVNNFGYCWvaFnpqmLTmfRqmIPQj4XUck0k cf+wMdwf8A9FF9YUIoCmGzRCMEuC1bq0RP711dz25/nEFAoPCGHVfDzBOa+Szscm/7/+ IBmA== X-Gm-Message-State: AOAM533xgKuAcUN5j2lJ1W4IcOy5fcmdi8bENuUQIgILQEvb7GD4IAvh Ql61CV/rSOPGzeCbui6xeWd8Kak326wfemF9coX8ZGN+QRw= X-Google-Smtp-Source: ABdhPJwsVcXwxTWdEKlgSErM31LNkulAqijydTFoE4A0kkI6IwIlKFMZ5LqzILpUPFNEE2v6zl9XjxeOr/8GD/uUFdI= X-Received: by 2002:aa7:d64e:: with SMTP id v14mr7155789edr.335.1644117123444; Sat, 05 Feb 2022 19:12:03 -0800 (PST) In-Reply-To: <83o83l1v51.fsf@gnu.org> Received-SPF: pass client-ip=209.85.208.51; envelope-from=mplscorwin@gmail.com; helo=mail-ed1-f51.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:285926 Archived-At: On Sat, Feb 5, 2022 at 4:10 AM Eli Zaretskii wrote: > > Andrea, how about the following patch (which assumes > comp-enable-subr-trampolines enables and disables only generation of > new trampolines, but doesn't affect the use of existing trampolines)? > Is this safe for the release branch, in your opinion? To be very clear: I'm in no position to comment on how safe this patch is. That said... > > diff --git a/src/comp.c b/src/comp.c > index 188dc6e..ba65837 100644 > --- a/src/comp.c > +++ b/src/comp.c > @@ -434,6 +434,13 @@ load_gccjit_if_necessary (bool mandatory) > gccjit_initialized = init_gccjit_functions (); > status = gccjit_initialized ? Qt : Qnil; > Vlibrary_cache = Fcons (Fcons (Qgccjit, status), Vlibrary_cache); > + /* Disable deferred async compilation and trampoline synthesis > + in this session, since libgccjit is not available. */ > + if (!gccjit_initialized) > + { > + native_comp_deferred_compilation = false; > + comp_enable_subr_trampolines = false; > + } > } > > if (mandatory && !gccjit_initialized) I was able to apply this to the emacs-28 branch and confirm it does the job. Thanks due to my elder lad for use of his gaming rig on a Saturday eve. The "Patched" result set came from a new set of binary packages[1] built with this patch. I also tried a few other things and didn't spot any obvious breakage. Drew, Please LMK if you spot issues with my reproducer and (if you gett a chance to try) whether you get any different result or if this seems to solve the issue. Reproducer: 0. create a folder called c:\emacs 1. download the EL file as linked in Drew's original message to this thread to c:\emacs 2. download the ELC file attached to that same message to c:\emacs 3. unpack emacs-28.0.91.zip into c:\emacs 4. double click runemacs.exe 5. In scratch, paste in the following sniped and press C-x C-e (let ((load-path (append (list "c:/emacs") load-path))) (require 'strings)) Patched: find "strings" at the tail of the *Messages* buffer Unpatched: Debugger entered--Lisp error: (error "Cannot find libgccjit library") error("Cannot find libgccjit library") comp-ensure-native-compiler() comp--native-compile((lambda (arg0 &optional arg1 arg2 arg3) (let ((f #'read-buffer)) (funcall f arg0 arg1 arg2 arg3))) nil "c:/Users/Miko/AppData/Roaming/.emacs.d/eln-cache/2...") comp-trampoline-compile(read-buffer) comp-subr-trampoline-install(read-buffer) defalias(read-buffer #f(compiled-function (prompt &optional default require-match predicate) #)) require(strings) (let ((load-path (append (list "c:/emacs") load-path))) (require 'strings)) (progn (let ((load-path (append (list "c:/emacs") load-path))) (require 'strings))) elisp--eval-last-sexp(nil) eval-last-sexp(nil) funcall-interactively(eval-last-sexp nil) command-execute(eval-last-sexp) [1] Windows binaries Eli's patch, as above: https://git.sr.ht/~mplscorwin/emacs-w64/tree/master/item/patched