From: Corwin Brust <corwin@bru.st>
To: emacs-devel@gnu.org, Yuan Fu <casouri@gmail.com>
Cc: emacs-diffs@gnu.org
Subject: Re: emacs-29 ec4d29c4494: Improve performance of treesit_cursor_helper_1
Date: Thu, 31 Aug 2023 16:23:56 -0500 [thread overview]
Message-ID: <CAJf-WoR9XLFAUkiTJhD4w8AhuhE-Batpo1FZHrrgXcoCd1B85g@mail.gmail.com> (raw)
In-Reply-To: <20230831042424.B51E5C038B5@vcs2.savannah.gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1500 bytes --]
On Wed, Aug 30, 2023 at 11:24 PM Yuan Fu <casouri@gmail.com> wrote:
>
> branch: emacs-29
> commit ec4d29c4494f32acf0ff7c5632a1d951d957f084
> Author: Yuan Fu <casouri@gmail.com>
> Commit: Yuan Fu <casouri@gmail.com>
>
> Improve performance of treesit_cursor_helper_1
>
> * src/treesit.c: (treesit_cursor_helper_1): Use
> - if (!ts_tree_cursor_goto_first_child (cursor))
> + if (ts_tree_cursor_goto_first_child_for_byte (cursor, start_pos) == -1)
Hi Yuan,
I think this commit may have broken things for the Windows port.
Running configure I now get:
C:/msys2/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/11.3.0/../../../../x86_64-w64-mingw32/bin/ld.exe:
treesit.o:treesit.c:(.text+0xce2): undefined reference to
`ts_tree_cursor_goto_first_child_for_byte'
Interestingly, it does seem to exist in
mingw32/mingw-w64-i686-tree-sitter 0.20.6-1 (current, according to
pacman -Ss tree-sitter):
Function Name Address Relative Address Ordinal Filename Full Path Type
ts_tree_cursor_goto_first_child_for_byte 0x00000002c62ef550 0x0001f550
179 (0xb3) libtree-sitter.dll C:\msys2\mingw64\bin\libtree-sitter.dll
Exported Function
I've attached the complete log, here's my configure command. which
followed a git clean -xf && ./autogen.sh:
./configure --enable-checking='yes,glyphs'
--enable-check-lisp-object-type --with-modules --without-dbus
--with-native-compilation=aot --without-compress-install
--with-tree-sitter CFLAGS='-O0 -g3' | tee /g/quick.log
[-- Attachment #2: quick.zip --]
[-- Type: application/x-zip-compressed, Size: 6398 bytes --]
next parent reply other threads:[~2023-08-31 21:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <169345586442.5629.18133276907856406640@vcs2.savannah.gnu.org>
[not found] ` <20230831042424.B51E5C038B5@vcs2.savannah.gnu.org>
2023-08-31 21:23 ` Corwin Brust [this message]
2023-09-01 2:07 ` emacs-29 ec4d29c4494: Improve performance of treesit_cursor_helper_1 Yuan Fu
2023-09-01 3:28 ` Corwin Brust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJf-WoR9XLFAUkiTJhD4w8AhuhE-Batpo1FZHrrgXcoCd1B85g@mail.gmail.com \
--to=corwin@bru.st \
--cc=casouri@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=emacs-diffs@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).