From: Matt McClure <matthewlmcclure@gmail.com>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: tramp-devel@gnu.org, emacs-devel@gnu.org
Subject: Re: TRAMP: Host name must not match method ...
Date: Mon, 19 Aug 2013 22:38:10 -0400 [thread overview]
Message-ID: <CAJELnLEQ4b66VEdgN4WrZHaig0T5CL3curAJYNBF+_3Y5tVMOQ@mail.gmail.com> (raw)
In-Reply-To: <87haelopdc.fsf@gmx.de>
On Mon, Aug 19, 2013 at 8:07 AM, Michael Albinus <michael.albinus@gmx.de> wrote:
> Matt McClure <matthewlmcclure@gmail.com> writes:
>
>> Here's the backtrace the first time it stops:
>
> [...]
>
>> rfn-eshadow-update-overlay()
>
> Strange. The user error in `tramp-dissect-file-name' is raised only when
> `tramp-completion-mode-p' returns nil. That function checks (beside
> other things) the variable `non-essential', which is bound to t inside
> `rfn-eshadow-update-overlay'. So there shouldn't be any problem.
True. The first backtrace from my previous message is in a scenario
where the error doesn't surface to the user. The second backtrace,
which does not include `rfn-eshadow-update-overlay', is the failure
case.
> Could you, please, check whether you might have shadow lisp files? Try
> "M-x list-load-path-shadows".
No Emacs Lisp load-path shadowings were found
> In the debugger, you might also check the value of `non-essential', when
> you pass `rfn-eshadow-update-overlay' and the break point.
At the breakpoint in the failure case, and actually in the success cases also:
non-essential is a variable defined in `simple.el'.
Its value is nil
>> C-x C-f /ssh:vagrant@192.168.33.2:/ RET
>>
>> This time the backtrace looks different. I notice these two stack
>> frames that look suspicious:
>>
>> substitute-in-file-name("/ssh:vagrant@192.168.10.")
>> completion--sifn-requote(27 "/ssh:vagrant@192.168.10.2:/")
>
> Here I don't see exactly what happens; I'm not so familiar with the
> completion code in minibuffer.el. But maybe this is caused by the same
> reason as the first break, let's see.
Comparing rfn-eshadow-update-overlay to completion--sifn-requote, I
notice that the former wraps its call to substitute-in-file-name with
condition-case, whereas the latter does not. I believe the user-error
is signaled in both cases, but in the former it's handled by
condition-case, whereas in the latter nothing handles it.
I'm able to work around the problem with:
diff -u --label
/Applications/Emacs.app/Contents/Resources/lisp/minibuffer.el.gz\~
--label /Applications/Emacs.app/Contents/Resources/lisp/minibuffer.el.gz
/var/folders/_d/5p0jtv397qs73qr_frd6bw180000gn/T/jka-com874eUK
/var/folders/_d/5p0jtv397qs73qr_frd6bw180000gn/T/jka-com8744oW
--- /Applications/Emacs.app/Contents/Resources/lisp/minibuffer.el.gz~
+++ /Applications/Emacs.app/Contents/Resources/lisp/minibuffer.el.gz
@@ -2256,13 +2256,15 @@
;; Second assumptions: If qpos is far from the end this can be a bit slow,
;; so we speed it up by doing a first loop that skips a word at a time.
;; This word-sized loop is careful not to cut in the middle of env-vars.
- (while (let ((boundary (string-match "\\(\\$+{?\\)?\\w+\\W*\\'" qstr)))
- (and boundary
- (progn
- (setq qprefix (substring qstr 0 boundary))
- (string-prefix-p uprefix
- (substitute-in-file-name qprefix)))))
- (setq qstr qprefix))
+ (condition-case nil
+ (while (let ((boundary (string-match "\\(\\$+{?\\)?\\w+\\W*\\'" qstr)))
+ (and boundary
+ (progn
+ (setq qprefix (substring qstr 0 boundary))
+ (string-prefix-p uprefix
+ (substitute-in-file-name qprefix)))))
+ (setq qstr qprefix))
+ (error nil))
(let ((qpos (length qstr)))
(while (and (> qpos 0)
(string-prefix-p uprefix
Diff finished. Mon Aug 19 22:29:17 2013
But it seems that there must be a copy of minibuffer.el compiled into
the executable (?). Even though the completion--sifn-requote is
already defined, before my copy becomes active, I have to explicitly
(load-library "minibuffer").
--
Matt McClure
http://matthewlmcclure.com
http://www.mapmyfitness.com/profile/matthewlmcclure
next prev parent reply other threads:[~2013-08-20 2:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-14 13:06 TRAMP: Host name must not match method Matt McClure
2013-08-16 13:15 ` Michael Albinus
2013-08-17 17:18 ` Matt McClure
2013-08-17 17:41 ` Matt McClure
2013-08-19 10:25 ` Michael Albinus
2013-08-19 12:07 ` Michael Albinus
2013-08-20 2:38 ` Matt McClure [this message]
2013-08-20 10:06 ` Michael Albinus
2013-08-27 20:01 ` Matt McClure
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJELnLEQ4b66VEdgN4WrZHaig0T5CL3curAJYNBF+_3Y5tVMOQ@mail.gmail.com \
--to=matthewlmcclure@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=michael.albinus@gmx.de \
--cc=tramp-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).