From: Darren Hoo <darren.hoo@gmail.com>
To: "Eli Zaretskii" <eliz@gnu.org>, "Jan Djärv" <jan.h.d@swipnet.se>,
yandros@mit.edu
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: Input for TTY menus
Date: Sun, 20 Oct 2013 02:58:53 +0800 [thread overview]
Message-ID: <CAJ+QY_F0QP_90t_=UX3u0G_ZZc9jG-yLoNPAGGDPs3ov0Zi02g@mail.gmail.com> (raw)
In-Reply-To: <83y55qn1dz.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 2462 bytes --]
On Fri, Oct 18, 2013 at 9:40 PM, Eli Zaretskii <eliz@gnu.org> wrote:
> What about my questions about the "Services" menu? I don't think you
> answered those.
Thanks chad for explaining what services menu for me.
Jan,
your 114716 commit totally removes the services menu. But I think some GUI
users may use it, I sometimes use it while not quite often.
How about bring it back? I have tested the following patch on OSX,
While I tried Emacs on GNUStep it crashes , but I don't think the crash is
related to this.
I am curious that how many users use Emacs on GNUStep nowadays?
=== modified file 'lisp/menu-bar.el'
--- lisp/menu-bar.el 2013-10-19 08:35:51 +0000
+++ lisp/menu-bar.el 2013-10-19 18:14:38 +0000
@@ -45,16 +45,24 @@
;; The symbol used to be called `help', but that gets confused with the
;; help key.
(setq menu-bar-final-items '(help-menu))
- (if (eq system-type 'darwin)
- (setq menu-bar-final-items '(buffer services help-menu))
- (setq menu-bar-final-items '(buffer services hide-app quit))
- ;; Add standard top-level items to GNUstep menu.
- (bindings--define-key global-map [menu-bar quit]
- '(menu-item "Quit" save-buffers-kill-emacs
- :help "Save unsaved buffers, then exit"))
- (bindings--define-key global-map [menu-bar hide-app]
- '(menu-item "Hide" ns-do-hide-emacs
- :help "Hide Emacs"))))
+ (if (eq window-system nil)
+ ;; No services menu in text-mode.
+ (if (eq system-type 'darwin)
+ (setq menu-bar-final-items '(buffer help-menu))
+ (setq menu-bar-final-items '(buffer hide-app quit)))
+ ;; We still want to use service menu in GUI.
+ (if (eq system-type 'darwin)
+ (setq menu-bar-final-items '(buffer services help-menu))
+ (setq menu-bar-final-items '(buffer services hide-app quit))
+ ;; Add standard top-level items to GNUstep menu.
+ (bindings--define-key global-map [menu-bar quit]
+ '(menu-item "Quit" save-buffers-kill-emacs
+ :help "Save unsaved buffers, then exit"))
+ (bindings--define-key global-map [menu-bar hide-app]
+ '(menu-item "Hide" ns-do-hide-emacs
+ :help "Hide Emacs")))
+ (bindings--define-key global-map [menu-bar services] ; Set-up in
ns-win.
+ (cons "Services" (make-sparse-keymap "Services")))))
;; This definition is just to show what this looks like.
;; It gets modified in place when menu-bar-update-buffers is called.
[-- Attachment #2: Type: text/html, Size: 5537 bytes --]
next prev parent reply other threads:[~2013-10-19 18:58 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-19 13:38 Input for TTY menus Eli Zaretskii
2013-09-19 13:52 ` Masatake YAMATO
2013-09-19 14:33 ` Stefan Monnier
2013-09-19 15:47 ` Eli Zaretskii
2013-09-19 19:21 ` Stefan Monnier
2013-09-23 13:18 ` Eli Zaretskii
2013-09-23 14:43 ` Stefan Monnier
2013-09-21 14:56 ` Eli Zaretskii
2013-10-17 5:34 ` Darren Hoo
2013-10-17 15:49 ` Eli Zaretskii
2013-10-18 4:55 ` Darren Hoo
2013-10-18 6:49 ` Eli Zaretskii
2013-10-18 7:37 ` Darren Hoo
2013-10-18 9:13 ` Eli Zaretskii
2013-10-18 10:39 ` Darren Hoo
2013-10-18 13:38 ` Eli Zaretskii
2013-10-18 13:40 ` Eli Zaretskii
2013-10-19 18:38 ` Darren Hoo
2013-10-19 18:58 ` Darren Hoo [this message]
2013-10-19 19:07 ` Darren Hoo
2013-10-20 9:32 ` Jan Djärv
2013-10-18 14:11 ` Eli Zaretskii
2013-10-18 15:12 ` Stefan Monnier
2013-10-18 15:28 ` Eli Zaretskii
2013-10-18 18:17 ` Stefan Monnier
2013-10-19 8:40 ` Eli Zaretskii
2013-10-19 13:45 ` Stefan Monnier
2013-10-18 17:41 ` chad
2013-10-18 17:43 ` chad
2013-10-18 18:14 ` Eli Zaretskii
2013-10-18 19:26 ` Jan Djärv
2013-10-18 20:04 ` Stefan Monnier
2013-10-19 7:35 ` Eli Zaretskii
2013-10-19 9:43 ` Eli Zaretskii
2013-10-19 13:40 ` Stefan Monnier
2013-10-19 14:45 ` Eli Zaretskii
2013-10-19 15:25 ` Stefan Monnier
2013-10-19 16:32 ` Eli Zaretskii
2013-10-19 8:58 ` Jan Djärv
2013-10-19 9:01 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJ+QY_F0QP_90t_=UX3u0G_ZZc9jG-yLoNPAGGDPs3ov0Zi02g@mail.gmail.com' \
--to=darren.hoo@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=jan.h.d@swipnet.se \
--cc=yandros@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).