From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Aaron Jensen Newsgroups: gmane.emacs.devel Subject: Re: input-pending-p after make-frame-visible Date: Wed, 20 Oct 2021 14:55:05 -0400 Message-ID: References: <6c69780538e1957d1002@heytings.org> <322f50be-0de1-c818-819d-6ecb400de928@gmx.at> <03ab7a19-6616-445c-cdcf-588fb30a514a@gmx.at> <3205a073-a6ca-b9a5-3834-929025b70b7b@gmx.at> <83wnm7absp.fsf@gnu.org> <83r1cfa92p.fsf@gnu.org> <83mtn3a71c.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9546"; mail-complaints-to="usenet@ciao.gmane.io" Cc: martin rudalics , Alan Third , Gregory Heytings , YAMAMOTO Mitsuharu , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Oct 20 21:04:55 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mdGtS-0002Gu-RJ for ged-emacs-devel@m.gmane-mx.org; Wed, 20 Oct 2021 21:04:54 +0200 Original-Received: from localhost ([::1]:51034 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mdGtR-0001S6-Ij for ged-emacs-devel@m.gmane-mx.org; Wed, 20 Oct 2021 15:04:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56512) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mdGkE-00060Q-Il for emacs-devel@gnu.org; Wed, 20 Oct 2021 14:55:22 -0400 Original-Received: from mail-pg1-x530.google.com ([2607:f8b0:4864:20::530]:42522) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mdGkC-0005pk-9C; Wed, 20 Oct 2021 14:55:22 -0400 Original-Received: by mail-pg1-x530.google.com with SMTP id t7so8894921pgl.9; Wed, 20 Oct 2021 11:55:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ytpL9Mz5zgaklsFcpVsEno1Vn5BQSaVZF+GqiUt1Twk=; b=ZPRx89pZMIgCjVHs65RR0G2wIn7umKW+cJKLUGDvOnU6CMCNYy2KUj3OC+DzLzqVg/ TWtkoSXXxKq52Tm1I4rDDi+ITKwG9aJxaLb2/cfWoaghnT4AIZxf3Cvp3t2llBYcW/P0 TAAGU3nbIwPlKll7olgTAWusFhan4Qu1f5vsu5Hi6xf4N+vUmnINZaVKbxl8ciqaqOaZ iDW99LMefBdqGDFYBAkrrxfpnFAatT41+Qe0Z5oK6aejqN9HfxFbnJ9rojU3VrPPl/xs lA45zJiUv6vfqfw7dbsKxFI2JkwPxh1IVKcqxXiZDSBAd5/y0PmjqiNnLFA/pobOSJnc mOrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ytpL9Mz5zgaklsFcpVsEno1Vn5BQSaVZF+GqiUt1Twk=; b=csvONnvia7b+Kvs5FlMAH/tPR1HprSOpZJjUP3OUQzaEcMJbx269JasWIqbqCbH83p LAMgxg9qshoRPxijxYNdKCIGO6BpEYrq6NWaN5r6PVZsnViv5PRou5SX5xfV4lFoyFHz c5VKBnyw2GEWU68ItVyVm9detbHJgyEFqZDXrNjlqDlO6hW3z+eN/nxvSs/Gz+XNCr01 DZxOjeJIOjmHf1zsVTX3LSO9AW9p1yi3QFALKSriJmoXBWHHRaNsIJtFbXftAFDRE8mN DodhwmGiMOpyKgP/BRzNS7yrGRGxUiQnOuKoX9TdSQM3bV1SW6FJPrwPQq8Ns5GilpvC ZwNw== X-Gm-Message-State: AOAM531gdGQ+2t2onxRcOTwd5acxkxGPLpFsJaan8HWoMJtmW5NLndgR 934e0xB47g6z1nWB5PrEV9MQJuopbZKSJnVrRnR/F9qcXxg= X-Google-Smtp-Source: ABdhPJxfbw4wV/WbZaD40ORwJJyi95ZeWWE8XSZuggfaPjgXJ3yJ76zMlbQD604AUfdr83i+tlIQcu547/hZ8YudDGc= X-Received: by 2002:a62:ce07:0:b0:44c:fef2:e410 with SMTP id y7-20020a62ce07000000b0044cfef2e410mr623077pfg.71.1634756117524; Wed, 20 Oct 2021 11:55:17 -0700 (PDT) In-Reply-To: <83mtn3a71c.fsf@gnu.org> Received-SPF: pass client-ip=2607:f8b0:4864:20::530; envelope-from=aaronjensen@gmail.com; helo=mail-pg1-x530.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:277465 Archived-At: On Wed, Oct 20, 2021 at 2:24 PM Eli Zaretskii wrote: > > > From: Aaron Jensen > > Date: Wed, 20 Oct 2021 13:47:57 -0400 > > Cc: martin rudalics , Alan Third , > > Gregory Heytings , emacs-devel@gnu.org, > > YAMAMOTO Mitsuharu > > > > > Yes. But the change you propose is in readable_events, a function > > > that has many more callers than just input-pending-p. In particular, > > > one of its callers is kbd_buffer_get_event, which is the API through > > > which Emacs reads all of its input. And now, under some > > > circumstances, that API will ignore some events. That's scary, at > > > least for me. > > > > AFAICT kbd_buffer_get_event calls `readable_events (0)' only, which > > will disregard any of the code I changed or added. The > > READABLE_EVENTS_FILTER_EVENTS must be set for it to come into play. > > Only input-pending-p sets that flag AFAICT. > > I don't see how this helps: who will remember that no caller of > readable_events can ever use that flag without invoking this behavior > whose justification we don't understand? Which behavior are you saying the justification is not understood? If it's the behavior I introduced, it should be understood as it is understandable. It is there so that the flag READABLE_EVENTS_FILTER_EVENTS can be actually respected instead of partially respected. Previously, that flag was only respected if USE_TOOLKIT_SCROLL_BARS was set and the event was focus in or focus out. That was not the sum total of events that we want to ignore, I believe. That is determined by while-no-input-ignore-events. > > > No, that must be a variable exposed to Lisp, so users could fiddle > > > with it without rebuilding. > > > > Ah, I believe that variable exists already and can affect everything I > > changed other than the reliance on USE_TOOLKIT_SCROLL_BARS: > > while-no-input-ignore-events > > No, it must be a separate variable, because it's for people who do > have non-nil while-no-input-ignore-events. Ok, let's see if we can get to where we are comfortable without this first.