From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Aaron Jensen Newsgroups: gmane.emacs.devel Subject: Re: 4dc72dd9deb1c3394ada3de3f52bc7c1ff831ab6 breaks make check Date: Sat, 16 Jan 2021 00:38:37 -0600 Message-ID: References: <5a359bd86b4af0378ed63f12670fd355@finder.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7989"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Jared Finder , Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jan 16 07:39:55 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l0fFa-0001zv-F7 for ged-emacs-devel@m.gmane-mx.org; Sat, 16 Jan 2021 07:39:54 +0100 Original-Received: from localhost ([::1]:47324 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l0fFZ-0002c9-Do for ged-emacs-devel@m.gmane-mx.org; Sat, 16 Jan 2021 01:39:53 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50476) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l0fEe-0002C8-00 for emacs-devel@gnu.org; Sat, 16 Jan 2021 01:38:56 -0500 Original-Received: from mail-yb1-xb31.google.com ([2607:f8b0:4864:20::b31]:34847) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l0fEb-0006KP-Ua; Sat, 16 Jan 2021 01:38:55 -0500 Original-Received: by mail-yb1-xb31.google.com with SMTP id k132so112489ybf.2; Fri, 15 Jan 2021 22:38:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/MKNlN/S73KGedEk/CmiZqnTlfU64YSofW0apSTy0YM=; b=ZHfFkwMQ8A3YIkGMpKPWLmFal1FJredOPNYt+gP7K2kzKBFv7mdIcynR8MCGbVRbSS X1Nrh1fvmPkB4DtLkQFUVYiX5v7jhurU4yZ9GAV0NHBwV+I5IB2/gZHpR8IkFkHwD6c5 T1XtU4tItuvQ7wmCmsaeZ6WQ/VMSkfUc+M682rgIBUU/1kn7um4hH+H6iNo/RWk8pXCP iibNIp7teLJBl12csnpQYFLZUH3jiCb4zALAgd2Isy9YpNTCuWRM44+75QG2XX3rsE/E Omb2f060NBzas1ZX3tuiWYQHuYf69SUrG/SM0tGBnFVRJqXy8SPWw1VhSPD5FFrSbRKR NLTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/MKNlN/S73KGedEk/CmiZqnTlfU64YSofW0apSTy0YM=; b=Go6V9nmu1tzUYkpQ/qUb2CTLKFL4KUdTUSk64NO3P7aHGvIkSYU7MiCHaMvZyj1kqi bx+H/SSCxlp0i/ja2YoXAx562ZS0CLsCNgQ2QzgjeNoJNufwSBWp04fuEjPhd2tWCEqR /Uh58yIEHAIhkPHJJXnHveib5p36y7YJz9SjOhcws8kmtPh2pfWaRAQ6ACG3mwsDwOHH i/QJTCFRj/F02RkJiG6KnFx/wfolOH7H/OWUjhIc14JoaKdOH5PHgtERDXIQ52iNrf6J vn2ClL139nolmE9Yjo8jyIgP9NhuiVNdTTfMbToJIXcJmEuqQqLCiHgZPFoBnNcMfciz e4iQ== X-Gm-Message-State: AOAM530mt7PTi8oVxv9o+pC2uz7NZpBoOIaRG7mRZBMnnpNm84u5JDF9 C7D9g1pu1RZvxYMrT4jXhnntDwWHOVIlwMnIuJk= X-Google-Smtp-Source: ABdhPJzKKVHsH6RBGmuJjC9YJgzBsz2PUP0tpkSkISz2ciTcs7MOKcA7dQHLljVl0Z7o2JJkfcbdcrQd1MQQKVLyx8Y= X-Received: by 2002:a5b:2cf:: with SMTP id h15mr23099207ybp.475.1610779128548; Fri, 15 Jan 2021 22:38:48 -0800 (PST) In-Reply-To: <5a359bd86b4af0378ed63f12670fd355@finder.org> Received-SPF: pass client-ip=2607:f8b0:4864:20::b31; envelope-from=aaronjensen@gmail.com; helo=mail-yb1-xb31.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:263091 Archived-At: On Sat, Jan 16, 2021 at 12:33 AM Jared Finder wrote: > > "4dc72dd9deb1c3394ada3de3f52bc7c1ff831ab6 Fix 'window-text-pixel-size' > when there are leading/trailing spaces" adds some tests that don't run > correctly in my environment. The tests do run fine interactively. > Yes, Eli mentioned this in the bug thread. I don't know how to make these tests pass in batch mode. I modified it to something that seems like it should pass in batch mode, but I get a size of 0x0, which isn't what I'm going for. This is what I tried: (ert-deftest xdisp-tests--window-text-pixel-size () ;; bug#45748 (with-current-buffer-window "*test*" 'display-buffer-same-window nil (erase-buffer) (insert "xxx") (let* ((char-width (frame-char-width)) (size (window-text-pixel-size (get-buffer-window) t t))) (should (equal (/ (car size) char-width) 3))))) Eli mentioned moving the tests to manual/redisplay-testsuite.el, which is fine. If anyone else has an idea how to make this test work in batch mode, I'm all ears. Thanks, Aaron