From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Aaron Jensen Newsgroups: gmane.emacs.devel Subject: Re: macOS metal rendering engine in mac port Date: Sat, 29 May 2021 01:52:35 -0700 Message-ID: References: <83k0ni6pje.fsf@gnu.org> <83eedq6mvm.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21312"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Alan Third , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat May 29 10:53:25 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lmuij-0005Oh-Ki for ged-emacs-devel@m.gmane-mx.org; Sat, 29 May 2021 10:53:25 +0200 Original-Received: from localhost ([::1]:59644 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lmuih-00041p-OU for ged-emacs-devel@m.gmane-mx.org; Sat, 29 May 2021 04:53:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59568) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lmuiB-0003NG-36 for emacs-devel@gnu.org; Sat, 29 May 2021 04:52:51 -0400 Original-Received: from mail-pl1-x633.google.com ([2607:f8b0:4864:20::633]:39456) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lmui9-0000ha-BN; Sat, 29 May 2021 04:52:50 -0400 Original-Received: by mail-pl1-x633.google.com with SMTP id q16so2758084pls.6; Sat, 29 May 2021 01:52:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ojnv1XpyiZhUpyiQFE8qmAopiKZrtBbQxaPTtibzMAo=; b=kSk7BC+E0vtOamFpwpuzp3hORX/LoYkfZ5njB/IjgyrF6EbK6eCnVj/1b4/MWDeDTR 64EIUPhFreZaG9NXi8a14OQ5b9UssFYGaCyY9WIN1uTEfx+R3lQTqh/vc9YgdUxcVoc/ ztQZAqmUDO/aoveAbmEQDdGh899KzKI6EXCHHocXdLRpRmv0P2qXhpJ3aXZy5AyKG3Fp LqcM5xg+BI5QLZ0djmGFvU040J2McRRVNNXBCkmZzOK5RdL6iMVFxzrMr5xHVCpwgUu1 cR7aIzA2Sh3axFDdUW6nAvsuf5/8K5cu9UVDtEaibV4rvsCXNo5KxHfZpEtCnxZNebcm kL3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ojnv1XpyiZhUpyiQFE8qmAopiKZrtBbQxaPTtibzMAo=; b=mnIz6bJgHpmAhKfy6fZipzL4nSXBORCWWeMFdvEs2q+8f4kXB2F1E0xID4PTfQOBNH xXLCdfqIgRvNZ364OfWVnSEmQAdn6FUnQcf7xegri0SBVzReVfSvKea8ec5Nj2Mm0eHF Q3FnJSd15w9mmoMj6rvAjY4N2o6soGl3urClSOpErUXp0TGLyFmDuhwH2UphSpd4VmdB kxLb5Xza0iweTm3yCQ8atRNRmZDzEQIWZqlagtOffJz6JvUOtk9Exdn3HNshYyFtaE5K UrfkEu0HFFJVRsRJW8vWx3l6CEOmnUFkZzdSfYkG7MHoUXP4jlxemP55RFYboBhee18E 16Ew== X-Gm-Message-State: AOAM530LPdywxG3AaNMl3LkRhtok1XadRiIacJImQU4Gjhv8syFy/ddX rWK2qBLqGP9HnQFxYeeDmwwRHylu4Xc7mm1X7sGzArZrIa1t0A== X-Google-Smtp-Source: ABdhPJww/8K8p/iCisToJL3XxTr40PXh0w1eCdE/wk7l/aKD5WhvnzHkWp3GEX5/1z0pEYMR/9yVSi4RJhDh2/63wkQ= X-Received: by 2002:a17:902:b412:b029:ef:1737:ed with SMTP id x18-20020a170902b412b02900ef173700edmr12041806plr.43.1622278367212; Sat, 29 May 2021 01:52:47 -0700 (PDT) In-Reply-To: <83eedq6mvm.fsf@gnu.org> Received-SPF: pass client-ip=2607:f8b0:4864:20::633; envelope-from=aaronjensen@gmail.com; helo=mail-pl1-x633.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:270037 Archived-At: On Sat, May 29, 2021 at 12:05 AM Eli Zaretskii wrote: > > > From: Aaron Jensen > > Date: Sat, 29 May 2021 00:01:31 -0700 > > Cc: Alan Third , emacs-devel@gnu.org > > > > On Fri, May 28, 2021 at 11:07 PM Eli Zaretskii wrote: > > > > > > > From: Aaron Jensen > > > > Date: Fri, 28 May 2021 15:07:27 -0700 > > > > > > > > Eli, could you link me to the merge_face_ref optimization discussion > > > > so I could follow along please? > > > > > > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=41200 > > > > Thank you. Wow, that seems to make a huge difference in typing latency feel. > > In "emacs -Q" as well? If so, it again puzzles me how face merging > has such a profound effect on redisplay in your case. It shouldn't. emacs -Q never really felt slow in terms of typing latency. In terms of the scroll benchmark, I got: w/o patch: 26.8s first run, 3.84s second run w/ patch: 25.1s first run, 3.6s second run With my emacs config that has, with everything loaded, 1156 faces, I get: w/o patch: 18.6s on second run (at least 9s of which are attributed to TAGGEDP and CONSP from lface_from_face_name_no_resolve) w/ patch: 6.1s on second run The impact is drastic. One thing about my config is I eager load all of the packages I have installed on idle, so I end up with all of their faces in my face list. I don't have a massive config (147 packages, it looks like), but it's apparently big enough.