From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Aaron Jensen Newsgroups: gmane.emacs.devel Subject: Re: nativecomp and throw/catch across files Date: Thu, 18 Feb 2021 02:36:50 -0600 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21615"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Andrea Corallo Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Feb 18 09:38:25 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lCepN-0005Wx-GI for ged-emacs-devel@m.gmane-mx.org; Thu, 18 Feb 2021 09:38:25 +0100 Original-Received: from localhost ([::1]:43460 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lCepM-0001Mb-DS for ged-emacs-devel@m.gmane-mx.org; Thu, 18 Feb 2021 03:38:24 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56258) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lCeo4-0000hf-VQ for emacs-devel@gnu.org; Thu, 18 Feb 2021 03:37:05 -0500 Original-Received: from mail-yb1-xb2e.google.com ([2607:f8b0:4864:20::b2e]:32890) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lCeo3-00079y-6P for emacs-devel@gnu.org; Thu, 18 Feb 2021 03:37:04 -0500 Original-Received: by mail-yb1-xb2e.google.com with SMTP id x19so1416670ybe.0 for ; Thu, 18 Feb 2021 00:37:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1qAeOObu2FEeMtdksVmCEWfZhlYyhFDDx3NYOXy5l10=; b=MOoXlyRtNCOrDp/uNiLYOcLiBkJNbmKv7m8nmJym5GfdkNf12ygakKEyVtZby7bYQo q/RHsHTqGTiLa1xzNfJB90ie+tYqq3Ywz9OOnFAhzanLvM4k8XThKkWct4Dwji2qRaqr VqAJeqQOQObh2wPCx/fVudF8p/yO4Ga8cKdnmIpkgju0bkUEGZEZ4peYIOSYTFOS3Z3x QrGjjWqbwqXNWy1//sqYBRlNPtPllusBGldxTuXkEDBh3TWyajA8kGQQKK3ypFdt5WBd U8B5HxuHPJNJN6GT+je6tHm6UR0CBu9QzKdpob4yWjZrMRHWvXdLeOjnx51oXFnE04P4 t/AQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1qAeOObu2FEeMtdksVmCEWfZhlYyhFDDx3NYOXy5l10=; b=eMQ4KL35PV4rsJzihvrtgZRAyEpG9kasXeH7bWkgClyOGT9XpPiu8v6EgMYNYGuzLP vNFMtZOB5NdcP0DDX5tS806vEhEq52Hj2rZ9kCxV8IxJQj9fDVNwjjhuZCH2fZ6AdsKE 0780tFoxUJffwT1s+L1YC2CZhQa7KXfrR4pTAmJ7s/I08V68dhUyu25qUHc/N382j6vN 2AxG2wvbCpqa7XflROno8ZGPjj3xRv1GkwccisJwTfMApnmoGbilnWxsNzMBLYiZIYkl yZ9aQp1MqBzD5aJ3JBBUZ9p8lw7kwrZ6EBEaRbWHXfiqbNxK80H639D2F9lMs2lSQ/LQ PTUA== X-Gm-Message-State: AOAM533ggOVFxGXvkHN3SpcdsIfjlt1+sYGOQLQ9KGKPq5Ro4QG6nBVL qDBCKuGSKqm/ECge12WowV4Nr5CHSJ5nqtOWC9YCIDJXv8EWgA== X-Google-Smtp-Source: ABdhPJw5pspCUlYB/FIZ33JGYVznEd2+m8Qf/wnVgQII5JyOAgqS+L4pjcKhMLI/hrQhEqyz1Cofbyr/QPpqeh+2toQ= X-Received: by 2002:a25:d28b:: with SMTP id j133mr4770723ybg.517.1613637421874; Thu, 18 Feb 2021 00:37:01 -0800 (PST) In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::b2e; envelope-from=aaronjensen@gmail.com; helo=mail-yb1-xb2e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:265129 Archived-At: On Thu, Feb 18, 2021 at 2:06 AM Andrea Corallo wrote: > > Hi Aaron, > > is there a corresponding issue open in straight? Perhaps straight > developers can narrow down the issue and suggest a minimal reproducer in > case this is a real issue on our side. Reported here: https://github.com/raxod502/straight.el/issues/697 I believe the issue is that in the case that the version changes, the throw works and the catch works. However, immediately after that, they byte-compile straight.el and then attempt to load the elc. However, because there's an eln, the eln is preferred and it throws again because it wasn't rebuilt. If I rebuild the eln as well, it works as expected. https://github.com/raxod502/straight.el/blob/2d407bccd9378f1d5218f8ba2ae85c6be73fbaf1/bootstrap.el#L62-L65 Would it make sense to somehow invalidate the eln if the elc is recompiled on the emacs side? Or should straight detect native-compile and run it as well as byte-compile-file in this scenario? Thanks, Aaron