From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Aaron Jensen Newsgroups: gmane.emacs.devel Subject: Re: input-pending-p after make-frame-visible Date: Wed, 20 Oct 2021 13:15:21 -0400 Message-ID: References: <6c69780538e1957d1002@heytings.org> <322f50be-0de1-c818-819d-6ecb400de928@gmx.at> <03ab7a19-6616-445c-cdcf-588fb30a514a@gmx.at> <3205a073-a6ca-b9a5-3834-929025b70b7b@gmx.at> <83wnm7absp.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23052"; mail-complaints-to="usenet@ciao.gmane.io" Cc: martin rudalics , Alan Third , Gregory Heytings , YAMAMOTO Mitsuharu , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Oct 20 19:17:15 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mdFDG-0005nn-K4 for ged-emacs-devel@m.gmane-mx.org; Wed, 20 Oct 2021 19:17:14 +0200 Original-Received: from localhost ([::1]:56224 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mdFDF-0008Q3-LF for ged-emacs-devel@m.gmane-mx.org; Wed, 20 Oct 2021 13:17:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33360) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mdFBj-0007bK-1J for emacs-devel@gnu.org; Wed, 20 Oct 2021 13:15:40 -0400 Original-Received: from mail-pj1-x102f.google.com ([2607:f8b0:4864:20::102f]:34750) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mdFBh-0005hi-BV; Wed, 20 Oct 2021 13:15:38 -0400 Original-Received: by mail-pj1-x102f.google.com with SMTP id q2-20020a17090a2e0200b001a0fd4efd49so4147510pjd.1; Wed, 20 Oct 2021 10:15:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/LMKTU+54Nm0uEQ4vP6I/XsqTwKFP5+K8h4SQ20PSJE=; b=jbYXoaT5aClogAy95oy7Zvd/DuIb1b/Cb3GrKDpPAGfuI8PRqgLUBSsNpeuUEKNkCq z1D4p4eyVCnc8Q0Yr1nFaDgWpbED6LC75hPxPP4EAvNKbe6LnI8YFq90DwGF7++51rNg Jr9q/qzgtemVnB8vwimxGRJX43plgx9gCw1cHpITkMQ7lP968JHqU41bTtYULWL1bOo+ znsGpLbm638HlcpdA+ldjUeC3Ilr/HcXRQFe14z6CK2U7nygoLYQ4KP10kVveix9sKPA HVvybgrO/8R6PDxJPlnnMCd0/osbYUhTFLpqmynTFewtLFcnwk1e/JWiZQwGzfMuzn+v eApA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/LMKTU+54Nm0uEQ4vP6I/XsqTwKFP5+K8h4SQ20PSJE=; b=o1dnLzuaNL3Ww8MvffpXgDfeHq+MyvcgGYloboKYoGCPJ8IXK0djO+OS2BIzukqsOV 4war+xeDCidDIS9nOXhLljYWqxVlHg05/KUMyoj5LyOQW7cBG/TvUra97GnUgbdBOxfH sB88wTVeK0oqKeV3477WDQ+7gd2m7E4C8q30wE6nMTZ2mkdV8jzoxxyt12cIm32KOQAN O0eaMYFhxGDuon38G76KFXBrongMfeg2Dfv2vVSwAHzZHxzmd1Ol6GvQ0PWSXSk1yjB1 wYxoDusB3ooKj6k45oZP/VK49pXqXveJQNMTkcTYLls9snsU8jWFSt2U2HBbaRnH+qns Hgfw== X-Gm-Message-State: AOAM532riSeMusOyiPtJvtCXOP1MgBlrcfBAaJHdDIOjmfXlxQPPgS3K FWovqsf7TXWdcp7JvLCPDQDrCJm62EPu+h/XcDU/YMUxtkk= X-Google-Smtp-Source: ABdhPJwe3rpsTgBveSNSbLHUuXRtZ9/ae57fTQR2MGPvHZd3tWYvVtyewr1ayPjC65einOJ4V8xYeiQyedQlGorhMFE= X-Received: by 2002:a17:902:7616:b0:13f:354a:114f with SMTP id k22-20020a170902761600b0013f354a114fmr363562pll.8.1634750132672; Wed, 20 Oct 2021 10:15:32 -0700 (PDT) In-Reply-To: <83wnm7absp.fsf@gnu.org> Received-SPF: pass client-ip=2607:f8b0:4864:20::102f; envelope-from=aaronjensen@gmail.com; helo=mail-pj1-x102f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:277458 Archived-At: On Wed, Oct 20, 2021 at 12:41 PM Eli Zaretskii wrote: > > > From: Aaron Jensen > > Date: Wed, 20 Oct 2021 11:27:38 -0400 > > Cc: Alan Third , Gregory Heytings , Eli Zaretskii , > > emacs-devel@gnu.org > > > > Any concerns with installing the attached? > > Yes: I don't think we understand what it will do, apart of fixing this > particular problem for you. The primary thing that it does is make input-pending-p respect while-no-input-ignore-events, which is necessary to make while-no-input fully respect while-no-input-ignore-events because it uses input-pending-p. It begs the question, should while-no-input-ignore-events be renamed, or should input-pending-p at least document that it respects while-no-input-ignore-events? It was apparently already the intent because input-pending-p passes READABLE_EVENTS_FILTER_EVENTS to get_input_pending. > The original code included conditions > that depend on use of the toolkit scroll bars (the reasons for which > we don't understand, AFAICT) and ignored just a small group of events, > now we will/might ignore much more, and that's in the main source of > reading events. Who knows what this will do. Yeah, that part is the biggest head scratcher to me. I wonder if Yamamoto Mitsuharu may know why this was added this way in 354344a20a06e2052bc23a4b92ac44af1075cdbe > > I _might_ be okay with installing this on master, conditioned on some > new variable, so that if some problem reveals itself, it would be easy > to see if it's due to this change. Okay, let's see if we get any more clarity first and then I can introduce a variable. What would you like to call it? And are you referring to a new ifdef check? Thanks, Aaron