From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Aaron Jensen Newsgroups: gmane.emacs.devel Subject: Re: macOS metal rendering engine in mac port Date: Sat, 22 May 2021 09:01:03 -0700 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16228"; mail-complaints-to="usenet@ciao.gmane.io" To: Alan Third , Aaron Jensen , emacs-devel@gnu.org, YAMAMOTO Mitsuharu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat May 22 18:07:16 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lkU9j-00042Y-QN for ged-emacs-devel@m.gmane-mx.org; Sat, 22 May 2021 18:07:15 +0200 Original-Received: from localhost ([::1]:51966 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lkU9i-0005CQ-Rf for ged-emacs-devel@m.gmane-mx.org; Sat, 22 May 2021 12:07:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52754) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lkU42-0007Bi-Gd for emacs-devel@gnu.org; Sat, 22 May 2021 12:01:26 -0400 Original-Received: from mail-pj1-x102f.google.com ([2607:f8b0:4864:20::102f]:53774) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lkU3z-0007BL-K7 for emacs-devel@gnu.org; Sat, 22 May 2021 12:01:22 -0400 Original-Received: by mail-pj1-x102f.google.com with SMTP id ot16so10574195pjb.3 for ; Sat, 22 May 2021 09:01:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=4uv/9J4nFPRiVOT22hECFSW5+nNGWR0pMpQjDjasRbk=; b=JjNztSSug1G8GTKfIoEL7GjxPZSig5Xi41edAUXe4kaToqjW+cNwxx5c3kG3Vny9oN IiIwzc/g/0CqTCx14FrbqgT/9tuEfukUdC53ruqAWy1IvHuN0qsR020k4rT9wwPIDOst z6YKVr5ihRYkoj4Hs2z9XZjjHpsJfyfBpGBEdUUzcnGTy5A5nh5eKN/wZK0jtxcjZsc7 mjRoUn9ehu3LYjJZJzbsdvy/o+0VDcUT9SV2YLEjfeJSh0ZhpBkwYNo5kiJPjOvFjfjG 1lavDuHVvn6+ls1yT6wv6tHi+kf2OmrDDS8hTxptjjUj7iAd/XIrJaMWqapwpi2U/c5E c93g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=4uv/9J4nFPRiVOT22hECFSW5+nNGWR0pMpQjDjasRbk=; b=MafVgOAAs7IZYNolFF7RuQWS/VZYshLTv4cbJnVOny2/OjMR7MVjgad8RKS4lyR2Lh xe0WfOTxheJiWGuJTtDhSFrYU3h8vTFh72qFu6L85lU3WTPlhzVAqaMN7Uun05kNoq2Y bJ5QC6pX9prdSDC39wgmVRvCEMTQX7+XVBRW7OqmSXTg1khAkYsVE7W6YlHBbkStGNov 2oBHRpSFHuTdpVu9CMVR/Ce1qqJ7LLLAIdEMBFPaMvJvpRLGoaoMQmeeztkxI+Cb3aJh M7I8rM2RCUBCOP5jvHaOKYuS3WUUskauzaZO1M6xbpeGQCQt0XYwIGgVOMYOhJRv0SZ8 S5hQ== X-Gm-Message-State: AOAM532gmqGtaYEQ/hgdmRVh5PlcjDzAvIdy2GWVaiQ9wgMONVe99xro beuJ5ij7QgV5vp4hQ0gI1ZPLXIXarC7jsNEA1CM= X-Google-Smtp-Source: ABdhPJy2vQmOXlRnopH3zph8bBOQ4fCWUpSFpUQ3fRavpFQcW3gmH9E8NQXjuW3eT+r+iLsz68b6RQircCrzA72wnG0= X-Received: by 2002:a17:90a:e50b:: with SMTP id t11mr16421716pjy.181.1621699274458; Sat, 22 May 2021 09:01:14 -0700 (PDT) In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::102f; envelope-from=aaronjensen@gmail.com; helo=mail-pj1-x102f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269615 Archived-At: While profiling this, many signs point to line number display being a hot spot when display-line-numbers-mode is enabled. Specifically, maybe_produce_line_number calling merge_faces. Ultimately, most of the time is spent in TAGGEDP which is called by CONSP in assq_no_quit. Here's a reverse tree: https://cln.sh/nLrew6 Is there anything that can be done for caching the merged face? Surely it doesn't change in a tight loop, but maybe I'm misunderstanding the code. Thanks, Aaron