From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Pete Williamson Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] for review - making use of {EXEEXT} more uniform in makefiles. Date: Mon, 23 Feb 2015 09:55:40 -0800 Message-ID: References: <54E79986.4000909@cs.ucla.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=001a11333c944496d9050fc51c0f X-Trace: ger.gmane.org 1424714160 13394 80.91.229.3 (23 Feb 2015 17:56:00 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 23 Feb 2015 17:56:00 +0000 (UTC) Cc: Michal Nazarewicz , emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Feb 23 18:55:54 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YPxEX-0006Pn-Ht for ged-emacs-devel@m.gmane.org; Mon, 23 Feb 2015 18:55:53 +0100 Original-Received: from localhost ([::1]:44820 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YPxEX-0006qY-2R for ged-emacs-devel@m.gmane.org; Mon, 23 Feb 2015 12:55:53 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41870) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YPxET-0006qT-1W for emacs-devel@gnu.org; Mon, 23 Feb 2015 12:55:50 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YPxEM-0006JX-Td for emacs-devel@gnu.org; Mon, 23 Feb 2015 12:55:48 -0500 Original-Received: from mail-pa0-x22b.google.com ([2607:f8b0:400e:c03::22b]:39296) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YPxEM-0006JN-D0 for emacs-devel@gnu.org; Mon, 23 Feb 2015 12:55:42 -0500 Original-Received: by pablf10 with SMTP id lf10so29261147pab.6 for ; Mon, 23 Feb 2015 09:55:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=Hz3TcHMrU88YWqn5WxPFCeoRLFYUahxu/uTtcb9zcJg=; b=hGE7Nq3YQ2mt9YabOz/4Af4fL9KKsrdwxVkrjbGFYzZaFB6+kPH2fgK9gcWAjuR+MP HSfVYTbRMp2e3p3NjCDEi3N0LSmP86kfmuVkYrAA54Z2nEGP2lFLQYcTp/JfJ9JwY0UX BMDHYtz0r0U2069ADwYxZnVIvNoyq80R3DLINbbzJWuB9ES94jfXbdANhKJfNv0EtKMJ CcONNVeimehun3+aW5ZBESw7xxQTxUei+f7eEBikaLh5l09vC7g2pXYTTC3iQnCaLqYv wPzk3pNK9ZztQKSDvj+IiIQf4NZfc9mcyxVxIJPIzRxCnJfz/nA5HILkYycCkMNOpSzD sqPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=Hz3TcHMrU88YWqn5WxPFCeoRLFYUahxu/uTtcb9zcJg=; b=mLTZfMWGqXCAtgWa6GPHqSDSVwYga91n/X2n/Ms+ZyGgNgxuF0esUC1PfweGizn/hi f64J/ZYIgrWrLze377KaEyZRc9bXUjWfdXgAwEQ/nA+Wxe6Y8z0yPk6SzZShFSIhjzFt Ec9+sNPTDqfTmoqdi6dJ26X0AdzEwisUsRctgQ6nscezL8qYXHxosPOeFlStahfVu9d9 eSZCJg4o6d/un7jiRBIjZXTKOo/TaPHys/3OobfQmK3IGtJ4Ftv9KRcIMIvWm0R3/UhM V+vfRbWH9dMj1zZPl01nM86JH1wThN2g+POXU4z1jGj9VKJyHGgGDejgANrQw+iQESa/ 7fXg== X-Gm-Message-State: ALoCoQmOEkV1KgkQ9mG05ZmxHqhKz/MTWQtTFenJXjratESk8q57srN/lSz493/A6N/n7C8mgD/Q X-Received: by 10.67.8.73 with SMTP id di9mr20658525pad.107.1424714140762; Mon, 23 Feb 2015 09:55:40 -0800 (PST) Original-Received: by 10.70.46.161 with HTTP; Mon, 23 Feb 2015 09:55:40 -0800 (PST) In-Reply-To: <54E79986.4000909@cs.ucla.edu> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:400e:c03::22b X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:183423 Archived-At: --001a11333c944496d9050fc51c0f Content-Type: multipart/alternative; boundary=001a11333c944496cb050fc51c0d --001a11333c944496cb050fc51c0d Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Here is a single combined patch, with a change log entry. Thanks, Paul for your comments! All comments welcome! On Fri, Feb 20, 2015 at 12:31 PM, Paul Eggert wrote: > Michal Nazarewicz wrote: > >> Unless there are some concerns I=E2=80=99ll push the fixed patch on Mond= ay. >> > > It's missing a ChangeLog entry and a commit message. Could you please > construct a single combined patch (rather than two), and generate it with > the command 'git format-patch', and attach it to a followup email? For = an > example of an email containing such a patch, please see: > > http://lists.gnu.org/archive/html/emacs-devel/2015-01/msg00909.html > --001a11333c944496cb050fc51c0d Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Here is a single combined patch, with a change log entry.<= div>
Thanks, Paul for your comments!=C2=A0 All comments welco= me!



<= div class=3D"gmail_quote">On Fri, Feb 20, 2015 at 12:31 PM, Paul Eggert <= eggert@cs.ucla.edu> wrote:
= Michal Nazarewicz wrote:
Unless there are some concerns I=E2=80=99ll push the fixed patch on Monday.=

It's missing a ChangeLog entry and a commit message.=C2=A0 Could you pl= ease construct a single combined patch (rather than two), and generate it w= ith the command 'git format-patch', and attach it to a followup ema= il?=C2=A0 =C2=A0For an example of an email containing such a patch, please = see:

http://lists.gnu.org/archive/html/emacs-devel= /2015-01/msg00909.html

--001a11333c944496cb050fc51c0d-- --001a11333c944496d9050fc51c0f Content-Type: text/x-patch; charset=UTF-8; name="0001-Use-EXEEXT-more-uniformly-in-makefiles-when-running-.patch" Content-Disposition: attachment; filename="0001-Use-EXEEXT-more-uniformly-in-makefiles-when-running-.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_i6i5zrvv0 RnJvbSAxZjIxMzNjYThhOTY4YTQwYTA0MjE2YmZmYmJiYmNlYmViZTJjNzJiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRlIFdpbGxpYW1zb24gPHBldGV3aWxAY2hyb21pdW0ub3Jn PgpEYXRlOiBGcmksIDIwIEZlYiAyMDE1IDE3OjQ0OjQyIC0wODAwClN1YmplY3Q6IFtQQVRDSF0g VXNlIHtFWEVFWFR9IG1vcmUgdW5pZm9ybWx5IGluIG1ha2VmaWxlcyB3aGVuIHJ1bm5pbmcKIGV4 ZWN1dGFibGVzLgoKV2hlbiBwb3J0aW5nIEVtYWNzIHRvIHJ1biBvbiBOYUNsLCB3ZSBuZWVkIHRv IG1ha2Ugc3VyZSB0aGF0IHdlIGFsd2F5cwpjYWxsIGl0IHdpdGggdGhlIHByb3BlciBleHRlbnNp b24gKC5uZXhlIGluIHRoaXMgY2FzZSkgZHVyaW5nIHRoZSBidWlsZCwKd2hlbiBFbWFjcyBoYXMg dG8gcnVuIHRvIGdlbmVyYXRlIGxlaW0tbGlzdC5lbCBhbmQgZG9jdW1lbnRhdGlvbi4KLS0tCiBD aGFuZ2VMb2cgICAgICAgICAgIHwgNCArKysrCiBsZWltL01ha2VmaWxlLmluICAgIHwgMiArLQog bGliLXNyYy9NYWtlZmlsZS5pbiB8IDIgKy0KIGxpc3AvTWFrZWZpbGUuaW4gICAgfCAyICstCiA0 IGZpbGVzIGNoYW5nZWQsIDcgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1n aXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggNDM2NTY2OC4uOThiNjhlYyAxMDA2NDQK LS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDcgQEAKKzIwMTUtMDIt MjAgUGV0ZSBXaWxsaWFtc29uIDxwZXRld2lsMEBnb29nbGVtYWlsLmNvbT4KKwkqIE1ha2VmaWxl LmluIC0gVXNlIHRoZSB7RVhFRVhUfSBlbnZpcm9ubWVudCB2YXJpYWJsZSBtb3JlIHVuaWZvcm1s eQorCXRvIG1ha2Ugc3VyZSB0aGF0IHRoZSBlbWFjcyBiaW5hcnkgaXMgdXNlZCB3aXRoIHRoZSBw cm9wZXIgZXh0ZW5zaW9uLgorCiAyMDE1LTAyLTEzICBKYW4gRGrDpHJ2ICA8amFuLmguZEBzd2lw bmV0LnNlPgogCiAJKiBjb25maWd1cmUuYWM6IFNldCBsb2NhbGxpc3BwYXRoIHRvIGVtcHR5IGZv ciBOUyBzZWxmIGNvbnRhaW5lZCwKZGlmZiAtLWdpdCBhL2xlaW0vTWFrZWZpbGUuaW4gYi9sZWlt L01ha2VmaWxlLmluCmluZGV4IDU3M2FjZjcuLjJlYzAzZGIgMTAwNjQ0Ci0tLSBhL2xlaW0vTWFr ZWZpbGUuaW4KKysrIGIvbGVpbS9NYWtlZmlsZS5pbgpAQCAtNDcsNyArNDcsNyBAQCB1bmV4cG9y dCBFTUFDU0RBVEEgRU1BQ1NET0MgRU1BQ1NQQVRICiAKICMgV2hpY2ggRW1hY3MgdG8gdXNlIHRv IGNvbnZlcnQgVElUIGZpbGVzIHRvIEVtYWNzIExpc3AgZmlsZXMsCiAjIGFuZCBnZW5lcmF0ZSB0 aGUgZmlsZSBsZWltLWxpc3QuZWwuCi1FTUFDUyA9IC4uL3NyYy9lbWFjcworRU1BQ1MgPSAuLi9z cmMvZW1hY3Mke0VYRUVYVH0KIAogIyBIb3cgdG8gcnVuIEVtYWNzLgogIyBQcmV2ZW50IGFueSBz ZXR0aW5nIG9mIEVNQUNTTE9BRFBBVEggaW4gdXNlciBlbnZpcm9ubWVudCBjYXVzaW5nIHByb2Js ZW1zLgpkaWZmIC0tZ2l0IGEvbGliLXNyYy9NYWtlZmlsZS5pbiBiL2xpYi1zcmMvTWFrZWZpbGUu aW4KaW5kZXggZDI3MDVlNy4uNmI1ZDM3OSAxMDA2NDQKLS0tIGEvbGliLXNyYy9NYWtlZmlsZS5p bgorKysgYi9saWItc3JjL01ha2VmaWxlLmluCkBAIC0yMSw3ICsyMSw3IEBACiBTSEVMTCA9IEBT SEVMTEAKIAogIyBGb2xsb3dpbmcgLi4vbGlzcC9NYWtlZmlsZS5pbi4KLUVNQUNTID0gLi4vc3Jj L2VtYWNzCitFTUFDUyA9IC4uL3NyYy9lbWFjcyR7RVhFRVhUfQogRU1BQ1NPUFQgPSAtYmF0Y2gg LS1uby1zaXRlLWZpbGUgLS1uby1zaXRlLWxpc3AKIAogIyA9PT09PT09PT09PT09PT09PT09PSBU aGluZ3MgYGNvbmZpZ3VyZScgd2lsbCBlZGl0ID09PT09PT09PT09PT09PT09PT09CmRpZmYgLS1n aXQgYS9saXNwL01ha2VmaWxlLmluIGIvbGlzcC9NYWtlZmlsZS5pbgppbmRleCBlNWNmYzYzLi4y MmQ1ZGRjIDEwMDY0NAotLS0gYS9saXNwL01ha2VmaWxlLmluCisrKyBiL2xpc3AvTWFrZWZpbGUu aW4KQEAgLTQ3LDcgKzQ3LDcgQEAgYW1fX3ZfR0VOXzEgPQogIyBXZSBuZXZlciBjaGFuZ2UgZGly ZWN0b3J5IGJlZm9yZSBydW5uaW5nIEVtYWNzLCBzbyBhIHJlbGF0aXZlIGZpbGUKICMgbmFtZSBp cyBmaW5lLCBhbmQgbWFrZXMgbGlmZSBlYXNpZXIuICBJZiB3ZSBuZWVkIHRvIGNoYW5nZQogIyBk aXJlY3RvcnksIHdlIGNhbiB1c2UgZW1hY3MgLS1jaGRpci4KLUVNQUNTID0gLi4vc3JjL2VtYWNz CitFTUFDUyA9IC4uL3NyYy9lbWFjcyR7RVhFRVhUfQogCiAjIENvbW1hbmQgbGluZSBmbGFncyBm b3IgRW1hY3MuCiAKLS0gCjIuMi4wLnJjMC4yMDcuZ2EzYTYxNmMKCg== --001a11333c944496d9050fc51c0f--