From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Pete Williamson Newsgroups: gmane.emacs.devel Subject: [PATCH] for review - making use of {EXEEXT} more uniform in makefiles. Date: Fri, 13 Feb 2015 17:20:54 -0800 Message-ID: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=047d7b33d6341ade10050f022a94 X-Trace: ger.gmane.org 1423893273 28775 80.91.229.3 (14 Feb 2015 05:54:33 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 14 Feb 2015 05:54:33 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Feb 14 06:54:26 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YMVgQ-0004EK-E6 for ged-emacs-devel@m.gmane.org; Sat, 14 Feb 2015 06:54:26 +0100 Original-Received: from localhost ([::1]:58867 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YMVgP-0002gO-Jb for ged-emacs-devel@m.gmane.org; Sat, 14 Feb 2015 00:54:25 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53385) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YMRPo-0005jC-GO for emacs-devel@gnu.org; Fri, 13 Feb 2015 20:21:01 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YMRPj-0006dI-Ql for emacs-devel@gnu.org; Fri, 13 Feb 2015 20:21:00 -0500 Original-Received: from mail-pd0-f172.google.com ([209.85.192.172]:33395) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YMRPj-0006cs-Hs for emacs-devel@gnu.org; Fri, 13 Feb 2015 20:20:55 -0500 Original-Received: by pdjz10 with SMTP id z10so22834902pdj.0 for ; Fri, 13 Feb 2015 17:20:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=tQ7PJsKlspehHla+3CZe7o9myi1WgOX9JOCZyA0e0MA=; b=R5Xo2sFH3yy0OO0ZkY55cUnNokZsNg/TitxqPakknUsA644TySPCFWXMGesoEWKRCf 5weYcGtQTv8O1hFttB+S9FumrtRAqHSdTodrBl94IhwP1x/8UKjvrcwRaPppq31mN4+q cKEfPP0/sidjZOgHY9ooDaYUelsrEQajjMtabuRVU9AtwuI9qdEl4ewUvdg6TV4TR0Dz iMT2PCW+5Ue6Id9iocYruUcSe5ykeifeoJM1/Egjh7PE/4VhTeWy5rB61J62cH/25R4A H3Bzmdy84sIyGBFrC8/0HErIpmiaAB8HHS9ljL2+Q5bkqT6DPvsSPJ8vAk6IPkD2+821 AqWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:date:message-id:subject:from:to :content-type; bh=tQ7PJsKlspehHla+3CZe7o9myi1WgOX9JOCZyA0e0MA=; b=Ipd1kUpOxIiGgVM5OsgNsnx/nxUFW4sS/M7tc5XZ/En2mwoW0ZTpgI3s61e6tjcfx+ 2bAoFv1PNxmgogP4enTQAin4pJzxIWEzQWIOGGxFdnI2B/8+diofoRCH9etE4G4VRQv3 yvozN8f/WJl4vQGIDqzBRukBeRrKcm506A4cRsVVUUxyKdOX9ALDCog3jbXTKyHnh/ss XqzjUaXg5lka+vwiMcvO2xwhlNUmAO0e1uTLvukSKP9DnshWn8tkveEMyf6tQTL0yxTQ RNHBBcQSzfN2CWKAFNmE+jPWTWAWLY3mCuM3epdzLR2zYmIPaWrkyTn7lYqMfYPF0Nvq CgBg== X-Gm-Message-State: ALoCoQmWes6eqBPcZIW2/kPkA12y5acLy9Ry7rdh/FtEeBDW+3APbB3P+H0QkC0Zcmcdh9yNx3Lm X-Received: by 10.68.233.232 with SMTP id tz8mr19596192pbc.166.1423876854264; Fri, 13 Feb 2015 17:20:54 -0800 (PST) Original-Received: by 10.70.59.71 with HTTP; Fri, 13 Feb 2015 17:20:54 -0800 (PST) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.192.172 X-Mailman-Approved-At: Sat, 14 Feb 2015 00:54:22 -0500 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:183039 Archived-At: --047d7b33d6341ade10050f022a94 Content-Type: text/plain; charset=UTF-8 I humbly submit my first patch for feedback and consideration. My apologies in advance if I am not following the proper protocol for a patch email, I'm new to this (I did look at several other [PATCH] emails.) Rationale: I'm porting Emacs to a new platform, and we need to have a file extension on all executables for this platform when we run the executables. In several places in the makefile, no extension is used. This catches the places that I ran into, and uses the {EXEEXT} extension to make sure the proper file name extension is used to launch programs by. Motivating case: I'm porting Emacs to the Chromebook using the NaCl API, and we need for executables to have the .nexe extension. Even when running Emacs during the build process on the host Linux build machine (for instance to create leim-list.el or build documentation), we need the proper extension so that the machine emulator is not confused. I have tested this by building and running Emacs on Ubuntu 14 (only), let me know if it is expected to test in more places. All feedback and comments are welcome. The patch file is below, here is a text version of the diff (since it is a small patch) diff --git a/leim/Makefile.in b/leim/Makefile.in index 573acf7..70f2aca 100644 --- a/leim/Makefile.in +++ b/leim/Makefile.in @@ -47,7 +47,7 @@ unexport EMACSDATA EMACSDOC EMACSPATH # Which Emacs to use to convert TIT files to Emacs Lisp files, # and generate the file leim-list.el. -EMACS = ../src/emacs +EMACS = ../src/emacs{EXEEXT} # How to run Emacs. # Prevent any setting of EMACSLOADPATH in user environment causing problems. diff --git a/lib-src/Makefile.in b/lib-src/Makefile.in index d2705e7..d08aac5 100644 --- a/lib-src/Makefile.in +++ b/lib-src/Makefile.in @@ -21,7 +21,7 @@ SHELL = @SHELL@ # Following ../lisp/Makefile.in. -EMACS = ../src/emacs +EMACS = ../src/emacs{EXEEXT} EMACSOPT = -batch --no-site-file --no-site-lisp # ==================== Things `configure' will edit ==================== diff --git a/lisp/Makefile.in b/lisp/Makefile.in index e5cfc63..3b0d109 100644 --- a/lisp/Makefile.in +++ b/lisp/Makefile.in @@ -47,7 +47,7 @@ am__v_GEN_1 = # We never change directory before running Emacs, so a relative file # name is fine, and makes life easier. If we need to change # directory, we can use emacs --chdir. -EMACS = ../src/emacs +EMACS = ../src/emacs{EXEEXT} # Command line flags for Emacs. --047d7b33d6341ade10050f022a94 Content-Type: text/x-patch; charset=US-ASCII; name="0001-Use-EXEEXT-more-uniformly-in-makefiles-when-running-.patch" Content-Disposition: attachment; filename="0001-Use-EXEEXT-more-uniformly-in-makefiles-when-running-.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_i64b8rx00 RnJvbSA4ZDhjYmE4NWMyZTQyOThlNDA0NDIwNjkzNjg5MTJlNjgxNDlmYjJmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRlIFdpbGxpYW1zb24gPHBldGV3aWxAY2hyb21pdW0ub3Jn PgpEYXRlOiBGcmksIDEzIEZlYiAyMDE1IDE2OjU5OjM5IC0wODAwClN1YmplY3Q6IFtQQVRDSF0g VXNlIHtFWEVFWFR9IG1vcmUgdW5pZm9ybWx5IGluIG1ha2VmaWxlcyB3aGVuIHJ1bm5pbmcKIGV4 ZWN1dGFibGVzLgoKV2hlbiBwb3J0aW5nIEVtYWNzIHRvIHJ1biBvbiBOYUNsLCB3ZSBuZWVkIHRv IG1ha2Ugc3VyZSB0aGF0IHdlIGFsd2F5cwpjYWxsIGl0IHdpdGggdGhlIHByb3BlciBleHRlbnNp b24gKC5uZXhlIGluIHRoaXMgY2FzZSkgZHVyaW5nIHRoZSBidWlsZCwKd2hlbiBFbWFjcyBoYXMg dG8gcnVuIHRvIGdlbmVyYXRlIGxlaW0tbGlzdC5lbCBhbmQgZG9jdW1lbnRhdGlvbi4KLS0tCiBs ZWltL01ha2VmaWxlLmluICAgIHwgMiArLQogbGliLXNyYy9NYWtlZmlsZS5pbiB8IDIgKy0KIGxp c3AvTWFrZWZpbGUuaW4gICAgfCAyICstCiAzIGZpbGVzIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygr KSwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9sZWltL01ha2VmaWxlLmluIGIvbGVpbS9N YWtlZmlsZS5pbgppbmRleCA1NzNhY2Y3Li43MGYyYWNhIDEwMDY0NAotLS0gYS9sZWltL01ha2Vm aWxlLmluCisrKyBiL2xlaW0vTWFrZWZpbGUuaW4KQEAgLTQ3LDcgKzQ3LDcgQEAgdW5leHBvcnQg RU1BQ1NEQVRBIEVNQUNTRE9DIEVNQUNTUEFUSAogCiAjIFdoaWNoIEVtYWNzIHRvIHVzZSB0byBj b252ZXJ0IFRJVCBmaWxlcyB0byBFbWFjcyBMaXNwIGZpbGVzLAogIyBhbmQgZ2VuZXJhdGUgdGhl IGZpbGUgbGVpbS1saXN0LmVsLgotRU1BQ1MgPSAuLi9zcmMvZW1hY3MKK0VNQUNTID0gLi4vc3Jj L2VtYWNze0VYRUVYVH0KIAogIyBIb3cgdG8gcnVuIEVtYWNzLgogIyBQcmV2ZW50IGFueSBzZXR0 aW5nIG9mIEVNQUNTTE9BRFBBVEggaW4gdXNlciBlbnZpcm9ubWVudCBjYXVzaW5nIHByb2JsZW1z LgpkaWZmIC0tZ2l0IGEvbGliLXNyYy9NYWtlZmlsZS5pbiBiL2xpYi1zcmMvTWFrZWZpbGUuaW4K aW5kZXggZDI3MDVlNy4uZDA4YWFjNSAxMDA2NDQKLS0tIGEvbGliLXNyYy9NYWtlZmlsZS5pbgor KysgYi9saWItc3JjL01ha2VmaWxlLmluCkBAIC0yMSw3ICsyMSw3IEBACiBTSEVMTCA9IEBTSEVM TEAKIAogIyBGb2xsb3dpbmcgLi4vbGlzcC9NYWtlZmlsZS5pbi4KLUVNQUNTID0gLi4vc3JjL2Vt YWNzCitFTUFDUyA9IC4uL3NyYy9lbWFjc3tFWEVFWFR9CiBFTUFDU09QVCA9IC1iYXRjaCAtLW5v LXNpdGUtZmlsZSAtLW5vLXNpdGUtbGlzcAogCiAjID09PT09PT09PT09PT09PT09PT09IFRoaW5n cyBgY29uZmlndXJlJyB3aWxsIGVkaXQgPT09PT09PT09PT09PT09PT09PT0KZGlmZiAtLWdpdCBh L2xpc3AvTWFrZWZpbGUuaW4gYi9saXNwL01ha2VmaWxlLmluCmluZGV4IGU1Y2ZjNjMuLjNiMGQx MDkgMTAwNjQ0Ci0tLSBhL2xpc3AvTWFrZWZpbGUuaW4KKysrIGIvbGlzcC9NYWtlZmlsZS5pbgpA QCAtNDcsNyArNDcsNyBAQCBhbV9fdl9HRU5fMSA9CiAjIFdlIG5ldmVyIGNoYW5nZSBkaXJlY3Rv cnkgYmVmb3JlIHJ1bm5pbmcgRW1hY3MsIHNvIGEgcmVsYXRpdmUgZmlsZQogIyBuYW1lIGlzIGZp bmUsIGFuZCBtYWtlcyBsaWZlIGVhc2llci4gIElmIHdlIG5lZWQgdG8gY2hhbmdlCiAjIGRpcmVj dG9yeSwgd2UgY2FuIHVzZSBlbWFjcyAtLWNoZGlyLgotRU1BQ1MgPSAuLi9zcmMvZW1hY3MKK0VN QUNTID0gLi4vc3JjL2VtYWNze0VYRUVYVH0KIAogIyBDb21tYW5kIGxpbmUgZmxhZ3MgZm9yIEVt YWNzLgogCi0tIAoyLjIuMC5yYzAuMjA3LmdhM2E2MTZjCgo= --047d7b33d6341ade10050f022a94--