From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: =?UTF-8?Q?Rami_Ylim=C3=A4ki?= Newsgroups: gmane.emacs.devel Subject: Re: [PATCH v2] Support 24-bit terminal colors. Date: Mon, 13 Feb 2017 00:53:47 +0200 Message-ID: References: <1486893930-6709-1-git-send-email-rami.ylimaki@vincit.fi> <83tw7z16hv.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a1147b1002e971005485d341b X-Trace: blaine.gmane.org 1486940102 11161 195.159.176.226 (12 Feb 2017 22:55:02 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 12 Feb 2017 22:55:02 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Feb 12 23:54:55 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cd32k-0002UF-OR for ged-emacs-devel@m.gmane.org; Sun, 12 Feb 2017 23:54:54 +0100 Original-Received: from localhost ([::1]:53702 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cd32q-0005IX-CW for ged-emacs-devel@m.gmane.org; Sun, 12 Feb 2017 17:55:00 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35070) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cd31i-00055R-A2 for emacs-devel@gnu.org; Sun, 12 Feb 2017 17:53:51 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cd31h-0003lZ-3A for emacs-devel@gnu.org; Sun, 12 Feb 2017 17:53:50 -0500 Original-Received: from mail-qk0-x22c.google.com ([2607:f8b0:400d:c09::22c]:32879) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cd31g-0003kV-Tk for emacs-devel@gnu.org; Sun, 12 Feb 2017 17:53:49 -0500 Original-Received: by mail-qk0-x22c.google.com with SMTP id s140so80556648qke.0 for ; Sun, 12 Feb 2017 14:53:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vincit.com; s=ticniv; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=MwP+NMNzR4ib66H31S0A9QdV7NQBjtwQfj9r7MTjDGE=; b=lp/tKcuDl/7hi7UKRxTMuQHhiVVLPPGzYCijvdh+PCBWtdjuuvBBtKIMS2NYv1znyU 3Y84CzR1sPBV4YjZhNXDxGKAp05fA1iAYW6LccWb19xCgemn5LQTHZYi8eKTzFtGZ3Gx JEvleInG+il6BldFqSqslBKB2xF24+QJ+ySUg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=MwP+NMNzR4ib66H31S0A9QdV7NQBjtwQfj9r7MTjDGE=; b=Xd9PnT7uE8x6vK8JEAmyuFmB9rzWs9ax055EHkPB8oxycQGKWBS5cVu3YDz0vqRPBu ax0FjH8IrwpMn1x62KlW3AUsFilLcl+1oJV1dtc0b7C7UcQ9XlJ9Lb9m7srDw5r/TeMI WsoQy/QOIMgnPrxiPAMwpdz/VlKHYY0L7gF0nv2oYoqiEZsEvaAswthL9LYbhiQxB+5X 2GDdcKZu+N8gPiGHhLt1eotIjlvnUwybNeQkU8NBGGPMLSiyrMFOe3gd82+S4p1EfgLO 9vQyOWqOuylpc7/PErqzDOUInE+t1P/117j90Iz2nNDFVkmc1L0YJ43keS9E3e+0tYsi TpJg== X-Gm-Message-State: AMke39kqsxG0PhaXTBLNFJ4QxWRrYhpAfOnxmd7LC0MMIHJ9KYP4OIoC+Ht0+c2YvEE3GKUjrddPZ3Ru4D7vZcTX X-Received: by 10.55.41.168 with SMTP id p40mr3396911qkp.200.1486940028173; Sun, 12 Feb 2017 14:53:48 -0800 (PST) Original-Received: by 10.55.98.8 with HTTP; Sun, 12 Feb 2017 14:53:47 -0800 (PST) In-Reply-To: <83tw7z16hv.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400d:c09::22c X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:212312 Archived-At: --001a1147b1002e971005485d341b Content-Type: text/plain; charset=UTF-8 2017-02-12 22:47 GMT+02:00 Eli Zaretskii : > > . Please prepare a NEWS entry for this feature. > . It seems like you dropped the code to support the --color= > command-line argument, which was part of your original submission? > All the other color TTY modes support --color=NUM, so I think we > should also support --color=16777216, and perhaps also --color-24bit. > I'll write the NEWS entry but I'm afraid that fixing the --color=NUM option would require too much effort right now. The manual is too optimistic when it states that "Emacs might be able to turn on a color mode for 8, 16, 88, or 256 as the value of NUM". In reality, only -1, 0 and 8 are supported. The 16, 88, and 256 color modes can only be enabled based on current terminal capabilities and this is now true for the 16M color mode as well. The problems of handling --color=NUM can be seen when colors are downgraded, because color and face pixel values aren't updated. For example, "M-x list-faces-display" produces different results with "TERM=xterm emacs -Q -nw --color=8" and "TERM=xterm-256color emacs -Q -nw --color=8". This is why I'd like to treat the --color option as a separate issue. --001a1147b1002e971005485d341b Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
2017= -02-12 22:47 GMT+02:00 Eli Zaretskii <eliz@gnu.org>:
=C2=A0. Please prepare a NEWS entry for this feature.
=C2=A0. It seems like you dropped the code to support the --color=3D
=C2=A0 =C2=A0command-line argument, which was part of your original submiss= ion?
=C2=A0 =C2=A0All the other color TTY modes support --color=3DNUM, so I thin= k we
=C2=A0 =C2=A0should also support --color=3D16777216, and perhaps also --col= or-24bit.

I'll write the NEWS entry= but I'm afraid that fixing the --color=3DNUM option would require too = much effort right now.

The manual is too optimisti= c when it states that "Emacs might be able to turn on a color mode for= 8, 16, 88, or 256 as the value of NUM". In reality, only -1, 0 and 8 = are supported. The 16, 88, and 256 color modes can only be enabled based on= current terminal capabilities and this is now true for the 16M color mode = as well.

The problems of handling --color=3DNUM ca= n be seen when colors are downgraded, because color and face pixel values a= ren't updated. For example, "M-x list-faces-display" produces= different results with "TERM=3Dxterm emacs -Q -nw --color=3D8" a= nd "TERM=3Dxterm-256color emacs -Q -nw --color=3D8". This is why = I'd like to treat the --color option as a separate issue.
--001a1147b1002e971005485d341b--