From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Erik Selberg Newsgroups: gmane.emacs.devel Subject: Re: comint fix for shell colors Date: Fri, 18 Nov 2016 14:43:00 -0800 Message-ID: References: <83twb5cd8t.fsf@gnu.org> <582f0f65.En4KsDnZnxPG7ZLy%wjenkner@inode.at> <83k2c0df63.fsf@gnu.org> <582f18f4.iBWOd+O4h9885qPS%wjenkner@inode.at> <83h974dcnw.fsf@gnu.org> <582f230b.H6hD/Dl//Y7pXQAi%wjenkner@inode.at> <5430A3E1-CD8B-4F1A-87BD-F1637BE3142A@selberg.org> <83wpg0bm8z.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a11432a6a4244aa05419b0767 X-Trace: blaine.gmane.org 1479508993 6025 195.159.176.226 (18 Nov 2016 22:43:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 18 Nov 2016 22:43:13 +0000 (UTC) Cc: Wolfgang Jenkner , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 18 23:43:08 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c7rsC-0001Ei-Cy for ged-emacs-devel@m.gmane.org; Fri, 18 Nov 2016 23:43:08 +0100 Original-Received: from localhost ([::1]:39180 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c7rsF-0002L2-Ot for ged-emacs-devel@m.gmane.org; Fri, 18 Nov 2016 17:43:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51853) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c7rs9-0002Kk-Df for emacs-devel@gnu.org; Fri, 18 Nov 2016 17:43:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c7rs8-0002ln-Lz for emacs-devel@gnu.org; Fri, 18 Nov 2016 17:43:05 -0500 Original-Received: from mail-vk0-x232.google.com ([2607:f8b0:400c:c05::232]:34126) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c7rs5-0002lI-R7; Fri, 18 Nov 2016 17:43:01 -0500 Original-Received: by mail-vk0-x232.google.com with SMTP id x186so179499651vkd.1; Fri, 18 Nov 2016 14:43:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=99RHy6OAbnORgeVQN/qbVHEmjTdFaqCM7wgBU0MaPVs=; b=hRAV6moYNJIInWa/p+dzIZXTvNB0VGl6QyYojMzxtyuOmxByAG4iZ+Zb0MmDYUEcne wXQySF4smMkvt4IM8eOB30M1n8WwrTIP/rn5Jn9sR35ZVz0oNIpO7uN+kMm7tr05RYVP ykclidIT2v/5okRHZoaUVg9pWcR3f8nQMgK6W37/XYUldJKv8uSsxjqoVJeqDfVottJK PF7WCkiG5DEwl6k5gfSGL8qRNgyPVF14f5DY4Cs/pCLebaY8d1i+EHr43Tt5yJK7w19g /RxYiEvgW1LaSqxam3IYMMo/h755PlXiq6Bv/DfFEKPOjgmpmCpCSEtEO1tZLJULPa/F APDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=99RHy6OAbnORgeVQN/qbVHEmjTdFaqCM7wgBU0MaPVs=; b=VrlkmqaZwMpKCCsU3D+s9uZfrFuJlDk89wab9et4mkeZXrgIFwkpul5pNNtxhB29v9 ow6jt0ulFoLNM8bA97F6nZLQjCAYcm57Np+f2r2z2uIjUy6o7+Fc03gvkyMzAm2GgZIz yLZfK8YjHmfBepJcNmMORVzMksNHKPk6qqwGfKRp72Ynl/6Tgjj2ZadkjyMimKASj6a4 yBA9GZkX1CAbrV13tIFDls/Wlk/V8BCaAzUMLpN/BON2Qt4h0Zu6bGqOrLBLIV6Oq7EA ElnAjDA1+9K2sKFc9ZwbQUxt031ew/jWc/7/tOyrwqsLcEknmVXXTfJy+ZCcle6W1vN+ ohtg== X-Gm-Message-State: AKaTC01esUcct8Zu+QNywyQIuhq9WMzf4GuKop58EgMP2itKptV3VkVSf77fRTVqR/Rs/xK31DC/+/Mmkeujsg== X-Received: by 10.31.170.208 with SMTP id t199mr1195217vke.6.1479508981071; Fri, 18 Nov 2016 14:43:01 -0800 (PST) Original-Received: by 10.31.212.70 with HTTP; Fri, 18 Nov 2016 14:43:00 -0800 (PST) In-Reply-To: <83wpg0bm8z.fsf@gnu.org> X-Google-Sender-Auth: b_TXrFrIxWjaTxnb_enEc83VkeM X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400c:c05::232 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:209491 Archived-At: --001a11432a6a4244aa05419b0767 Content-Type: text/plain; charset=UTF-8 I'm not 100% sure why comint-prompt-highlight inherits from modeline. I know close to 100% of the people I work with have some kind of colored prompt, so rather than make everyone who does that and uses shell, I'd set the default to not inherit from modeline. absent that, something like: FIXED: comint will now properly pass through colors from inferior processes (e.g. shell color prompt). Please disable inheritance from comint-prompt-highlight via (....) -e On Fri, Nov 18, 2016 at 11:50 AM, Eli Zaretskii wrote: > > From: Erik Selberg > > Date: Fri, 18 Nov 2016 11:24:08 -0800 > > Cc: Eli Zaretskii , emacs-devel@gnu.org > > > > Confirmed fixed in 25.1. I did have to remove the inheritance from > mode-line to get the font proper, but I knew > > to look for that. Perhaps disabling inheritance by default? Or something > for NEWS. :) > > Thanks. What would you suggest to say in NEWS? Or maybe in some > relevant doc string? > > --001a11432a6a4244aa05419b0767 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
I'm not 100% sure why comint-prompt-highlight inherits= from modeline. I know close to 100% of the people I work with have some ki= nd of colored prompt, so rather than make everyone who does that and uses s= hell, I'd set the default to not inherit from modeline.

<= div>absent that, something like:
FIXED: comint will now properly = pass through colors from inferior processes (e.g. shell color prompt). Plea= se disable inheritance from comint-prompt-highlight via (....)
-e

On Fri, Nov 18, 2016 at 11:50 AM, Eli Zaretskii <eliz@gnu.org>= wrote:
> From: Erik Selberg &l= t;erik@selberg.org>
> Date: Fri, 18 Nov 2016 11:24:08 -0800
> Cc: Eli Zaretskii <eliz@gnu.org= >, emacs-devel@gnu.org
>
> Confirmed fixed in 25.1. I did have to remove the inheritance from mod= e-line to get the font proper, but I knew
> to look for that. Perhaps disabling inheritance by default? Or somethi= ng for NEWS. :)

Thanks.=C2=A0 What would you suggest to say in NEWS?=C2=A0 Or maybe = in some
relevant doc string?


--001a11432a6a4244aa05419b0767--