From: Erik Selberg <erik@selberg.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Wolfgang Jenkner <wjenkner@inode.at>, emacs-devel@gnu.org
Subject: Re: comint fix for shell colors
Date: Fri, 18 Nov 2016 14:43:00 -0800 [thread overview]
Message-ID: <CAHa5c_PM9CeFRu4agn_W559X_qS91Si-t5mfeLH4vPsOr2dMBA@mail.gmail.com> (raw)
In-Reply-To: <83wpg0bm8z.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 989 bytes --]
I'm not 100% sure why comint-prompt-highlight inherits from modeline. I
know close to 100% of the people I work with have some kind of colored
prompt, so rather than make everyone who does that and uses shell, I'd set
the default to not inherit from modeline.
absent that, something like:
FIXED: comint will now properly pass through colors from inferior processes
(e.g. shell color prompt). Please disable inheritance from
comint-prompt-highlight via (....)
-e
On Fri, Nov 18, 2016 at 11:50 AM, Eli Zaretskii <eliz@gnu.org> wrote:
> > From: Erik Selberg <erik@selberg.org>
> > Date: Fri, 18 Nov 2016 11:24:08 -0800
> > Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
> >
> > Confirmed fixed in 25.1. I did have to remove the inheritance from
> mode-line to get the font proper, but I knew
> > to look for that. Perhaps disabling inheritance by default? Or something
> for NEWS. :)
>
> Thanks. What would you suggest to say in NEWS? Or maybe in some
> relevant doc string?
>
>
[-- Attachment #2: Type: text/html, Size: 1535 bytes --]
prev parent reply other threads:[~2016-11-18 22:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-15 7:14 comint fix for shell colors Erik Selberg
2016-11-18 10:07 ` Eli Zaretskii
2016-11-18 14:25 ` Wolfgang Jenkner
2016-11-18 14:40 ` Eli Zaretskii
2016-11-18 15:06 ` Wolfgang Jenkner
2016-11-18 15:34 ` Eli Zaretskii
2016-11-18 15:40 ` Erik Selberg
2016-11-18 15:49 ` Wolfgang Jenkner
2016-11-18 15:53 ` Erik Selberg
2016-11-18 19:24 ` Erik Selberg
2016-11-18 19:50 ` Eli Zaretskii
2016-11-18 22:43 ` Erik Selberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHa5c_PM9CeFRu4agn_W559X_qS91Si-t5mfeLH4vPsOr2dMBA@mail.gmail.com \
--to=erik@selberg.org \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=wjenkner@inode.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).