From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Erik Selberg Newsgroups: gmane.emacs.devel Subject: Re: comint fix for shell colors Date: Fri, 18 Nov 2016 11:24:08 -0800 Message-ID: References: <83twb5cd8t.fsf@gnu.org> <582f0f65.En4KsDnZnxPG7ZLy%wjenkner@inode.at> <83k2c0df63.fsf@gnu.org> <582f18f4.iBWOd+O4h9885qPS%wjenkner@inode.at> <83h974dcnw.fsf@gnu.org> <582f230b.H6hD/Dl//Y7pXQAi%wjenkner@inode.at> <5430A3E1-CD8B-4F1A-87BD-F1637BE3142A@selberg.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a1136e5a60d99eb05419840a0 X-Trace: blaine.gmane.org 1479497067 2822 195.159.176.226 (18 Nov 2016 19:24:27 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 18 Nov 2016 19:24:27 +0000 (UTC) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Wolfgang Jenkner Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 18 20:24:20 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c7olj-0007ly-T0 for ged-emacs-devel@m.gmane.org; Fri, 18 Nov 2016 20:24:16 +0100 Original-Received: from localhost ([::1]:38556 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c7oln-0008Up-4E for ged-emacs-devel@m.gmane.org; Fri, 18 Nov 2016 14:24:19 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41303) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c7olg-0008UZ-Gz for emacs-devel@gnu.org; Fri, 18 Nov 2016 14:24:13 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c7olf-0003RJ-Gv for emacs-devel@gnu.org; Fri, 18 Nov 2016 14:24:12 -0500 Original-Received: from mail-ua0-x22e.google.com ([2607:f8b0:400c:c08::22e]:33470) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c7old-0003QM-Ks; Fri, 18 Nov 2016 14:24:09 -0500 Original-Received: by mail-ua0-x22e.google.com with SMTP id 20so179052539uak.0; Fri, 18 Nov 2016 11:24:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=56w3Unuu2DJ65Zj/P8AZBhA0pxMeZmc8h3+5RLhY89Q=; b=UEJ0OUq0Y6mJUKcF1Q8ynvORsxUY+kbxfrdoN7WZjvAuG+tTEZWsUgbjowPbwD2GHf Trbi7bBCZw/sVz5mithHBPBnCdZ3WCbPbGT/YOWOhTDrBvUe2S9lnojYB1PzOfUHlr6e LSRAhUmKj8A8feDuv9W3yWEITPU16Dw2uZLkrmkbERZNXvr8ZJc1OBdH+bYRd60riXrU Hr90q+R8mtbw3yVYQm8E7Qa+4xD9+j4Cu+knqQeMVBVtvYVK15qa3SwvpxEXoukVHND2 ZclwoMxFztMrUDyCYzd2epftRB9tuYdlj0UP6LFo6RUer9JUeS/nrqRlO6ozhcTfJoim 90rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=56w3Unuu2DJ65Zj/P8AZBhA0pxMeZmc8h3+5RLhY89Q=; b=POJ6YtULBsEcCjinpmPzjtS6+uw3zolvftB4GUaTvHmaUowNilMiOb2d61q6g819HL me+lGXa3VGoeS3xvEOYsaILclCdWIUrDQaCCDKMvSNP1ohFRtxyQRAgnTRVS+crvS6qz PwtissBEbEuQoPKA1lo3IIBnV73J+lJGCN2gbx2MDbTfKlctxhM91i46YLQmVWRvB1HM 2vm/U8RACmXTpM/hqEnMOjxP3QKDB98w3eNnwMDDKYtt/4TdCj77Dl9gfrJ4+CMGWEgT Rhi0QbLZ6iwNkRa++8sxGAsjaDxRPXWbIqisJqucIbynYY/u4Orfcx+LOWp1YpJimATR PHVw== X-Gm-Message-State: AKaTC03Nkp1nAKnorlCY9asf3MKdjMOl6QsLVW09PMHHsok68M791WUTXi5pl6vcux0bS2DEeq0dbARuXRlWAg== X-Received: by 10.159.36.51 with SMTP id 48mr881450uaq.27.1479497049019; Fri, 18 Nov 2016 11:24:09 -0800 (PST) Original-Received: by 10.31.212.70 with HTTP; Fri, 18 Nov 2016 11:24:08 -0800 (PST) In-Reply-To: <5430A3E1-CD8B-4F1A-87BD-F1637BE3142A@selberg.org> X-Google-Sender-Auth: PZFlexervIoL8g9ukhvKzPVtIZE X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400c:c08::22e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:209487 Archived-At: --001a1136e5a60d99eb05419840a0 Content-Type: text/plain; charset=UTF-8 Confirmed fixed in 25.1. I did have to remove the inheritance from mode-line to get the font proper, but I knew to look for that. Perhaps disabling inheritance by default? Or something for NEWS. :) Thanks! Erik On Fri, Nov 18, 2016 at 7:53 AM, Erik Selberg wrote: > I see fixed in 25.1. Thx ill give that a look-see. > > Cheers, > -e > > Sent from my iPhone > > > On Nov 18, 2016, at 7:49 AM, Wolfgang Jenkner wrote: > > > > Eli Zaretskii wrote: > > > >>> Date: Fri, 18 Nov 2016 16:06:28 +0100 > >>> From: Wolfgang Jenkner > >>> Cc: erik@selberg.org, emacs-devel@gnu.org > >>> > >>>> Indeed, I think this change should be described in NEWS. Could you > >>>> provide a patch for that, please? > >>> > >>> Please note that there's nothing new here, it was just a bug fix. > >>> The very first message in the bug report mentioned above states > >>> > >>> In Emacs 24.3, comint-highlight-prompt allows ANSI colors to > show through > >>> if it does not specify any colors itself. In Emacs 24.4, it > does not, even > >>> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > >>> if comint-highlight-prompt is the "empty face". > >> > >> Then how do you explain the OP's confusion on this matter? > > > > He said that he "made the following patch against 24.5", so I guess > > that's what he runs and that release still had the regression > > reported in bug#20084 (see my closing message there). > > > > Wolfgang > > > > > --001a1136e5a60d99eb05419840a0 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Confirmed fixed in 25.1. I did have to remove the inherita= nce from mode-line to get the font proper, but I knew to look for that. Per= haps disabling inheritance by default? Or something for NEWS. :)

Thanks!
Erik


On Fri, Nov 18, 2016 at 7:53 AM, E= rik Selberg <erik@selberg.org> wrote:
I see fixed in 25.1. Thx ill give that a look-see.

Cheers,
-e

Sent from my iPhone

> On Nov 18, 2016, at 7:4= 9 AM, Wolfgang Jenkner <wjenkner@in= ode.at> wrote:
>
> Eli Zaretskii <eliz@gnu.org>= wrote:
>
>>> Date: Fri, 18 Nov 2016 16:06:28 +0100
>>> From: Wolfgang Jenkner <wjenkner@inode.at>
>>> Cc: erik@selberg.org, = emacs-devel@gnu.org
>>>
>>>> Indeed, I think this change should be described in NEWS.= =C2=A0 Could you
>>>> provide a patch for that, please?
>>>
>>> Please note that there's nothing new here, it was just a b= ug fix.
>>> The very first message in the bug report mentioned above state= s
>>>
>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 In Emacs 24.3, comint-highlight-pro= mpt allows ANSI colors to show through
>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 if it does not specify any colors i= tself. In Emacs 24.4, it does not, even
>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^= ^^^^^^^^^^
>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 if comint-highlight-prompt is the &= quot;empty face".
>>
>> Then how do you explain the OP's confusion on this matter?
>
> He said that he "made the following patch against 24.5", so = I guess
> that's what he runs and that release still had the regression
> reported in bug#20084 (see my closing message there).
>
> Wolfgang
>
>

--001a1136e5a60d99eb05419840a0--