Re: comint fix for shell colors

[Erik Selberg <erik@selberg.org>]

[-- Attachment #1: Type: text/plain, Size: 1515 bytes --]

Confirmed fixed in 25.1. I did have to remove the inheritance from
mode-line to get the font proper, but I knew to look for that. Perhaps
disabling inheritance by default? Or something for NEWS. :)

Thanks!
Erik


On Fri, Nov 18, 2016 at 7:53 AM, Erik Selberg <erik@selberg.org> wrote:

> I see fixed in 25.1. Thx ill give that a look-see.
>
> Cheers,
> -e
>
> Sent from my iPhone
>
> > On Nov 18, 2016, at 7:49 AM, Wolfgang Jenkner <wjenkner@inode.at> wrote:
> >
> > Eli Zaretskii <eliz@gnu.org> wrote:
> >
> >>> Date: Fri, 18 Nov 2016 16:06:28 +0100
> >>> From: Wolfgang Jenkner <wjenkner@inode.at>
> >>> Cc: erik@selberg.org, emacs-devel@gnu.org
> >>>
> >>>> Indeed, I think this change should be described in NEWS.  Could you
> >>>> provide a patch for that, please?
> >>>
> >>> Please note that there's nothing new here, it was just a bug fix.
> >>> The very first message in the bug report mentioned above states
> >>>
> >>>        In Emacs 24.3, comint-highlight-prompt allows ANSI colors to
> show through
> >>>        if it does not specify any colors itself. In Emacs 24.4, it
> does not, even
> >>>        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> >>>        if comint-highlight-prompt is the "empty face".
> >>
> >> Then how do you explain the OP's confusion on this matter?
> >
> > He said that he "made the following patch against 24.5", so I guess
> > that's what he runs and that release still had the regression
> > reported in bug#20084 (see my closing message there).
> >
> > Wolfgang
> >
> >
>

[-- Attachment #2: Type: text/html, Size: 2478 bytes --]