From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Narendra Joshi Newsgroups: gmane.emacs.devel Subject: Re: Patch for a simple nil check in `calc-graph-add-curve' Date: Sat, 21 Mar 2020 22:56:36 +0100 Message-ID: References: <83zhc9cv2w.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="96304"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Mar 21 22:57:28 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jFm7U-000Ovc-Dm for ged-emacs-devel@m.gmane-mx.org; Sat, 21 Mar 2020 22:57:28 +0100 Original-Received: from localhost ([::1]:41176 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jFm7T-0000ga-G5 for ged-emacs-devel@m.gmane-mx.org; Sat, 21 Mar 2020 17:57:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56786) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jFm6u-0000H4-LC for emacs-devel@gnu.org; Sat, 21 Mar 2020 17:56:53 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jFm6t-0005wq-Mn for emacs-devel@gnu.org; Sat, 21 Mar 2020 17:56:52 -0400 Original-Received: from mail-ot1-x32b.google.com ([2607:f8b0:4864:20::32b]:42581) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jFm6r-0005vH-Kj; Sat, 21 Mar 2020 17:56:49 -0400 Original-Received: by mail-ot1-x32b.google.com with SMTP id s18so101385otr.9; Sat, 21 Mar 2020 14:56:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1XdHUaYVhKHlXWQixNNp/pp3q4AlfH53AI+/Uua7k14=; b=QWKUyZVmMRKCNZB92uWe7y7iO+ohXQxP2FgbMljs1cTxK4a72yD8SXQI2rGdVNW7C/ 4xb5y7eReUuaCU+QZF8+t0G0jTPwnUUgIiPvxdufPJuFqusxRc04KejlvraRwWjwoshT 2F3Wd/Xx4ZIj6uhDuyG/EtQh6TSTJVuLstgt6oQwOTj5L83CSw4nizaXTAs/gIVywbLe d5HulIdacfTb50BCa9pnY+jkTE0WLAw6eqdSCcGZHL43mWw7T2ibcSvj8YHCJgMiaBKo g4CwdVrsqRNgOhypQN5UnwYdltFeUCxL9ZZOwLzmLAaCI+XfFlZOKVK+oMw5zUhrFi7R js7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1XdHUaYVhKHlXWQixNNp/pp3q4AlfH53AI+/Uua7k14=; b=V3cpSx/U42OfJ++/Sccmz4YVZvrtZSUGiu4Q23WN4OVmBrzG2nXHLkLSl1gRka9nHq MkkLDGKqcl6IkwMHlHB0As/grF3DoAmJVwWykz9R1fPJS1Mgh243/O1yR05NkEeThAtq aPWSiugM0DhoLFIdgqUpCoAB/5GxwRz6ybUB7e/4WDR8dIPOaQPKzhkgcSdptFY9MYhR oNitBb7fYJhWztt+C92AAO4Hs013SRPx5Wi6RqTiZCIXpzl3UP4Pm5FP/laRQxhcAs34 ZiOEmrs8GpkOaJhmMiyp4QatFbQqYZnyswhJl30iijGQhIXRt/RGC1kLL9MgdVuVPoA/ X2GQ== X-Gm-Message-State: ANhLgQ0NqvAb1mae1tzrJZBhLHEQFyPxKigo8fq6Jl87rJBUvH3oUiAO V6KVbSAuQwetAd1g/MvrqSNlsgwx4FofKe0iIKyhTBVAYg== X-Google-Smtp-Source: ADFU+vuB41WSE/jlIpOpIiwvx9KAOSKalndHJLsBdo2osUjkTtIlRT3wHqWAVuQ4wON+pidS6i7UNjBxpr5RAokKLws= X-Received: by 2002:a9d:7750:: with SMTP id t16mr12197755otl.333.1584827807618; Sat, 21 Mar 2020 14:56:47 -0700 (PDT) In-Reply-To: <83zhc9cv2w.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::32b X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:245649 Archived-At: A simple `calc-graph-fast' call with the following values on Emacs Calc stack fails: 3: [1, 2, 3, 4, 5, 6, 7, 8, 9, 10] 2: [1, 2, 3, 4, 5, 6, 7, 8, 9, 10] 1: [1, 2, 3, 4, 5, 6, 7, 8, 9, 10] It fails because `calc-graph-fast` eventually calls `math-trunc` on the line and point style values which aren't set yet. Since they are `nil` we should avoid calling `math-trunc` on them and take a default value. The patch just adds a `nil` check for these variables `lstyles` (LineStyles) and `pstyles` (PointStyles). - Narendra On Sat, Mar 21, 2020 at 9:27 PM Eli Zaretskii wrote: > > > From: Narendra Joshi > > Date: Sat, 21 Mar 2020 20:48:52 +0100 > > > > Can someone please add this simple `nil' check in the attached patch? > > Thanks, but could you please provide the rationale?