From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jeffrey Walton Newsgroups: gmane.comp.lib.gnulib.bugs,gmane.emacs.devel Subject: Re: Emacs 28.1 doesn't compile on Mac OS 10.7.5 Date: Sat, 16 Apr 2022 23:28:03 -0400 Message-ID: References: <20220415.135547.28187788939231142.wl@gnu.org> <3F594037-7DF0-406B-A8DB-8709F76D7583@acm.org> <20220415.172301.1386462415020611428.wl@gnu.org> <2BC45081-033F-4796-891E-D052149C8BCB@acm.org> <67901569-bf14-b973-9de2-0f5d68aafe96@cs.ucla.edu> Reply-To: noloader@gmail.com Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16792"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dports@macports.org, Werner LEMBERG , Gnulib bugs , =?UTF-8?Q?Mattias_Engdeg=C3=A5rd?= , Emacs-Devel , Filipp Gunbin To: Paul Eggert Original-X-From: bug-gnulib-bounces+gnu-bug-gnulib=m.gmane-mx.org@gnu.org Sun Apr 17 05:28:52 2022 Return-path: Envelope-to: gnu-bug-gnulib@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nfvam-0004Da-4K for gnu-bug-gnulib@m.gmane-mx.org; Sun, 17 Apr 2022 05:28:52 +0200 Original-Received: from localhost ([::1]:43760 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nfvak-0002KE-F5 for gnu-bug-gnulib@m.gmane-mx.org; Sat, 16 Apr 2022 23:28:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59608) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nfvah-0002K1-Pu; Sat, 16 Apr 2022 23:28:47 -0400 Original-Received: from mail-lj1-x231.google.com ([2a00:1450:4864:20::231]:47037) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nfvaf-0004ZZ-AT; Sat, 16 Apr 2022 23:28:47 -0400 Original-Received: by mail-lj1-x231.google.com with SMTP id bj36so7573731ljb.13; Sat, 16 Apr 2022 20:28:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:reply-to:from:date:message-id :subject:to:cc:content-transfer-encoding; bh=LaJ+t4TMj3YE4Z4t0DmwOZ1IkC+hs24edAZmaTUmJpc=; b=k8T+tSA+KVpQ/MWoLDvlNtlYcOTZY7ZngYEvmP1da4xpx1OOPyOPpH7MlKIh2+xXIB cntQQ1ZjDTnMsIiZzqqMKVrvlCTaRwyg/S8l4oc9BvVSO3Dg0vpEpeh2bro36g+9xPqz 4ReS5OR8bblI36R6gD03pRYtUPnmcas2lwhnzQmMA+CPIs4zpoH6d+y7+C4p2kXc6dg6 nVa35KQR3+y0O0pNCG8QRIzxlRvkV36YZtBMOXQCIyx0MK5IryBJvpWtHK/jpahIqopC l40I7RtkgnVup4p+cL64Btm5tpztSNFwRwvsmiE48qyXUZ5GgBRJz70yBTegXygGn9JQ Ri2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc:content-transfer-encoding; bh=LaJ+t4TMj3YE4Z4t0DmwOZ1IkC+hs24edAZmaTUmJpc=; b=VLdISotmmTFmLaCGDrJdWz0GDPcwIGrv/3r0VCRg83S41JODnmvc6oSAOQ59815vuY UU6GyKLTIrsM6kbIUDuH2NZwv/oi4GwfJjGn0feG5JROyrU6EiCoPSqjddSe3pWnpt11 1U/KHbgTQjId58dIQ7axbkw5SqJC6fI3witbIScNCDGjFPOgcVaccsUE0a+bWBBxmZiY 432Kl/mC/yXyRhaEJOyUXwHt9uJdYECb44RKCF3DvcPCHaXi+wVFWevz/w1IK9csRmsB C0KG5b8zLkyXltVrcyL3dcv8Hhz0dBBKdzfx9RLwQhklWtqMSUXq5eVHBtGEoAumxWLZ qc1A== X-Gm-Message-State: AOAM530+KdaNfuso+XZtpaDOZa13IJKfqlQk6vWnrZsW34P4xGI+/2s0 d6JI4/0ycFViO+NjJRqNNNteEHIZTMqOs2yACTE= X-Google-Smtp-Source: ABdhPJzJIDfnI7FsZYDygQKhke45+O5sMv8nvLabU9nEDgWjNKjq499mlsSIGSHTjuMgz7jIwWuYW2IZ4D6Nf1r1kAw= X-Received: by 2002:a05:651c:2121:b0:24b:5d31:fcd with SMTP id a33-20020a05651c212100b0024b5d310fcdmr3564886ljq.19.1650166120885; Sat, 16 Apr 2022 20:28:40 -0700 (PDT) In-Reply-To: <67901569-bf14-b973-9de2-0f5d68aafe96@cs.ucla.edu> Received-SPF: pass client-ip=2a00:1450:4864:20::231; envelope-from=noloader@gmail.com; helo=mail-lj1-x231.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnulib-bounces+gnu-bug-gnulib=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnulib" Xref: news.gmane.io gmane.comp.lib.gnulib.bugs:45784 gmane.emacs.devel:288519 Archived-At: On Sat, Apr 16, 2022 at 10:21 PM Paul Eggert wrote: > > On 4/15/22 09:22, Mattias Engdeg=C3=A5rd wrote: > > Paul, would you consider something like that patch (repeated here) for = gnulib? > > Sure, I installed the attached into Gnulib master on Savannah. > > I suppose it wouldn't hurt for an old Mac OS X expert to check the other > uses of __clang_major__ in Emacs. This looks like Apple Clang vs LLVM Clang. You should use __apple_build_version__ to differentiate between the two. Stepping back a bit, rather than doing the Clang gyrations everywhere you use __clang_major__ , maybe you should define a couple of macros like GNULIB_LLVM_CLANG_VER and GNULIB_APPLE_CLANG_VER in a fashion similar to GCC_VERSION from https://gcc.gnu.org/onlinedocs/cpp/Common-Predefined-Macros.html: #define GCC_VERSION (__GNUC__ * 10000 \ + __GNUC_MINOR__ * 100 \ + __GNUC_PATCHLEVEL__) Then you can check versions in the code like: #if defined(__clang__) && defined(__apple_build_version__) # define GNULIB_APPLE_CLANG_VER (__clang_major__ * 10000 + __clang_minor__ * 100 + __clang_patchlevel__) #elif defined(__clang__) # define GNULIB_LLVM_CLANG_VER (__clang_major__ * 10000 + __clang_minor__ * 100 + __clang_patchlevel__) #elif defined(__GNUC__) # define GNULIB_GCC_VER (__GNUC__ * 10000 + __GNUC_MINOR__ * 100 + __GNUC_PATCHLEVEL__) #endif #if (GNULIB_GCC_VER >=3D 40200) || \ (GNULIB_APPLE_CLANG_VER >=3D 40200) || \ (GNULIB_LLVM_CLANG_VER >=3D 30200) ... #endif Jeff