unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Jeffrey Walton <noloader@gmail.com>
To: Emacs developers <emacs-devel@gnu.org>
Subject: warning: unsequenced modification and access to 'sa_avail'
Date: Sat, 27 Mar 2021 12:05:00 -0400	[thread overview]
Message-ID: <CAH8yC8n5-26GWt7YuGUQSs6waWR1bXO9mngu_CZh9AxuaOe-JQ@mail.gmail.com> (raw)

Hi Everyone,

I'm building Emacs 27.2 on the Apple M1 machine. I think the compiler
is complaining about undefined behavior:

    sa_avail -= (size), alloca (size)

I think it is equivalent to something like this:

    data[i] = data[i++];

/usr/bin/clang -c -I/usr/local/include -DNDEBUG -Demacs  -I. -I.
-I../lib -I../lib         -I/usr/local/include/libxml2
-I/usr/local/include              -MMD -MF deps/doc.d -MP
-I/usr/local/include -I/usr/local/include/p11-kit-1    -Wno-switch
-Wno-pointer-sign -Wno-string-plus-int -Wno-unknown-attributes
-Wno-initializer-overrides -Wno-tautological-compare
-Wno-tautological-constant-out-of-range-compare -g2 -O2 -fno-common
-arch arm64 -fPIC -pthread  doc.c
/usr/bin/clang -c -I/usr/local/include -DNDEBUG -Demacs  -I. -I.
-I../lib -I../lib         -I/usr/local/include/libxml2
-I/usr/local/include              -MMD -MF deps/editfns.d -MP
-I/usr/local/include -I/usr/local/include/p11-kit-1    -Wno-switch
-Wno-pointer-sign -Wno-string-plus-int -Wno-unknown-attributes
-Wno-initializer-overrides -Wno-tautological-compare
-Wno-tautological-constant-out-of-range-compare -g2 -O2 -fno-common
-arch arm64 -fPIC -pthread  editfns.c
editfns.c:2063:18: warning: unsequenced modification and access to 'sa_avail'
      [-Wunsequenced]
    .deletions = SAFE_ALLOCA (del_bytes),
                 ^
./lisp.h:4817:9: note: expanded from macro 'SAFE_ALLOCA'
                           ? AVAIL_ALLOCA (size)                        \
                             ^
./lisp.h:4812:38: note: expanded from macro 'AVAIL_ALLOCA'
#define AVAIL_ALLOCA(size) (sa_avail -= (size), alloca (size))
                                     ^

Jeff



             reply	other threads:[~2021-03-27 16:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-27 16:05 Jeffrey Walton [this message]
2021-03-27 17:01 ` warning: unsequenced modification and access to 'sa_avail' Philipp
2021-03-27 17:10   ` Jeffrey Walton
2021-03-27 17:17     ` Philipp
2021-03-27 19:05     ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAH8yC8n5-26GWt7YuGUQSs6waWR1bXO9mngu_CZh9AxuaOe-JQ@mail.gmail.com \
    --to=noloader@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).