From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jeffrey Walton Newsgroups: gmane.emacs.devel Subject: Re: warning: unsequenced modification and access to 'sa_avail' Date: Sat, 27 Mar 2021 13:10:15 -0400 Message-ID: References: <9BE71EF8-F41A-4E65-B91C-1D36643791B9@gmail.com> Reply-To: noloader@gmail.com Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38796"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Emacs developers To: Philipp Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Mar 27 18:11:31 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lQCTD-000A1Z-6m for ged-emacs-devel@m.gmane-mx.org; Sat, 27 Mar 2021 18:11:31 +0100 Original-Received: from localhost ([::1]:45432 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lQCTC-0000va-7z for ged-emacs-devel@m.gmane-mx.org; Sat, 27 Mar 2021 13:11:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60568) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lQCSR-0000Vn-II for emacs-devel@gnu.org; Sat, 27 Mar 2021 13:10:43 -0400 Original-Received: from mail-il1-x12d.google.com ([2607:f8b0:4864:20::12d]:46036) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lQCSM-0006sD-HB for emacs-devel@gnu.org; Sat, 27 Mar 2021 13:10:43 -0400 Original-Received: by mail-il1-x12d.google.com with SMTP id w2so7268155ilj.12 for ; Sat, 27 Mar 2021 10:10:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:reply-to:from:date:message-id :subject:to:cc; bh=kGnXLu0ntk2SS27pINJlANnbOT7rXNvZZiu093mQOmI=; b=MAZl0leMgizr4FADnexTWUxdQHmYtH1LbEkxG5NtpuYB6aA03g3Oi9zSS4W9K/gnqA cMpQxkRzzPUvIKx0tcq7XNpHy7uOHhPcqnBD5Q7sEbl4hr3OzAS1uQDZ2oIv/GPUqNeN +AdtXwTJ3zw5zt1be+6zpbn7zkDfSMX0EWxhyJgigweQJjW/8cyfXmVYRBDV1RfPQbcS FcG3PwjuOdkNqEjj1aRmxacUEBCmLp0HNai7266GVPUG2/1OTFePx+rGaktSpIOFPhXt 03Py4ZIxIT/tl5o8qcOyHkm00BMJEUQ1N8kwv//qr1gXzdhPfXPjBzTssVWqf9RlIzo0 8kCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=kGnXLu0ntk2SS27pINJlANnbOT7rXNvZZiu093mQOmI=; b=o1MOR9+79aNW+29PhS/eAiYnI34C/vknodBlywppv8jlSr0V1O62Df480X5MNJraBx ckhpZGq8fU35sPK6ThIGTKEtzOSVijWKzaDYLfZPyta2EAz8t4w7d0ynSIIg9I7eVRee /paHFDPm8buIl5nkTnd2xXhr8jr4LLbcqVWJ9xAnHPED6M+J5dZJIcd2rMp9Lrj14Vet D99F4jfKNDPfvSpw5KQIMLQoBncXR16fhm5uxCBfptMlLsdC9MI6rIzPC5mTzrhbCDZo MeMszyrB10VIfiF26ZM2tR2xfhNM9g8ro7RIPKrFKbforf9EmQC0/VNewueyAMfQ2rzG v8QA== X-Gm-Message-State: AOAM531Tg9eNCLQEs6+92UkTM4gvUiFLJd1OldqTf31z7LgExdAaJkc1 kvyPKJIU1ECkAoR+XGNmb0/BGW+DMdT5C4BmHog= X-Google-Smtp-Source: ABdhPJza98qgrLE2rgYtZpcrzUDkLZ1+6xcEayvlF0DG3u+SBi1xsmq5QDGlEAlTNd6yJu+4qWwCMck9yX+dIXqwdFg= X-Received: by 2002:a92:c56f:: with SMTP id b15mr14795776ilj.41.1616865036262; Sat, 27 Mar 2021 10:10:36 -0700 (PDT) In-Reply-To: <9BE71EF8-F41A-4E65-B91C-1D36643791B9@gmail.com> Received-SPF: pass client-ip=2607:f8b0:4864:20::12d; envelope-from=noloader@gmail.com; helo=mail-il1-x12d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:267109 Archived-At: On Sat, Mar 27, 2021 at 1:01 PM Philipp wrote: > > > Am 27.03.2021 um 17:05 schrieb Jeffrey Walton : > > > > I'm building Emacs 27.2 on the Apple M1 machine. I think the compiler > > is complaining about undefined behavior: > > > > sa_avail -= (size), alloca (size) > > > > I think it is equivalent to something like this: > > > > data[i] = data[i++]; > > > > /usr/bin/clang -c -I/usr/local/include -DNDEBUG -Demacs -I. -I. > > -I../lib -I../lib -I/usr/local/include/libxml2 > > -I/usr/local/include -MMD -MF deps/doc.d -MP > > -I/usr/local/include -I/usr/local/include/p11-kit-1 -Wno-switch > > -Wno-pointer-sign -Wno-string-plus-int -Wno-unknown-attributes > > -Wno-initializer-overrides -Wno-tautological-compare > > -Wno-tautological-constant-out-of-range-compare -g2 -O2 -fno-common > > -arch arm64 -fPIC -pthread doc.c > > /usr/bin/clang -c -I/usr/local/include -DNDEBUG -Demacs -I. -I. > > -I../lib -I../lib -I/usr/local/include/libxml2 > > -I/usr/local/include -MMD -MF deps/editfns.d -MP > > -I/usr/local/include -I/usr/local/include/p11-kit-1 -Wno-switch > > -Wno-pointer-sign -Wno-string-plus-int -Wno-unknown-attributes > > -Wno-initializer-overrides -Wno-tautological-compare > > -Wno-tautological-constant-out-of-range-compare -g2 -O2 -fno-common > > -arch arm64 -fPIC -pthread editfns.c > > editfns.c:2063:18: warning: unsequenced modification and access to 'sa_avail' > > [-Wunsequenced] > > .deletions = SAFE_ALLOCA (del_bytes), > > ^ > > ./lisp.h:4817:9: note: expanded from macro 'SAFE_ALLOCA' > > ? AVAIL_ALLOCA (size) \ > > ^ > > ./lisp.h:4812:38: note: expanded from macro 'AVAIL_ALLOCA' > > #define AVAIL_ALLOCA(size) (sa_avail -= (size), alloca (size)) > > ^ > > > > This has already been fixed by commit 6a4ed891d84b1ca1e4d68a6de9dd374f1fadd971, which hasn't made it into the release though. Thanks Philipp. Forgive my ignorance... Where is that commit? I can't seem to find it at https://git.savannah.gnu.org/cgit/emacs.git/log/?h=emacs-27. Searching the logs for your name, and searching for 6a4ed891d84b1ca1e4d68a6de9dd374f1fadd971 (and 6a4ed891d84b) returns 0 hits. Jeff